Title: [221202] trunk/Source/WebCore
- Revision
- 221202
- Author
- [email protected]
- Date
- 2017-08-25 13:10:51 -0700 (Fri, 25 Aug 2017)
Log Message
REGRESSION(r221017): Quip stuck in a perpetual loading loop
https://bugs.webkit.org/show_bug.cgi?id=175991
<rdar://problem/34044445>
Reviewed by Daniel Bates.
This is a quick fix to return proper function to WebKit. I'll relate a follow-up fix that
addresses WebSockets more completely.
* platform/network/mac/CookieJarMac.mm:
(WebCore::cookieRequestHeaderFieldValue): Don't hard code a value of 'No' for returning secure
cookies. HTTPS connection should get secure cookies.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (221201 => 221202)
--- trunk/Source/WebCore/ChangeLog 2017-08-25 20:09:31 UTC (rev 221201)
+++ trunk/Source/WebCore/ChangeLog 2017-08-25 20:10:51 UTC (rev 221202)
@@ -1,3 +1,18 @@
+2017-08-25 Brent Fulgham <[email protected]>
+
+ REGRESSION(r221017): Quip stuck in a perpetual loading loop
+ https://bugs.webkit.org/show_bug.cgi?id=175991
+ <rdar://problem/34044445>
+
+ Reviewed by Daniel Bates.
+
+ This is a quick fix to return proper function to WebKit. I'll relate a follow-up fix that
+ addresses WebSockets more completely.
+
+ * platform/network/mac/CookieJarMac.mm:
+ (WebCore::cookieRequestHeaderFieldValue): Don't hard code a value of 'No' for returning secure
+ cookies. HTTPS connection should get secure cookies.
+
2017-08-25 Youenn Fablet <[email protected]>
Add support for ReadableStream storage in FetchBody
Modified: trunk/Source/WebCore/platform/network/mac/CookieJarMac.mm (221201 => 221202)
--- trunk/Source/WebCore/platform/network/mac/CookieJarMac.mm 2017-08-25 20:09:31 UTC (rev 221201)
+++ trunk/Source/WebCore/platform/network/mac/CookieJarMac.mm 2017-08-25 20:10:51 UTC (rev 221202)
@@ -178,7 +178,8 @@
String cookieRequestHeaderFieldValue(const NetworkStorageSession& session, const URL& firstParty, const URL& url)
{
bool ignore = false;
- return cookiesForSession(session, firstParty, url, IncludeHTTPOnly, IncludeSecureCookies::No, ignore);
+ auto includeSecureCookies = url.protocolIs("https") ? IncludeSecureCookies::Yes : IncludeSecureCookies::No;
+ return cookiesForSession(session, firstParty, url, IncludeHTTPOnly, includeSecureCookies, ignore);
}
void setCookiesFromDOM(const NetworkStorageSession& session, const URL& firstParty, const URL& url, const String& cookieStr)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
