Title: [221242] releases/WebKitGTK/webkit-2.18
- Revision
- 221242
- Author
- [email protected]
- Date
- 2017-08-28 04:53:46 -0700 (Mon, 28 Aug 2017)
Log Message
Merge r220910 - [GTK] Show controls if a video element isn't allowed to play inline.
https://bugs.webkit.org/show_bug.cgi?id=141705
Patch by Ms2ger <[email protected]> on 2017-08-18
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Test: covered by media/video-fullscreeen-only-controls.html [sic].
* Modules/mediacontrols/mediaControlsGtk.js:
(ControllerGtk.prototype.shouldHaveControls):
LayoutTests:
* platform/gtk/TestExpectations: enable test for this case.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog (221241 => 221242)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog 2017-08-28 11:52:55 UTC (rev 221241)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog 2017-08-28 11:53:46 UTC (rev 221242)
@@ -1,3 +1,12 @@
+2017-08-18 Ms2ger <[email protected]>
+
+ [GTK] Show controls if a video element isn't allowed to play inline.
+ https://bugs.webkit.org/show_bug.cgi?id=141705
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * platform/gtk/TestExpectations: enable test for this case.
+
2017-08-17 Antti Koivisto <[email protected]>
RenderListItem - Avoid render tree mutation during layout
Modified: releases/WebKitGTK/webkit-2.18/LayoutTests/platform/gtk/TestExpectations (221241 => 221242)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/platform/gtk/TestExpectations 2017-08-28 11:52:55 UTC (rev 221241)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/platform/gtk/TestExpectations 2017-08-28 11:53:46 UTC (rev 221242)
@@ -920,8 +920,6 @@
webkit.org/b/141699 fast/attachment/attachment-rendering.html [ Failure ]
webkit.org/b/141699 fast/attachment/attachment-respects-css-size.html [ ImageOnlyFailure ]
-webkit.org/b/141705 media/video-fullscreeen-only-controls.html [ Failure ]
-
webkit.org/b/141831 svg/animations/animate-text-nested-transforms.html [ Failure ]
webkit.org/b/98653 svg/text/lengthAdjust-text-metrics.html [ Failure ]
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog (221241 => 221242)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog 2017-08-28 11:52:55 UTC (rev 221241)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog 2017-08-28 11:53:46 UTC (rev 221242)
@@ -1,3 +1,15 @@
+2017-08-18 Ms2ger <[email protected]>
+
+ [GTK] Show controls if a video element isn't allowed to play inline.
+ https://bugs.webkit.org/show_bug.cgi?id=141705
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ Test: covered by media/video-fullscreeen-only-controls.html [sic].
+
+ * Modules/mediacontrols/mediaControlsGtk.js:
+ (ControllerGtk.prototype.shouldHaveControls):
+
2017-08-17 Antti Koivisto <[email protected]>
RenderListItem - Avoid render tree mutation during layout
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js (221241 => 221242)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js 2017-08-28 11:52:55 UTC (rev 221241)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js 2017-08-28 11:53:46 UTC (rev 221242)
@@ -56,6 +56,9 @@
shouldHaveControls: function()
{
+ if (!this.isAudio() && !this.host.allowsInlineMediaPlayback)
+ return true;
+
return this.video.controls || this.isFullScreen();
},
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
