Title: [221261] trunk/LayoutTests
Revision
221261
Author
[email protected]
Date
2017-08-28 09:52:48 -0700 (Mon, 28 Aug 2017)

Log Message

Fix document-create-touch.html.
https://bugs.webkit.org/show_bug.cgi?id=172813

Patch by Ms2ger <[email protected]> on 2017-08-28
Reviewed by Michael Catanzaro.

The document.createTouch() call is supposed to throw an exception (as
defined by WebIDL). It has been doing this since r203941, but this
wasn't noticed because the entire fast/events/touch folder is skipped
on mac, ios and win.

* fast/events/touch/document-create-touch-expected.txt:
* fast/events/touch/document-create-touch.html:
* platform/gtk/TestExpectations:
* platform/gtk/fast/events/touch/document-create-touch-expected.txt: Removed.
* platform/wpe/TestExpectations:

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (221260 => 221261)


--- trunk/LayoutTests/ChangeLog	2017-08-28 16:37:31 UTC (rev 221260)
+++ trunk/LayoutTests/ChangeLog	2017-08-28 16:52:48 UTC (rev 221261)
@@ -1,3 +1,21 @@
+2017-08-28  Ms2ger  <[email protected]>
+
+        Fix document-create-touch.html.
+        https://bugs.webkit.org/show_bug.cgi?id=172813
+
+        Reviewed by Michael Catanzaro.
+
+        The document.createTouch() call is supposed to throw an exception (as
+        defined by WebIDL). It has been doing this since r203941, but this
+        wasn't noticed because the entire fast/events/touch folder is skipped
+        on mac, ios and win.
+
+        * fast/events/touch/document-create-touch-expected.txt:
+        * fast/events/touch/document-create-touch.html:
+        * platform/gtk/TestExpectations:
+        * platform/gtk/fast/events/touch/document-create-touch-expected.txt: Removed.
+        * platform/wpe/TestExpectations:
+
 2017-08-28  Ryan Haddad  <[email protected]>
 
         Rebaseline js/dom/global-constructors-attributes.html after r221209.

Modified: trunk/LayoutTests/fast/events/touch/document-create-touch-expected.txt (221260 => 221261)


--- trunk/LayoutTests/fast/events/touch/document-create-touch-expected.txt	2017-08-28 16:37:31 UTC (rev 221260)
+++ trunk/LayoutTests/fast/events/touch/document-create-touch-expected.txt	2017-08-28 16:52:48 UTC (rev 221261)
@@ -26,17 +26,9 @@
 PASS emptyTouch.webkitRadiusY is 0
 PASS emptyTouch.webkitRotationAngle is NaN
 PASS emptyTouch.webkitForce is NaN
-PASS badParamsTouch is non-null.
-PASS badParamsTouch.target is null
-PASS badParamsTouch.identifier is 0
-PASS badParamsTouch.pageX is 0
-PASS badParamsTouch.pageY is 0
-PASS badParamsTouch.screenX is 0
-PASS badParamsTouch.screenY is 104
-PASS badParamsTouch.webkitRadiusX is 0
-PASS badParamsTouch.webkitRadiusY is 0
-PASS badParamsTouch.webkitRotationAngle is NaN
-PASS badParamsTouch.webkitForce is NaN
+PASS function () {
+  document.createTouch(function(x) { return x; }, 12, 'a', 'b', 'c', function(x) { return x; }, 104, 'a', 'b', 'c', 'd');
+} threw exception TypeError: Argument 1 ('window') to Document.createTouch must be an instance of DOMWindow.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/events/touch/document-create-touch.html (221260 => 221261)


--- trunk/LayoutTests/fast/events/touch/document-create-touch.html	2017-08-28 16:37:31 UTC (rev 221260)
+++ trunk/LayoutTests/fast/events/touch/document-create-touch.html	2017-08-28 16:52:48 UTC (rev 221261)
@@ -50,18 +50,9 @@
 shouldBeNaN("emptyTouch.webkitForce");
 
 // Try invoking with incorrect parameter types.
-var badParamsTouch = document.createTouch(function(x) { return x; }, 12, 'a', 'b', 'c', function(x) { return x; }, 104, 'a', 'b', 'c', 'd');
-shouldBeNonNull("badParamsTouch");
-shouldBeNull("badParamsTouch.target");
-shouldBe("badParamsTouch.identifier", "0");
-shouldBe("badParamsTouch.pageX", "0");
-shouldBe("badParamsTouch.pageY", "0");
-shouldBe("badParamsTouch.screenX", "0");
-shouldBe("badParamsTouch.screenY", "104");
-shouldBe("badParamsTouch.webkitRadiusX", "0");
-shouldBe("badParamsTouch.webkitRadiusY", "0");
-shouldBeNaN("badParamsTouch.webkitRotationAngle");
-shouldBeNaN("badParamsTouch.webkitForce");
+shouldThrow(function() {
+  document.createTouch(function(x) { return x; }, 12, 'a', 'b', 'c', function(x) { return x; }, 104, 'a', 'b', 'c', 'd');
+}, "\"TypeError: Argument 1 ('window') to Document.createTouch must be an instance of DOMWindow\"");
 isSuccessfullyParsed();
 </script>
 </body>

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (221260 => 221261)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-08-28 16:37:31 UTC (rev 221260)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-08-28 16:52:48 UTC (rev 221261)
@@ -3324,8 +3324,6 @@
 
 webkit.org/b/172812 fast/canvas/webgl/lose-context-on-status-failure.html [ Failure ]
 
-webkit.org/b/172813 fast/events/touch/document-create-touch.html [ Failure ]
-
 webkit.org/b/172814 media/restricted-audio-playback-with-multiple-settimeouts.html [ Failure ]
 
 webkit.org/b/173410 fast/canvas/canvas-createPattern-video-loading.html [ Failure ]

Deleted: trunk/LayoutTests/platform/gtk/fast/events/touch/document-create-touch-expected.txt (221260 => 221261)


--- trunk/LayoutTests/platform/gtk/fast/events/touch/document-create-touch-expected.txt	2017-08-28 16:37:31 UTC (rev 221260)
+++ trunk/LayoutTests/platform/gtk/fast/events/touch/document-create-touch-expected.txt	2017-08-28 16:52:48 UTC (rev 221261)
@@ -1,30 +0,0 @@
-CONSOLE MESSAGE: line 39: TypeError: Argument 1 ('window') to Document.createTouch must be an instance of DOMWindow
-This tests support for the document.createTouch API.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS "createTouch" in document is true
-PASS touch is non-null.
-PASS touch.target is box
-PASS touch.identifier is 1
-PASS touch.pageX is 100
-PASS touch.pageY is 101
-PASS touch.screenX is 102
-PASS touch.screenY is 103
-PASS touch.webkitRadiusX is 5
-PASS touch.webkitRadiusY is 3
-PASS touch.webkitRotationAngle is 10
-PASS touch.webkitForce is 10
-PASS emptyTouch is non-null.
-PASS emptyTouch.target is null
-PASS emptyTouch.identifier is 0
-PASS emptyTouch.pageX is 0
-PASS emptyTouch.pageY is 0
-PASS emptyTouch.screenX is 0
-PASS emptyTouch.screenY is 0
-PASS emptyTouch.webkitRadiusX is 0
-PASS emptyTouch.webkitRadiusY is 0
-PASS emptyTouch.webkitRotationAngle is NaN
-PASS emptyTouch.webkitForce is NaN
-

Modified: trunk/LayoutTests/platform/wpe/TestExpectations (221260 => 221261)


--- trunk/LayoutTests/platform/wpe/TestExpectations	2017-08-28 16:37:31 UTC (rev 221260)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2017-08-28 16:52:48 UTC (rev 221261)
@@ -513,7 +513,6 @@
 webkit.org/b/173419 fast/events/touch/basic-multi-touch-events-limited.html [ Failure ]
 webkit.org/b/173419 fast/events/touch/basic-multi-touch-events.html [ Failure ]
 webkit.org/b/173419 fast/events/touch/document-create-touch-list.html [ Failure ]
-webkit.org/b/173419 fast/events/touch/document-create-touch.html [ Failure ]
 webkit.org/b/173419 fast/events/touch/emulate-touch-events.html [ Failure ]
 webkit.org/b/173419 fast/events/touch/touch-before-pressing-spin-button.html [ Failure ]
 webkit.org/b/173419 fast/events/webkit-media-key-events-constructor.html [ Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to