Title: [221281] trunk/Source/WebKit
- Revision
- 221281
- Author
- [email protected]
- Date
- 2017-08-28 16:56:25 -0700 (Mon, 28 Aug 2017)
Log Message
Fix incorrect enum in atBoundaryOfGranularity call
https://bugs.webkit.org/show_bug.cgi?id=176004
Reviewed by Wenson Hsieh and Enrica Casucci
Enum that was being used was incorrect, as that case in not covered in called function.
Resulted in a no-op. Should now have correct behavior around line boundaries.
Not possible to add tests for selections with velocity. Will attempt to add this behavior later.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::rangeAtWordBoundaryForPosition):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (221280 => 221281)
--- trunk/Source/WebKit/ChangeLog 2017-08-28 23:29:54 UTC (rev 221280)
+++ trunk/Source/WebKit/ChangeLog 2017-08-28 23:56:25 UTC (rev 221281)
@@ -1,3 +1,18 @@
+2017-08-28 Megan Gardner <[email protected]>
+
+ Fix incorrect enum in atBoundaryOfGranularity call
+ https://bugs.webkit.org/show_bug.cgi?id=176004
+
+ Reviewed by Wenson Hsieh and Enrica Casucci
+
+ Enum that was being used was incorrect, as that case in not covered in called function.
+ Resulted in a no-op. Should now have correct behavior around line boundaries.
+
+ Not possible to add tests for selections with velocity. Will attempt to add this behavior later.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::rangeAtWordBoundaryForPosition):
+
2017-08-28 Stephan Szabo <[email protected]>
[WinCairo] Add PlatformWin cmake for Webkit
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (221280 => 221281)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2017-08-28 23:29:54 UTC (rev 221280)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2017-08-28 23:56:25 UTC (rev 221281)
@@ -1246,10 +1246,10 @@
// If this is where the extent was initially, then iterate in the other direction in the document until we hit the next word.
while (extent.isNotNull()
- && !atBoundaryOfGranularity(extent, WordGranularity, sameDirection)
- && extent != base
- && !atBoundaryOfGranularity(extent, LineBoundary, sameDirection)
- && !atBoundaryOfGranularity(extent, LineBoundary, oppositeDirection)) {
+ && !atBoundaryOfGranularity(extent, WordGranularity, sameDirection)
+ && extent != base
+ && !atBoundaryOfGranularity(extent, LineGranularity, sameDirection)
+ && !atBoundaryOfGranularity(extent, LineGranularity, oppositeDirection)) {
extent = baseIsStart ? extent.next() : extent.previous();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
