Title: [221349] trunk/Source/WebKit
Revision
221349
Author
carlo...@webkit.org
Date
2017-08-30 01:40:17 -0700 (Wed, 30 Aug 2017)

Log Message

Unreviewed. Try to fix layout test timing out after r221344.

There seems to be an infinite loop in the web process when WebPage::platformEditorState is called with non
content editable result.

* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformEditorState const):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (221348 => 221349)


--- trunk/Source/WebKit/ChangeLog	2017-08-30 08:22:54 UTC (rev 221348)
+++ trunk/Source/WebKit/ChangeLog	2017-08-30 08:40:17 UTC (rev 221349)
@@ -1,3 +1,13 @@
+2017-08-30  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        Unreviewed. Try to fix layout test timing out after r221344.
+
+        There seems to be an infinite loop in the web process when WebPage::platformEditorState is called with non
+        content editable result.
+
+        * WebProcess/WebPage/gtk/WebPageGtk.cpp:
+        (WebKit::WebPage::platformEditorState const):
+
 2017-08-29  Carlos Garcia Campos  <cgar...@igalia.com>
 
         REGRESSION(r221064): [GTK] Editor not correctly working after r221064

Modified: trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp (221348 => 221349)


--- trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp	2017-08-30 08:22:54 UTC (rev 221348)
+++ trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp	2017-08-30 08:40:17 UTC (rev 221349)
@@ -74,7 +74,7 @@
 
 void WebPage::platformEditorState(Frame& frame, EditorState& result, IncludePostLayoutDataHint shouldIncludePostLayoutData) const
 {
-    if (shouldIncludePostLayoutData == IncludePostLayoutDataHint::No || !frame.view() || frame.view()->needsLayout() || !result.isContentEditable) {
+    if (shouldIncludePostLayoutData == IncludePostLayoutDataHint::No || !frame.view() || frame.view()->needsLayout()) {
         result.isMissingPostLayoutData = true;
         return;
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to