Title: [100061] trunk/Source/WebKit/qt
- Revision
- 100061
- Author
- [email protected]
- Date
- 2011-11-11 18:58:11 -0800 (Fri, 11 Nov 2011)
Log Message
[Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=72193
Patch by Luiz Agostini <[email protected]> on 2011-11-11
Reviewed by Noam Rosenthal.
Part of PopupMenuQt.cpp code is guarded by #ifndef QT_NO_COMBOBOX although that
code is not related to the class QComboBox.
* WebCoreSupport/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::show):
Modified Paths
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (100060 => 100061)
--- trunk/Source/WebKit/qt/ChangeLog 2011-11-12 02:56:27 UTC (rev 100060)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-11-12 02:58:11 UTC (rev 100061)
@@ -1,3 +1,16 @@
+2011-11-11 Luiz Agostini <[email protected]>
+
+ [Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=72193
+
+ Reviewed by Noam Rosenthal.
+
+ Part of PopupMenuQt.cpp code is guarded by #ifndef QT_NO_COMBOBOX although that
+ code is not related to the class QComboBox.
+
+ * WebCoreSupport/PopupMenuQt.cpp:
+ (WebCore::PopupMenuQt::show):
+
2011-11-11 Bruno de Oliveira Abinader <[email protected]>
[Qt] Skip tests when no network is present
Modified: trunk/Source/WebKit/qt/WebCoreSupport/PopupMenuQt.cpp (100060 => 100061)
--- trunk/Source/WebKit/qt/WebCoreSupport/PopupMenuQt.cpp 2011-11-12 02:56:27 UTC (rev 100060)
+++ trunk/Source/WebKit/qt/WebCoreSupport/PopupMenuQt.cpp 2011-11-12 02:58:11 UTC (rev 100061)
@@ -29,7 +29,6 @@
#include "ChromeClientQt.h"
#include "FrameView.h"
#include "PopupMenuClient.h"
-#include "QtFallbackWebPopup.h"
#include "qwebkitplatformplugin.h"
@@ -97,7 +96,6 @@
void PopupMenuQt::show(const IntRect& rect, FrameView* view, int index)
{
-#ifndef QT_NO_COMBOBOX
if (!m_popupClient)
return;
@@ -114,7 +112,6 @@
m_selectData = adoptPtr(new SelectData(m_popupClient));
m_popup->show(*m_selectData.get());
-#endif
}
void PopupMenuQt::didHide()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
