Title: [221401] trunk/PerformanceTests
- Revision
- 221401
- Author
- commit-qu...@webkit.org
- Date
- 2017-08-30 15:45:26 -0700 (Wed, 30 Aug 2017)
Log Message
Speedometer 2.0: jQuery test fails occasionally
https://bugs.webkit.org/show_bug.cgi?id=176017
Patch by Shiyu Zhang <shiyu.zh...@intel.com> on 2017-08-30
Reviewed by Ryosuke Niwa.
Create a dummy node to notify that app is ready for jQuery suite. It prevents Speedometer injecting items before app.js is loaded.
* Speedometer/resources/tests.js:
(Suites.push.prepare):
* Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js:
(jQuery.App.init):
Modified Paths
Diff
Modified: trunk/PerformanceTests/ChangeLog (221400 => 221401)
--- trunk/PerformanceTests/ChangeLog 2017-08-30 22:27:09 UTC (rev 221400)
+++ trunk/PerformanceTests/ChangeLog 2017-08-30 22:45:26 UTC (rev 221401)
@@ -1,3 +1,17 @@
+2017-08-30 Shiyu Zhang <shiyu.zh...@intel.com>
+
+ Speedometer 2.0: jQuery test fails occasionally
+ https://bugs.webkit.org/show_bug.cgi?id=176017
+
+ Reviewed by Ryosuke Niwa.
+
+ Create a dummy node to notify that app is ready for jQuery suite. It prevents Speedometer injecting items before app.js is loaded.
+
+ * Speedometer/resources/tests.js:
+ (Suites.push.prepare):
+ * Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js:
+ (jQuery.App.init):
+
2017-08-25 Mathias Bynens <math...@qiwi.be>
Speedometer: Restructure Ember example
Modified: trunk/PerformanceTests/Speedometer/resources/tests.js (221400 => 221401)
--- trunk/PerformanceTests/Speedometer/resources/tests.js 2017-08-30 22:27:09 UTC (rev 221400)
+++ trunk/PerformanceTests/Speedometer/resources/tests.js 2017-08-30 22:45:26 UTC (rev 221401)
@@ -355,9 +355,10 @@
name: 'jQuery-TodoMVC',
url: 'todomvc/architecture-examples/jquery/index.html',
prepare: function (runner, contentWindow, contentDocument) {
- return runner.waitForElement('#new-todo').then(function (element) {
- element.focus();
- return element;
+ return runner.waitForElement('#appIsReady').then(function (element) {
+ var newTodo = contentDocument.getElementById('new-todo');
+ newTodo.focus();
+ return newTodo;
});
},
tests: [
Modified: trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js (221400 => 221401)
--- trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js 2017-08-30 22:27:09 UTC (rev 221400)
+++ trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js 2017-08-30 22:45:26 UTC (rev 221401)
@@ -46,6 +46,10 @@
this.render();
}.bind(this)
}).init('/all');
+
+ var dummyNodeToNotifyAppIsReady = document.createElement('div');
+ dummyNodeToNotifyAppIsReady.id = 'appIsReady';
+ document.body.appendChild(dummyNodeToNotifyAppIsReady);
},
bindEvents: function () {
$('#new-todo').on('keyup', this.create.bind(this));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
