Title: [221453] trunk/Source/_javascript_Core
- Revision
- 221453
- Author
- [email protected]
- Date
- 2017-08-31 16:19:31 -0700 (Thu, 31 Aug 2017)
Log Message
useSeparatedWXHeap should never be true when not on iOS
https://bugs.webkit.org/show_bug.cgi?id=176190
Reviewed by JF Bastien.
If you set useSeparatedWXHeap to true on X86_64, and launch the jsc shell,
the process insta-crashes. Let's silently ignore that option and set it
to false when not on iOS.
* runtime/Options.cpp:
(JSC::recomputeDependentOptions):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (221452 => 221453)
--- trunk/Source/_javascript_Core/ChangeLog 2017-08-31 23:19:18 UTC (rev 221452)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-08-31 23:19:31 UTC (rev 221453)
@@ -1,3 +1,17 @@
+2017-08-31 Saam Barati <[email protected]>
+
+ useSeparatedWXHeap should never be true when not on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=176190
+
+ Reviewed by JF Bastien.
+
+ If you set useSeparatedWXHeap to true on X86_64, and launch the jsc shell,
+ the process insta-crashes. Let's silently ignore that option and set it
+ to false when not on iOS.
+
+ * runtime/Options.cpp:
+ (JSC::recomputeDependentOptions):
+
2017-08-31 Filip Pizlo <[email protected]>
Fix debug crashes.
Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (221452 => 221453)
--- trunk/Source/_javascript_Core/runtime/Options.cpp 2017-08-31 23:19:18 UTC (rev 221452)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp 2017-08-31 23:19:31 UTC (rev 221453)
@@ -461,6 +461,8 @@
// be to have this option enabled, and have platforms that don't support
// it just silently use a single mapping.
Options::useSeparatedWXHeap() = true;
+#else
+ Options::useSeparatedWXHeap() = false;
#endif
if (Options::alwaysUseShadowChicken())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
