Title: [221732] trunk
- Revision
- 221732
- Author
- [email protected]
- Date
- 2017-09-07 08:42:46 -0700 (Thu, 07 Sep 2017)
Log Message
Unreviewed, rolling out r221716.
This change caused assertion failures on macOS Debug WK2.
Reverted changeset:
"Fetch's Response.statusText is unexpectedly the full http
status line for HTTP/2 responses"
https://bugs.webkit.org/show_bug.cgi?id=176479
http://trac.webkit.org/changeset/221716
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (221731 => 221732)
--- trunk/LayoutTests/ChangeLog 2017-09-07 15:39:42 UTC (rev 221731)
+++ trunk/LayoutTests/ChangeLog 2017-09-07 15:42:46 UTC (rev 221732)
@@ -1,3 +1,16 @@
+2017-09-07 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r221716.
+
+ This change caused assertion failures on macOS Debug WK2.
+
+ Reverted changeset:
+
+ "Fetch's Response.statusText is unexpectedly the full http
+ status line for HTTP/2 responses"
+ https://bugs.webkit.org/show_bug.cgi?id=176479
+ http://trac.webkit.org/changeset/221716
+
2017-09-07 Per Arne Vollan <[email protected]>
Update test expectations for failing tests on Windows.
Deleted: trunk/LayoutTests/http/wpt/fetch/response-status-text-expected.txt (221731 => 221732)
--- trunk/LayoutTests/http/wpt/fetch/response-status-text-expected.txt 2017-09-07 15:39:42 UTC (rev 221731)
+++ trunk/LayoutTests/http/wpt/fetch/response-status-text-expected.txt 2017-09-07 15:42:46 UTC (rev 221732)
@@ -1,6 +0,0 @@
-
-PASS Normal status text.
-PASS Abnormal status text.
-PASS Empty status text.
-PASS Garbage status line.
-
Deleted: trunk/LayoutTests/http/wpt/fetch/response-status-text.html (221731 => 221732)
--- trunk/LayoutTests/http/wpt/fetch/response-status-text.html 2017-09-07 15:39:42 UTC (rev 221731)
+++ trunk/LayoutTests/http/wpt/fetch/response-status-text.html 2017-09-07 15:42:46 UTC (rev 221732)
@@ -1,38 +0,0 @@
-<!doctype html>
-<html>
-<head>
- <meta charset="utf-8">
- <title>Response status and statusText given various HTTP response status lines.</title>
- <script src=""
- <script src=""
-</head>
-<body>
-<script>
-promise_test(test => {
- return fetch("resources/status-normal.txt").then((response) => {
- assert_equals(response.status, 200);
- assert_equals(response.statusText, "OK");
- });
-}, "Normal status text.");
-
-promise_test(test => {
- return fetch("resources/status-with-message.asis").then((response) => {
- assert_equals(response.status, 200);
- assert_equals(response.statusText, "Alpha");
- });
-}, "Abnormal status text.");
-
-promise_test(test => {
- return fetch("resources/status-without-message.asis").then((response) => {
- assert_equals(response.status, 200);
- assert_equals(response.statusText, "");
- });
-}, "Empty status text.");
-
-promise_test(test => {
- let promise = fetch("resources/status-garbage.asis");
- return promise_rejects(test, new TypeError(), promise);
-}, "Garbage status line.");
-</script>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (221731 => 221732)
--- trunk/Source/WebCore/ChangeLog 2017-09-07 15:39:42 UTC (rev 221731)
+++ trunk/Source/WebCore/ChangeLog 2017-09-07 15:42:46 UTC (rev 221732)
@@ -1,3 +1,16 @@
+2017-09-07 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r221716.
+
+ This change caused assertion failures on macOS Debug WK2.
+
+ Reverted changeset:
+
+ "Fetch's Response.statusText is unexpectedly the full http
+ status line for HTTP/2 responses"
+ https://bugs.webkit.org/show_bug.cgi?id=176479
+ http://trac.webkit.org/changeset/221716
+
2017-09-07 Zan Dobersek <[email protected]>
[EME] CDMClearKey: implement remaining methods of CDMPrivate derivative
Modified: trunk/Source/WebCore/platform/network/HTTPParsers.cpp (221731 => 221732)
--- trunk/Source/WebCore/platform/network/HTTPParsers.cpp 2017-09-07 15:39:42 UTC (rev 221731)
+++ trunk/Source/WebCore/platform/network/HTTPParsers.cpp 2017-09-07 15:42:46 UTC (rev 221732)
@@ -478,18 +478,12 @@
return ContentTypeOptionsNone;
}
-// For example: "HTTP/1.1 200 OK" => "OK".
-// Note that HTTP/2 does not include a reason phrase, so we return the empty atom.
AtomicString extractReasonPhraseFromHTTPStatusLine(const String& statusLine)
{
StringView view = statusLine;
size_t spacePos = view.find(' ');
-
// Remove status code from the status line.
spacePos = view.find(' ', spacePos + 1);
- if (spacePos == notFound)
- return emptyAtom();
-
return view.substring(spacePos + 1).toAtomicString();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
