Title: [221741] trunk/Tools
Revision
221741
Author
[email protected]
Date
2017-09-07 10:56:27 -0700 (Thu, 07 Sep 2017)

Log Message

bisect-builds started failing with invalid json
https://bugs.webkit.org/show_bug.cgi?id=176478
        
Once we hit 1000 items in our dynamoDB, we ran into an upper limit on the AWS API Gateway looping mechanism. 
This prevented us from doing a body mapping template to reformat the json. This fix is to simply return the raw json, 
and adjust the json parsing in our code. The AWS rest API has been fixed, and updated to v2. 
        
This change is for the script which operates against the endpoint.
        
Reviewed by Aakash Jain.

* Scripts/bisect-builds:
(get_sorted_revisions):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (221740 => 221741)


--- trunk/Tools/ChangeLog	2017-09-07 17:53:50 UTC (rev 221740)
+++ trunk/Tools/ChangeLog	2017-09-07 17:56:27 UTC (rev 221741)
@@ -1,3 +1,19 @@
+2017-09-07  Lucas Forschler  <[email protected]>
+
+        bisect-builds started failing with invalid json
+        https://bugs.webkit.org/show_bug.cgi?id=176478
+        
+        Once we hit 1000 items in our dynamoDB, we ran into an upper limit on the AWS API Gateway looping mechanism. 
+        This prevented us from doing a body mapping template to reformat the json. This fix is to simply return the raw json, 
+        and adjust the json parsing in our code. The AWS rest API has been fixed, and updated to v2. 
+        
+        This change is for the script which operates against the endpoint.
+        
+        Reviewed by Aakash Jain.
+
+        * Scripts/bisect-builds:
+        (get_sorted_revisions):
+
 2017-09-07  Filip Pizlo  <[email protected]>
 
         [WSL] Rationalize how protocol inheritance deals with type parameters

Modified: trunk/Tools/Scripts/bisect-builds (221740 => 221741)


--- trunk/Tools/Scripts/bisect-builds	2017-09-07 17:53:50 UTC (rev 221740)
+++ trunk/Tools/Scripts/bisect-builds	2017-09-07 17:56:27 UTC (rev 221741)
@@ -37,7 +37,7 @@
 import tempfile
 import urlparse
 
-REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v1/'
+REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2/'
 REST_API_ENDPOINT = 'archives/'
 REST_API_MINIFIED_ENDPOINT = 'minified-archives/'
 
@@ -120,7 +120,7 @@
 
 
 def get_sorted_revisions(revisions_dict):
-    revisions = [int(revision['revision']) for revision in revisions_dict['revisions']]
+    revisions = [int(item['revision']['N']) for item in revisions_dict['revisions']['Items']]
     return sorted(revisions)
     
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to