Title: [221801] trunk/Tools
Revision
221801
Author
[email protected]
Date
2017-09-08 16:00:54 -0700 (Fri, 08 Sep 2017)

Log Message

bisect-builds doesn't work due to missing requests module
https://bugs.webkit.org/show_bug.cgi?id=175709
        
Reviewed by Ryosuke Niwa.

* Scripts/bisect-builds: update import to webkitpy.thirdparty.autoinstalled
* Scripts/webkitpy/thirdparty/__init__.py: add logic to install requests module.
(AutoinstallImportHook.find_module):
(AutoinstallImportHook):
(AutoinstallImportHook._install_requests):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_imports):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (221800 => 221801)


--- trunk/Tools/ChangeLog	2017-09-08 22:09:17 UTC (rev 221800)
+++ trunk/Tools/ChangeLog	2017-09-08 23:00:54 UTC (rev 221801)
@@ -1,5 +1,20 @@
 2017-09-08  Lucas Forschler  <[email protected]>
 
+        bisect-builds doesn't work due to missing requests module
+        https://bugs.webkit.org/show_bug.cgi?id=175709
+        
+        Reviewed by Ryosuke Niwa.
+
+        * Scripts/bisect-builds: update import to webkitpy.thirdparty.autoinstalled
+        * Scripts/webkitpy/thirdparty/__init__.py: add logic to install requests module.
+        (AutoinstallImportHook.find_module):
+        (AutoinstallImportHook):
+        (AutoinstallImportHook._install_requests):
+        * Scripts/webkitpy/thirdparty/__init___unittest.py:
+        (ThirdpartyTest.test_imports):
+
+2017-09-08  Lucas Forschler  <[email protected]>
+
         Test commit to verify trac sync is working.
 
 2017-09-08  Lucas Forschler  <[email protected]>

Modified: trunk/Tools/Scripts/bisect-builds (221800 => 221801)


--- trunk/Tools/Scripts/bisect-builds	2017-09-08 22:09:17 UTC (rev 221800)
+++ trunk/Tools/Scripts/bisect-builds	2017-09-08 23:00:54 UTC (rev 221801)
@@ -30,12 +30,12 @@
 import bisect
 import math
 import os
-import requests
 import shutil
 import subprocess
 import sys
 import tempfile
 import urlparse
+import webkitpy.thirdparty.autoinstalled.requests as requests
 
 REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2/'
 REST_API_ENDPOINT = 'archives/'

Modified: trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py (221800 => 221801)


--- trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py	2017-09-08 22:09:17 UTC (rev 221800)
+++ trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py	2017-09-08 23:00:54 UTC (rev 221801)
@@ -106,7 +106,13 @@
             self.install_chromedriver()
         elif '.geckodriver' in fullname:
             self.install_geckodriver()
+        elif '.requests' in fullname:
+            self._install_requests()
 
+    def _install_requests(self):
+        self._install("https://pypi.python.org/packages/b0/e1/eab4fc3752e3d240468a8c0b284607899d2fbfb236a56b7377a329aa8d09/requests-2.18.4.tar.gz#md5=081412b2ef79bdc48229891af13f4d82",
+                             "requests-2.18.4/requests")
+
     def _install_mechanize(self):
         self._install("http://pypi.python.org/packages/source/m/mechanize/mechanize-0.2.5.tar.gz",
                              "mechanize-0.2.5/mechanize")

Modified: trunk/Tools/Scripts/webkitpy/thirdparty/__init___unittest.py (221800 => 221801)


--- trunk/Tools/Scripts/webkitpy/thirdparty/__init___unittest.py	2017-09-08 22:09:17 UTC (rev 221800)
+++ trunk/Tools/Scripts/webkitpy/thirdparty/__init___unittest.py	2017-09-08 23:00:54 UTC (rev 221801)
@@ -63,3 +63,4 @@
         import webkitpy.thirdparty.autoinstalled.mechanize
         import webkitpy.thirdparty.autoinstalled.pylint
         import webkitpy.thirdparty.autoinstalled.pep8
+        import webkitpy.thirdparty.autoinstalled.requests
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to