Title: [221815] trunk/Source/WebCore
- Revision
- 221815
- Author
- [email protected]
- Date
- 2017-09-09 05:38:48 -0700 (Sat, 09 Sep 2017)
Log Message
[GStreamer] Missing GRefPtr adoptions in MediaPlayerPrivateGStreamerBase, PlaybackPipeline
https://bugs.webkit.org/show_bug.cgi?id=176646
Reviewed by Carlos Garcia Campos.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::registerWebKitGStreamerElements): Adopt the return value
of gst_element_factory_find(), which is transferred in full.
* platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
(WebCore::PlaybackPipeline::flush): Adopt the return values
of gst_element_get_static_pad() and gst_pad_get_peer(), both being
transferred in full.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (221814 => 221815)
--- trunk/Source/WebCore/ChangeLog 2017-09-09 12:29:23 UTC (rev 221814)
+++ trunk/Source/WebCore/ChangeLog 2017-09-09 12:38:48 UTC (rev 221815)
@@ -1,3 +1,18 @@
+2017-09-09 Zan Dobersek <[email protected]>
+
+ [GStreamer] Missing GRefPtr adoptions in MediaPlayerPrivateGStreamerBase, PlaybackPipeline
+ https://bugs.webkit.org/show_bug.cgi?id=176646
+
+ Reviewed by Carlos Garcia Campos.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+ (WebCore::registerWebKitGStreamerElements): Adopt the return value
+ of gst_element_factory_find(), which is transferred in full.
+ * platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
+ (WebCore::PlaybackPipeline::flush): Adopt the return values
+ of gst_element_get_static_pad() and gst_pad_get_peer(), both being
+ transferred in full.
+
2017-09-09 Frederic Wang <[email protected]>
Use RenderLayerBacking::renderer() when possible
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (221814 => 221815)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2017-09-09 12:29:23 UTC (rev 221814)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2017-09-09 12:38:48 UTC (rev 221815)
@@ -130,7 +130,7 @@
if (!webkitGstCheckVersion(1, 6, 1))
return;
- GRefPtr<GstElementFactory> clearKeyDecryptorFactory = gst_element_factory_find("webkitclearkey");
+ GRefPtr<GstElementFactory> clearKeyDecryptorFactory = adoptGRef(gst_element_factory_find("webkitclearkey"));
if (!clearKeyDecryptorFactory)
gst_element_register(nullptr, "webkitclearkey", GST_RANK_PRIMARY + 100, WEBKIT_TYPE_MEDIA_CK_DECRYPT);
#endif
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp (221814 => 221815)
--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp 2017-09-09 12:29:23 UTC (rev 221814)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp 2017-09-09 12:38:48 UTC (rev 221815)
@@ -460,8 +460,8 @@
gst_segment_do_seek(segment.get(), rate, GST_FORMAT_TIME, GST_SEEK_FLAG_NONE,
GST_SEEK_TYPE_SET, position, GST_SEEK_TYPE_SET, stop, nullptr);
- GRefPtr<GstPad> sinkPad = gst_element_get_static_pad(appsrc, "src");
- GRefPtr<GstPad> srcPad = sinkPad ? gst_pad_get_peer(sinkPad.get()) : nullptr;
+ GRefPtr<GstPad> sinkPad = adoptGRef(gst_element_get_static_pad(appsrc, "src"));
+ GRefPtr<GstPad> srcPad = sinkPad ? adoptGRef(gst_pad_get_peer(sinkPad.get())) : nullptr;
if (srcPad)
gst_pad_add_probe(srcPad.get(), GST_PAD_PROBE_TYPE_EVENT_DOWNSTREAM, segmentFixerProbe, nullptr, nullptr);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
