Title: [221850] trunk/Source/WebCore
- Revision
- 221850
- Author
- [email protected]
- Date
- 2017-09-10 23:53:41 -0700 (Sun, 10 Sep 2017)
Log Message
[GStreamer] Drop libgcrypt initialization in webkit_media_clear_key_decrypt_init()
https://bugs.webkit.org/show_bug.cgi?id=176656
Reviewed by Michael Catanzaro.
* platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
(webkit_media_clear_key_decrypt_init): Don't re-initialize libgcrypt here
since that's already done in the WebProcess main(), and the calls here
only result in libgcrypt writing out 'Oops' warnings on stderr.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (221849 => 221850)
--- trunk/Source/WebCore/ChangeLog 2017-09-11 06:23:39 UTC (rev 221849)
+++ trunk/Source/WebCore/ChangeLog 2017-09-11 06:53:41 UTC (rev 221850)
@@ -1,3 +1,15 @@
+2017-09-10 Zan Dobersek <[email protected]>
+
+ [GStreamer] Drop libgcrypt initialization in webkit_media_clear_key_decrypt_init()
+ https://bugs.webkit.org/show_bug.cgi?id=176656
+
+ Reviewed by Michael Catanzaro.
+
+ * platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
+ (webkit_media_clear_key_decrypt_init): Don't re-initialize libgcrypt here
+ since that's already done in the WebProcess main(), and the calls here
+ only result in libgcrypt writing out 'Oops' warnings on stderr.
+
2017-09-10 Mark Lam <[email protected]>
Fix all ExceptionScope verification failures in _javascript_Core.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp (221849 => 221850)
--- trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp 2017-09-11 06:23:39 UTC (rev 221849)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp 2017-09-11 06:53:41 UTC (rev 221850)
@@ -98,15 +98,6 @@
{
WebKitMediaClearKeyDecryptPrivate* priv = WEBKIT_MEDIA_CK_DECRYPT_GET_PRIVATE(self);
- if (!gcry_check_version(GCRYPT_VERSION))
- GST_ERROR_OBJECT(self, "Libgcrypt failed to initialize");
-
- // Allocate a pool of 16k secure memory. This make the secure memory
- // available and also drops privileges where needed.
- gcry_control(GCRYCTL_INIT_SECMEM, 16384, 0);
-
- gcry_control(GCRYCTL_INITIALIZATION_FINISHED, 0);
-
self->priv = priv;
new (priv) WebKitMediaClearKeyDecryptPrivate();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
