Title: [221890] trunk/Tools
- Revision
- 221890
- Author
- [email protected]
- Date
- 2017-09-11 16:09:09 -0700 (Mon, 11 Sep 2017)
Log Message
bisect-builds doesn't work due to missing requests module
https://bugs.webkit.org/show_bug.cgi?id=175709
Reviewed by Ryosuke Niwa.
* Scripts/bisect-builds: use urllib2 instead of the requests module.
(get_s3_location_for_revision):
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (221889 => 221890)
--- trunk/Tools/ChangeLog 2017-09-11 23:06:25 UTC (rev 221889)
+++ trunk/Tools/ChangeLog 2017-09-11 23:09:09 UTC (rev 221890)
@@ -1,3 +1,14 @@
+2017-09-11 Lucas Forschler <[email protected]>
+
+ bisect-builds doesn't work due to missing requests module
+ https://bugs.webkit.org/show_bug.cgi?id=175709
+
+ Reviewed by Ryosuke Niwa.
+
+ * Scripts/bisect-builds: use urllib2 instead of the requests module.
+ (get_s3_location_for_revision):
+ (main):
+
2017-09-11 Filip Pizlo <[email protected]>
WSL Substitution should probably wrap type variables of substituted types rather than just wrapping the whole type
Modified: trunk/Tools/Scripts/bisect-builds (221889 => 221890)
--- trunk/Tools/Scripts/bisect-builds 2017-09-11 23:06:25 UTC (rev 221889)
+++ trunk/Tools/Scripts/bisect-builds 2017-09-11 23:09:09 UTC (rev 221890)
@@ -28,13 +28,14 @@
import argparse
import bisect
+import json
import math
import os
-import requests
import shutil
import subprocess
import sys
import tempfile
+import urllib2
import urlparse
REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2/'
@@ -125,8 +126,10 @@
def get_s3_location_for_revision(url, revision):
url = ''.join([url, str(revision)])
- r = requests.get(url)
- for archive in r.json()['archive']:
+ r = urllib2.urlopen(url)
+ data = ""
+
+ for archive in data['archive']:
s3_url = archive['s3_url']
return s3_url
@@ -216,9 +219,11 @@
validate_options(options)
url = ""
- r = requests.get(url)
- revision_list = get_sorted_revisions(r.json())
+ r = urllib2.urlopen(url)
+ data = ""
+ revision_list = get_sorted_revisions(data)
+
start_index, end_index = get_indices_from_revisions(revision_list, options.start, options.end)
print('Bisecting between {} and {}'.format(revision_list[start_index], revision_list[end_index]))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
