Title: [221892] trunk/Tools
- Revision
- 221892
- Author
- [email protected]
- Date
- 2017-09-11 16:28:25 -0700 (Mon, 11 Sep 2017)
Log Message
webkitbot should recognize commands even when colon is omitted
https://bugs.webkit.org/show_bug.cgi?id=176680
<rdar://problem/29933898>
Reviewed by Daniel Bates.
Recognize the IRC command even when : and , were not present.
Unfortunately, there is no unit test for this code at the moment.
* Scripts/webkitpy/common/net/irc/ircbot.py:
(IRCBot.on_pubmsg):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (221891 => 221892)
--- trunk/Tools/ChangeLog 2017-09-11 23:16:06 UTC (rev 221891)
+++ trunk/Tools/ChangeLog 2017-09-11 23:28:25 UTC (rev 221892)
@@ -1,3 +1,17 @@
+2017-09-11 Ryosuke Niwa <[email protected]>
+
+ webkitbot should recognize commands even when colon is omitted
+ https://bugs.webkit.org/show_bug.cgi?id=176680
+ <rdar://problem/29933898>
+
+ Reviewed by Daniel Bates.
+
+ Recognize the IRC command even when : and , were not present.
+ Unfortunately, there is no unit test for this code at the moment.
+
+ * Scripts/webkitpy/common/net/irc/ircbot.py:
+ (IRCBot.on_pubmsg):
+
2017-09-11 Lucas Forschler <[email protected]>
bisect-builds doesn't work due to missing requests module
Modified: trunk/Tools/Scripts/webkitpy/common/net/irc/ircbot.py (221891 => 221892)
--- trunk/Tools/Scripts/webkitpy/common/net/irc/ircbot.py 2017-09-11 23:16:06 UTC (rev 221891)
+++ trunk/Tools/Scripts/webkitpy/common/net/irc/ircbot.py 2017-09-11 23:28:25 UTC (rev 221892)
@@ -84,10 +84,8 @@
# Some IRC clients, like xchat-gnome, default to using a comma
# when addressing someone.
vocative_separator = request[len(connection.get_nickname())]
- if vocative_separator == ':':
- request = request.split(':', 1)
- elif vocative_separator == ',':
- request = request.split(',', 1)
+ if vocative_separator in [':', ',', ' ']:
+ request = request.split(vocative_separator, 1)
else:
return
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
