Title: [221925] trunk/Tools
Revision
221925
Author
[email protected]
Date
2017-09-12 09:59:24 -0700 (Tue, 12 Sep 2017)

Log Message

[WPE][GTK] Run tests with G_DEBUG=fatal-criticals
https://bugs.webkit.org/show_bug.cgi?id=176755

Reviewed by Carlos Garcia Campos.

* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
* Scripts/webkitpy/port/wpe.py:
(WPEPort.setup_environ_for_server):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (221924 => 221925)


--- trunk/Tools/ChangeLog	2017-09-12 16:53:48 UTC (rev 221924)
+++ trunk/Tools/ChangeLog	2017-09-12 16:59:24 UTC (rev 221925)
@@ -1,3 +1,15 @@
+2017-09-12  Michael Catanzaro  <[email protected]>
+
+        [WPE][GTK] Run tests with G_DEBUG=fatal-criticals
+        https://bugs.webkit.org/show_bug.cgi?id=176755
+
+        Reviewed by Carlos Garcia Campos.
+
+        * Scripts/webkitpy/port/gtk.py:
+        (GtkPort.setup_environ_for_server):
+        * Scripts/webkitpy/port/wpe.py:
+        (WPEPort.setup_environ_for_server):
+
 2017-09-12  Alex Christensen  <[email protected]>
 
         Fix build after r221922.

Modified: trunk/Tools/Scripts/webkitpy/port/gtk.py (221924 => 221925)


--- trunk/Tools/Scripts/webkitpy/port/gtk.py	2017-09-12 16:53:48 UTC (rev 221924)
+++ trunk/Tools/Scripts/webkitpy/port/gtk.py	2017-09-12 16:59:24 UTC (rev 221925)
@@ -116,6 +116,7 @@
 
     def setup_environ_for_server(self, server_name=None):
         environment = super(GtkPort, self).setup_environ_for_server(server_name)
+        environment['G_DEBUG'] = 'fatal-criticals'
         environment['GSETTINGS_BACKEND'] = 'memory'
         environment['LIBOVERLAY_SCROLLBAR'] = '0'
         environment['TEST_RUNNER_INJECTED_BUNDLE_FILENAME'] = self._build_path('lib', 'libTestRunnerInjectedBundle.so')
@@ -138,9 +139,9 @@
             else:
                     _log.warning("Can't find Gallium llvmpipe driver. Try to run update-webkitgtk-libs")
         if self.get_option("leaks"):
-            #  Turn off GLib memory optimisations https://wiki.gnome.org/Valgrind.
+            # Turn off GLib memory optimisations https://wiki.gnome.org/Valgrind.
             environment['G_SLICE'] = 'always-malloc'
-            environment['G_DEBUG'] = 'gc-friendly'
+            environment['G_DEBUG'] += ',gc-friendly'
             xmlfilename = "".join(("drt-%p-", uuid.uuid1().hex, "-leaks.xml"))
             xmlfile = os.path.join(self.results_directory(), xmlfilename)
             suppressionsfile = self.path_from_webkit_base('Tools', 'Scripts', 'valgrind', 'suppressions.txt')

Modified: trunk/Tools/Scripts/webkitpy/port/wpe.py (221924 => 221925)


--- trunk/Tools/Scripts/webkitpy/port/wpe.py	2017-09-12 16:53:48 UTC (rev 221924)
+++ trunk/Tools/Scripts/webkitpy/port/wpe.py	2017-09-12 16:59:24 UTC (rev 221925)
@@ -63,6 +63,7 @@
 
     def setup_environ_for_server(self, server_name=None):
         environment = super(WPEPort, self).setup_environ_for_server(server_name)
+        environment['G_DEBUG'] = 'fatal-criticals'
         environment['GSETTINGS_BACKEND'] = 'memory'
         environment['TEST_RUNNER_INJECTED_BUNDLE_FILENAME'] = self._build_path('lib', 'libTestRunnerInjectedBundle.so')
         environment['TEST_RUNNER_TEST_PLUGIN_PATH'] = self._build_path('lib', 'plugins')
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to