- Revision
- 221935
- Author
- [email protected]
- Date
- 2017-09-12 12:46:41 -0700 (Tue, 12 Sep 2017)
Log Message
REGRESSION: 3 stress/op_mod (and op_div) tests timing out on Debug JSC bots.
https://bugs.webkit.org/show_bug.cgi?id=176630
Reviewed by JF Bastien.
Debug builds are just slow, and these tests do a lot. They pass when I run them
locally on my MacBook Pro. So, I'm bumping their timing multiplier to 2.0x as
a speculative fix for the bots that are seeing these fail.
I also undid the skipping of the op_mod tests for debug builds.
* stress/op_div-ConstVar.js:
* stress/op_div-VarConst.js:
* stress/op_div-VarVar.js:
* stress/op_mod-ConstVar.js:
* stress/op_mod-VarConst.js:
* stress/op_mod-VarVar.js:
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (221934 => 221935)
--- trunk/JSTests/ChangeLog 2017-09-12 19:39:56 UTC (rev 221934)
+++ trunk/JSTests/ChangeLog 2017-09-12 19:46:41 UTC (rev 221935)
@@ -1,3 +1,23 @@
+2017-09-12 Mark Lam <[email protected]>
+
+ REGRESSION: 3 stress/op_mod (and op_div) tests timing out on Debug JSC bots.
+ https://bugs.webkit.org/show_bug.cgi?id=176630
+
+ Reviewed by JF Bastien.
+
+ Debug builds are just slow, and these tests do a lot. They pass when I run them
+ locally on my MacBook Pro. So, I'm bumping their timing multiplier to 2.0x as
+ a speculative fix for the bots that are seeing these fail.
+
+ I also undid the skipping of the op_mod tests for debug builds.
+
+ * stress/op_div-ConstVar.js:
+ * stress/op_div-VarConst.js:
+ * stress/op_div-VarVar.js:
+ * stress/op_mod-ConstVar.js:
+ * stress/op_mod-VarConst.js:
+ * stress/op_mod-VarVar.js:
+
2017-09-12 Ryan Haddad <[email protected]>
Skip stress/value-to-boolean.js on Debug bots.
Modified: trunk/JSTests/stress/op_div-ConstVar.js (221934 => 221935)
--- trunk/JSTests/stress/op_div-ConstVar.js 2017-09-12 19:39:56 UTC (rev 221934)
+++ trunk/JSTests/stress/op_div-ConstVar.js 2017-09-12 19:46:41 UTC (rev 221935)
@@ -1,4 +1,4 @@
-//@ runFTLNoCJIT("--timeoutMultiplier=1.5")
+//@ runFTLNoCJIT("--timeoutMultiplier=2.0")
// If all goes well, this test module will terminate silently. If not, it will print
// errors. See binary-op-test.js for debugging options if needed.
Modified: trunk/JSTests/stress/op_div-VarConst.js (221934 => 221935)
--- trunk/JSTests/stress/op_div-VarConst.js 2017-09-12 19:39:56 UTC (rev 221934)
+++ trunk/JSTests/stress/op_div-VarConst.js 2017-09-12 19:46:41 UTC (rev 221935)
@@ -1,4 +1,4 @@
-//@ runFTLNoCJIT("--timeoutMultiplier=1.5")
+//@ runFTLNoCJIT("--timeoutMultiplier=2.0")
// If all goes well, this test module will terminate silently. If not, it will print
// errors. See binary-op-test.js for debugging options if needed.
Modified: trunk/JSTests/stress/op_div-VarVar.js (221934 => 221935)
--- trunk/JSTests/stress/op_div-VarVar.js 2017-09-12 19:39:56 UTC (rev 221934)
+++ trunk/JSTests/stress/op_div-VarVar.js 2017-09-12 19:46:41 UTC (rev 221935)
@@ -1,4 +1,4 @@
-//@ runFTLNoCJIT("--timeoutMultiplier=1.5")
+//@ runFTLNoCJIT("--timeoutMultiplier=2.0")
// If all goes well, this test module will terminate silently. If not, it will print
// errors. See binary-op-test.js for debugging options if needed.
Modified: trunk/JSTests/stress/op_mod-ConstVar.js (221934 => 221935)
--- trunk/JSTests/stress/op_mod-ConstVar.js 2017-09-12 19:39:56 UTC (rev 221934)
+++ trunk/JSTests/stress/op_mod-ConstVar.js 2017-09-12 19:46:41 UTC (rev 221935)
@@ -1,4 +1,4 @@
-//@ if $buildType == "release" then runFTLNoCJIT("--timeoutMultiplier=1.5") else skip end
+//@ runFTLNoCJIT("--timeoutMultiplier=2.0")
// If all goes well, this test module will terminate silently. If not, it will print
// errors. See binary-op-test.js for debugging options if needed.
Modified: trunk/JSTests/stress/op_mod-VarConst.js (221934 => 221935)
--- trunk/JSTests/stress/op_mod-VarConst.js 2017-09-12 19:39:56 UTC (rev 221934)
+++ trunk/JSTests/stress/op_mod-VarConst.js 2017-09-12 19:46:41 UTC (rev 221935)
@@ -1,4 +1,4 @@
-//@ if $buildType == "release" then runFTLNoCJIT("--timeoutMultiplier=1.5") else skip end
+//@ runFTLNoCJIT("--timeoutMultiplier=2.0")
// If all goes well, this test module will terminate silently. If not, it will print
// errors. See binary-op-test.js for debugging options if needed.
Modified: trunk/JSTests/stress/op_mod-VarVar.js (221934 => 221935)
--- trunk/JSTests/stress/op_mod-VarVar.js 2017-09-12 19:39:56 UTC (rev 221934)
+++ trunk/JSTests/stress/op_mod-VarVar.js 2017-09-12 19:46:41 UTC (rev 221935)
@@ -1,4 +1,4 @@
-//@ if $buildType == "release" then runFTLNoCJIT("--timeoutMultiplier=1.5") else skip end
+//@ runFTLNoCJIT("--timeoutMultiplier=2.0")
// If all goes well, this test module will terminate silently. If not, it will print
// errors. See binary-op-test.js for debugging options if needed.
