Title: [221951] trunk/Source
- Revision
- 221951
- Author
- [email protected]
- Date
- 2017-09-12 17:31:19 -0700 (Tue, 12 Sep 2017)
Log Message
QualifiedName::init should assume AtomicStrings::init was already called
https://bugs.webkit.org/show_bug.cgi?id=176639
Patch by Joseph Pecoraro <[email protected]> on 2017-09-12
Reviewed by Sam Weinig.
Source/WebCore:
* dom/QualifiedName.cpp:
(WebCore::QualifiedName::init):
All callers of QualifiedName::init precede it with their own call to
AtomicString::init, so QualifiedName doesn't need to do it.
Source/WTF:
* wtf/NeverDestroyed.h:
(WTF::LazyNeverDestroyed::isConstructed const):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (221950 => 221951)
--- trunk/Source/WTF/ChangeLog 2017-09-13 00:27:46 UTC (rev 221950)
+++ trunk/Source/WTF/ChangeLog 2017-09-13 00:31:19 UTC (rev 221951)
@@ -1,3 +1,13 @@
+2017-09-12 Joseph Pecoraro <[email protected]>
+
+ QualifiedName::init should assume AtomicStrings::init was already called
+ https://bugs.webkit.org/show_bug.cgi?id=176639
+
+ Reviewed by Sam Weinig.
+
+ * wtf/NeverDestroyed.h:
+ (WTF::LazyNeverDestroyed::isConstructed const):
+
2017-09-12 Brent Fulgham <[email protected]>
Show punycode to user if a URL mixes Armenian Seh or Vo with other scripts
Modified: trunk/Source/WTF/wtf/NeverDestroyed.h (221950 => 221951)
--- trunk/Source/WTF/wtf/NeverDestroyed.h 2017-09-13 00:27:46 UTC (rev 221950)
+++ trunk/Source/WTF/wtf/NeverDestroyed.h 2017-09-13 00:31:19 UTC (rev 221951)
@@ -111,6 +111,10 @@
const T* operator->() const { return storagePointer(); }
+#if !ASSERT_DISABLED
+ bool isConstructed() const { return m_isConstructed; }
+#endif
+
private:
using PointerType = typename std::remove_const<T>::type*;
Modified: trunk/Source/WebCore/ChangeLog (221950 => 221951)
--- trunk/Source/WebCore/ChangeLog 2017-09-13 00:27:46 UTC (rev 221950)
+++ trunk/Source/WebCore/ChangeLog 2017-09-13 00:31:19 UTC (rev 221951)
@@ -1,3 +1,15 @@
+2017-09-12 Joseph Pecoraro <[email protected]>
+
+ QualifiedName::init should assume AtomicStrings::init was already called
+ https://bugs.webkit.org/show_bug.cgi?id=176639
+
+ Reviewed by Sam Weinig.
+
+ * dom/QualifiedName.cpp:
+ (WebCore::QualifiedName::init):
+ All callers of QualifiedName::init precede it with their own call to
+ AtomicString::init, so QualifiedName doesn't need to do it.
+
2017-09-12 Myles C. Maxfield <[email protected]>
Unskip fast/text/system-font-synthetic-italic.html
Modified: trunk/Source/WebCore/dom/QualifiedName.cpp (221950 => 221951)
--- trunk/Source/WebCore/dom/QualifiedName.cpp 2017-09-13 00:27:46 UTC (rev 221950)
+++ trunk/Source/WebCore/dom/QualifiedName.cpp 2017-09-13 00:31:19 UTC (rev 221951)
@@ -45,7 +45,7 @@
if (initialized)
return;
- AtomicString::init();
+ ASSERT_WITH_MESSAGE(WTF::nullAtomData.isConstructed(), "AtomicString::init should have been called");
anyName.construct(nullAtom(), starAtom(), starAtom());
initialized = true;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
