Log Message
Remove CanvasRenderingContext2D.commit(), it is a no-op and not part the standard https://bugs.webkit.org/show_bug.cgi?id=176821
Reviewed by Darin Adler.
Source/WebCore:
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/CanvasRenderingContext2D.idl:
Remove the commit operation. It is no longer part the standard (it was
moved to OffscreenCanvasRenderingContext2D) and it was a no-op.
LayoutTests:
* fast/canvas/commit-expected.txt: Removed.
* fast/canvas/commit.html: Removed.
* inspector/canvas/recording-2d-expected.txt:
* inspector/canvas/recording-2d.html:
Remove CanvasRenderingContext2D.commit() from test and update result.
Modified Paths
- trunk/LayoutTests/ChangeLog
- trunk/LayoutTests/inspector/canvas/recording-2d-expected.txt
- trunk/LayoutTests/inspector/canvas/recording-2d.html
- trunk/Source/WebCore/ChangeLog
- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h
- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (221968 => 221969)
--- trunk/LayoutTests/ChangeLog 2017-09-13 15:02:40 UTC (rev 221968)
+++ trunk/LayoutTests/ChangeLog 2017-09-13 15:31:16 UTC (rev 221969)
@@ -1,3 +1,17 @@
+2017-09-13 Sam Weinig <[email protected]>
+
+ Remove CanvasRenderingContext2D.commit(), it is a no-op and not part the standard
+ https://bugs.webkit.org/show_bug.cgi?id=176821
+
+ Reviewed by Darin Adler.
+
+ * fast/canvas/commit-expected.txt: Removed.
+ * fast/canvas/commit.html: Removed.
+ * inspector/canvas/recording-2d-expected.txt:
+ * inspector/canvas/recording-2d.html:
+
+ Remove CanvasRenderingContext2D.commit() from test and update result.
+
2017-09-13 Ms2ger <[email protected]>
Disallow passing null values to various WebGL2 methods.
Deleted: trunk/LayoutTests/fast/canvas/commit-expected.txt (221968 => 221969)
--- trunk/LayoutTests/fast/canvas/commit-expected.txt 2017-09-13 15:02:40 UTC (rev 221968)
+++ trunk/LayoutTests/fast/canvas/commit-expected.txt 2017-09-13 15:31:16 UTC (rev 221969)
@@ -1,3 +0,0 @@
-PASS
-
-
Deleted: trunk/LayoutTests/fast/canvas/commit.html (221968 => 221969)
--- trunk/LayoutTests/fast/canvas/commit.html 2017-09-13 15:02:40 UTC (rev 221968)
+++ trunk/LayoutTests/fast/canvas/commit.html 2017-09-13 15:31:16 UTC (rev 221969)
@@ -1,18 +0,0 @@
-<script>
-if (window.testRunner)
- testRunner.dumpAsText();
-
-window.addEventListener("load", function () {
- var output = document.querySelector("p");
- var canvas = document.querySelector("canvas");
- var context = canvas.getContext("2d");
-
- if ("commit" in context)
- output.textContent = "PASS";
- else
- output.textContent = "FAIL";
-}, false);
-
-</script>
-<p></p>
-<canvas></canvas>
Modified: trunk/LayoutTests/inspector/canvas/recording-2d-expected.txt (221968 => 221969)
--- trunk/LayoutTests/inspector/canvas/recording-2d-expected.txt 2017-09-13 15:02:40 UTC (rev 221968)
+++ trunk/LayoutTests/inspector/canvas/recording-2d-expected.txt 2017-09-13 15:31:16 UTC (rev 221969)
@@ -149,7 +149,7 @@
[
17,
12,
- 393,
+ 390,
24
],
"performActions",
@@ -156,7 +156,7 @@
[
19,
12,
- 397,
+ 394,
25
],
"global code",
@@ -492,34 +492,21 @@
"actions": [
[
54,
- [],
- [],
[
- 55,
- 18
- ]
- ]
- ]
- },
- {
- "actions": [
- [
- 56,
- [
- 57
+ 55
],
[
7
],
[
- 58,
+ 56,
15,
- 59,
+ 57,
18
]
],
[
- 56,
+ 54,
[
2,
3
@@ -529,9 +516,9 @@
1
],
[
- 60,
+ 58,
15,
- 61,
+ 59,
18
]
]
@@ -540,7 +527,7 @@
{
"actions": [
[
- 62,
+ 60,
[
1,
2,
@@ -554,9 +541,9 @@
1
],
[
- 63,
+ 61,
15,
- 64,
+ 62,
18
]
]
@@ -565,10 +552,10 @@
{
"actions": [
[
- 65,
+ 63,
[
- 66,
- 67
+ 64,
+ 65
],
[
6,
@@ -575,17 +562,17 @@
3
],
[
- 68,
+ 66,
15,
- 69,
+ 67,
18
]
],
[
- 65,
+ 63,
[
- 70,
- 71
+ 68,
+ 69
],
[
6,
@@ -592,17 +579,17 @@
3
],
[
- 72,
+ 70,
15,
- 73,
+ 71,
18
]
],
[
- 65,
+ 63,
[
- 74,
- 75
+ 72,
+ 73
],
[
6,
@@ -609,9 +596,9 @@
3
],
[
- 76,
+ 74,
15,
- 77,
+ 75,
18
]
]
@@ -620,7 +607,7 @@
{
"actions": [
[
- 78,
+ 76,
[
1,
2,
@@ -638,9 +625,9 @@
1
],
[
- 79,
+ 77,
15,
- 80,
+ 78,
18
]
]
@@ -649,11 +636,11 @@
{
"actions": [
[
- 81,
+ 79,
[],
[],
[
- 82,
+ 80,
18
]
]
@@ -662,7 +649,7 @@
{
"actions": [
[
- 83,
+ 81,
[
0
],
@@ -670,12 +657,12 @@
0
],
[
- 84,
+ 82,
18
]
],
[
- 83,
+ 81,
[
48,
0
@@ -685,7 +672,7 @@
0
],
[
- 85,
+ 83,
18
]
]
@@ -694,9 +681,9 @@
{
"actions": [
[
- 86,
+ 84,
[
- 66,
+ 64,
1,
2
],
@@ -706,16 +693,16 @@
1
],
[
- 87,
+ 85,
15,
- 88,
+ 86,
18
]
],
[
- 86,
+ 84,
[
- 70,
+ 68,
3,
4
],
@@ -725,16 +712,16 @@
1
],
[
- 89,
+ 87,
15,
- 90,
+ 88,
18
]
],
[
- 86,
+ 84,
[
- 74,
+ 72,
5,
6
],
@@ -744,16 +731,16 @@
1
],
[
- 91,
+ 89,
15,
- 92,
+ 90,
18
]
],
[
- 86,
+ 84,
[
- 66,
+ 64,
7,
8,
9,
@@ -767,16 +754,16 @@
1
],
[
- 93,
+ 91,
15,
- 94,
+ 92,
18
]
],
[
- 86,
+ 84,
[
- 70,
+ 68,
11,
12,
13,
@@ -790,16 +777,16 @@
1
],
[
- 95,
+ 93,
15,
- 96,
+ 94,
18
]
],
[
- 86,
+ 84,
[
- 74,
+ 72,
15,
16,
17,
@@ -813,16 +800,16 @@
1
],
[
- 97,
+ 95,
15,
- 98,
+ 96,
18
]
],
[
- 86,
+ 84,
[
- 66,
+ 64,
19,
20,
21,
@@ -844,16 +831,16 @@
1
],
[
- 99,
+ 97,
15,
- 100,
+ 98,
18
]
],
[
- 86,
+ 84,
[
- 70,
+ 68,
27,
28,
29,
@@ -875,16 +862,16 @@
1
],
[
- 101,
+ 99,
15,
- 102,
+ 100,
18
]
],
[
- 86,
+ 84,
[
- 74,
+ 72,
35,
36,
37,
@@ -906,9 +893,9 @@
1
],
[
- 103,
+ 101,
15,
- 104,
+ 102,
18
]
]
@@ -917,9 +904,9 @@
{
"actions": [
[
- 105,
+ 103,
[
- 66,
+ 64,
1,
2,
3,
@@ -943,14 +930,14 @@
3
],
[
- 106,
+ 104,
18
]
],
[
- 105,
+ 103,
[
- 66,
+ 64,
9,
10,
11,
@@ -959,7 +946,7 @@
14,
15,
16,
- 107
+ 105
],
[
6,
@@ -974,7 +961,7 @@
3
],
[
- 108,
+ 106,
18
]
]
@@ -983,7 +970,7 @@
{
"actions": [
[
- 109,
+ 107,
[
1,
2,
@@ -1005,14 +992,14 @@
2
],
[
- 110,
+ 108,
15,
- 111,
+ 109,
18
]
],
[
- 109,
+ 107,
[
8,
9,
@@ -1034,9 +1021,9 @@
2
],
[
- 112,
+ 110,
15,
- 113,
+ 111,
18
]
]
@@ -1045,7 +1032,7 @@
{
"actions": [
[
- 114,
+ 112,
[
44
],
@@ -1053,12 +1040,12 @@
3
],
[
- 115,
+ 113,
18
]
],
[
- 114,
+ 112,
[
46
],
@@ -1066,12 +1053,12 @@
3
],
[
- 116,
+ 114,
18
]
],
[
- 114,
+ 112,
[
48,
44
@@ -1081,12 +1068,12 @@
3
],
[
- 117,
+ 115,
18
]
],
[
- 114,
+ 112,
[
50,
46
@@ -1096,7 +1083,7 @@
3
],
[
- 118,
+ 116,
18
]
]
@@ -1105,7 +1092,7 @@
{
"actions": [
[
- 119,
+ 117,
[
1,
2,
@@ -1119,7 +1106,7 @@
1
],
[
- 120,
+ 118,
18
]
]
@@ -1128,63 +1115,63 @@
{
"actions": [
[
- 121,
+ 119,
[],
[],
[
- 122,
+ 120,
18
]
],
[
- 121,
+ 119,
[
- 107
+ 105
],
[
3
],
[
- 123,
+ 121,
18
]
],
[
- 121,
+ 119,
[
- 125
+ 123
],
[
10
],
[
- 126,
+ 124,
18
]
],
[
- 121,
+ 119,
[
- 128
+ 126
],
[
10
],
[
- 129,
+ 127,
18
]
],
[
- 121,
+ 119,
[
- 133
+ 131
],
[
11
],
[
- 134,
+ 132,
18
]
]
@@ -1193,9 +1180,9 @@
{
"actions": [
[
- 135,
+ 133,
[
- 67,
+ 65,
1,
2
],
@@ -1205,14 +1192,14 @@
1
],
[
- 136,
+ 134,
18
]
],
[
- 135,
+ 133,
[
- 71,
+ 69,
3,
4,
5
@@ -1224,7 +1211,7 @@
1
],
[
- 137,
+ 135,
18
]
]
@@ -1233,24 +1220,24 @@
{
"actions": [
[
- 138,
+ 136,
[],
[],
[
- 139,
+ 137,
18
]
],
[
- 138,
+ 136,
[
- 107
+ 105
],
[
3
],
[
- 140,
+ 138,
18
]
]
@@ -1259,7 +1246,7 @@
{
"actions": [
[
- 141,
+ 139,
[
1,
2,
@@ -1273,9 +1260,9 @@
1
],
[
- 142,
+ 140,
15,
- 143,
+ 141,
18
]
]
@@ -1284,11 +1271,11 @@
{
"actions": [
[
- 144,
+ 142,
[],
[],
[
- 145,
+ 143,
18
]
]
@@ -1297,11 +1284,11 @@
{
"actions": [
[
- 146,
+ 144,
[],
[],
[
- 147,
+ 145,
18
]
]
@@ -1310,16 +1297,16 @@
{
"actions": [
[
- 148,
+ 146,
[],
[],
[
- 149,
+ 147,
18
]
],
[
- 148,
+ 146,
[
0
],
@@ -1327,7 +1314,7 @@
1
],
[
- 150,
+ 148,
18
]
]
@@ -1336,24 +1323,24 @@
{
"actions": [
[
- 151,
+ 149,
[],
[],
[
- 152,
+ 150,
18
]
],
[
- 151,
+ 149,
[
- 107
+ 105
],
[
3
],
[
- 153,
+ 151,
18
]
]
@@ -1362,16 +1349,16 @@
{
"actions": [
[
- 154,
+ 152,
[],
[],
[
- 155,
+ 153,
18
]
],
[
- 154,
+ 152,
[
1
],
@@ -1379,7 +1366,7 @@
2
],
[
- 156,
+ 154,
18
]
]
@@ -1388,16 +1375,16 @@
{
"actions": [
[
- 157,
+ 155,
[],
[],
[
- 158,
+ 156,
18
]
],
[
- 157,
+ 155,
[
9
],
@@ -1405,7 +1392,7 @@
3
],
[
- 159,
+ 157,
18
]
]
@@ -1414,7 +1401,7 @@
{
"actions": [
[
- 160,
+ 158,
[
48,
5,
@@ -1428,12 +1415,12 @@
3
],
[
- 161,
+ 159,
18
]
],
[
- 160,
+ 158,
[
50,
7,
@@ -1447,12 +1434,12 @@
3
],
[
- 162,
+ 160,
18
]
],
[
- 160,
+ 158,
[
9,
10,
@@ -1464,12 +1451,12 @@
3
],
[
- 163,
+ 161,
18
]
],
[
- 160,
+ 158,
[
11,
12,
@@ -1481,7 +1468,7 @@
3
],
[
- 164,
+ 162,
18
]
]
@@ -1490,7 +1477,7 @@
{
"actions": [
[
- 165,
+ 163,
[
48,
3,
@@ -1502,12 +1489,12 @@
1
],
[
- 166,
+ 164,
18
]
],
[
- 165,
+ 163,
[
5,
6
@@ -1517,7 +1504,7 @@
1
],
[
- 167,
+ 165,
18
]
]
@@ -1526,11 +1513,11 @@
{
"actions": [
[
- 168,
+ 166,
[],
[],
[
- 169,
+ 167,
18
]
]
@@ -1539,16 +1526,16 @@
{
"actions": [
[
- 170,
+ 168,
[],
[],
[
- 171,
+ 169,
18
]
],
[
- 170,
+ 168,
[
1
],
@@ -1556,7 +1543,7 @@
1
],
[
- 172,
+ 170,
18
]
]
@@ -1565,11 +1552,11 @@
{
"actions": [
[
- 173,
+ 171,
[],
[],
[
- 174,
+ 172,
18
]
]
@@ -1578,7 +1565,7 @@
{
"actions": [
[
- 175,
+ 173,
[
1,
2
@@ -1588,7 +1575,7 @@
1
],
[
- 176,
+ 174,
18
]
]
@@ -1597,16 +1584,16 @@
{
"actions": [
[
- 177,
+ 175,
[],
[],
[
- 178,
+ 176,
18
]
],
[
- 177,
+ 175,
[
1
],
@@ -1614,7 +1601,7 @@
1
],
[
- 179,
+ 177,
18
]
]
@@ -1623,15 +1610,15 @@
{
"actions": [
[
- 180,
+ 178,
[
- 107
+ 105
],
[
3
],
[
- 181,
+ 179,
18
]
]
@@ -1640,16 +1627,16 @@
{
"actions": [
[
- 182,
+ 180,
[],
[],
[
- 183,
+ 181,
18
]
],
[
- 182,
+ 180,
[
1
],
@@ -1657,7 +1644,7 @@
1
],
[
- 184,
+ 182,
18
]
]
@@ -1666,7 +1653,7 @@
{
"actions": [
[
- 185,
+ 183,
[
1,
2
@@ -1676,7 +1663,7 @@
1
],
[
- 186,
+ 184,
18
]
]
@@ -1685,9 +1672,9 @@
{
"actions": [
[
- 187,
+ 185,
[
- 57,
+ 55,
5,
6
],
@@ -1697,14 +1684,14 @@
1
],
[
- 188,
+ 186,
18
]
],
[
- 187,
+ 185,
[
- 189,
+ 187,
7,
8,
9,
@@ -1722,7 +1709,7 @@
1
],
[
- 190,
+ 188,
18
]
]
@@ -1731,7 +1718,7 @@
{
"actions": [
[
- 191,
+ 189,
[
1,
2,
@@ -1745,7 +1732,7 @@
1
],
[
- 192,
+ 190,
18
]
]
@@ -1754,7 +1741,7 @@
{
"actions": [
[
- 193,
+ 191,
[
1,
2,
@@ -1768,7 +1755,7 @@
1
],
[
- 194,
+ 192,
18
]
]
@@ -1777,11 +1764,11 @@
{
"actions": [
[
- 195,
+ 193,
[],
[],
[
- 196,
+ 194,
18
]
]
@@ -1790,11 +1777,11 @@
{
"actions": [
[
- 197,
+ 195,
[],
[],
[
- 198,
+ 196,
18
]
]
@@ -1803,7 +1790,7 @@
{
"actions": [
[
- 199,
+ 197,
[
1
],
@@ -1811,7 +1798,7 @@
1
],
[
- 200,
+ 198,
18
]
]
@@ -1820,11 +1807,11 @@
{
"actions": [
[
- 201,
+ 199,
[],
[],
[
- 202,
+ 200,
18
]
]
@@ -1833,7 +1820,7 @@
{
"actions": [
[
- 203,
+ 201,
[
1,
2
@@ -1843,7 +1830,7 @@
1
],
[
- 204,
+ 202,
18
]
]
@@ -1852,7 +1839,7 @@
{
"actions": [
[
- 205,
+ 203,
[
null
],
@@ -1860,12 +1847,12 @@
1
],
[
- 206,
+ 204,
18
]
],
[
- 205,
+ 203,
[
1
],
@@ -1873,7 +1860,7 @@
1
],
[
- 207,
+ 205,
18
]
]
@@ -1882,28 +1869,28 @@
{
"actions": [
[
- 208,
+ 206,
[
- 209
+ 207
],
[
3
],
[
- 210,
+ 208,
18
]
],
[
- 208,
+ 206,
[
- 107
+ 105
],
[
3
],
[
- 211,
+ 209,
18
]
]
@@ -1912,22 +1899,22 @@
{
"actions": [
[
- 212,
+ 210,
[
- 67
+ 65
],
[
3
],
[
- 213,
+ 211,
18
]
],
[
- 212,
+ 210,
[
- 71,
+ 69,
1
],
[
@@ -1935,12 +1922,12 @@
1
],
[
- 214,
+ 212,
18
]
],
[
- 212,
+ 210,
[
2,
1
@@ -1950,12 +1937,12 @@
1
],
[
- 215,
+ 213,
18
]
],
[
- 212,
+ 210,
[
3,
4
@@ -1965,12 +1952,12 @@
1
],
[
- 216,
+ 214,
18
]
],
[
- 212,
+ 210,
[
5,
6,
@@ -1984,12 +1971,12 @@
1
],
[
- 217,
+ 215,
18
]
],
[
- 212,
+ 210,
[
9,
10,
@@ -2005,7 +1992,7 @@
1
],
[
- 218,
+ 216,
18
]
]
@@ -2014,28 +2001,28 @@
{
"actions": [
[
- 219,
+ 217,
[
- 209
+ 207
],
[
3
],
[
- 220,
+ 218,
18
]
],
[
- 219,
+ 217,
[
- 107
+ 105
],
[
3
],
[
- 221,
+ 219,
18
]
]
@@ -2044,7 +2031,7 @@
{
"actions": [
[
- 222,
+ 220,
[
[
1,
@@ -2055,7 +2042,7 @@
4
],
[
- 223,
+ 221,
18
]
]
@@ -2064,28 +2051,28 @@
{
"actions": [
[
- 224,
+ 222,
[
- 209
+ 207
],
[
3
],
[
- 225,
+ 223,
18
]
],
[
- 224,
+ 222,
[
- 107
+ 105
],
[
3
],
[
- 226,
+ 224,
18
]
]
@@ -2094,7 +2081,7 @@
{
"actions": [
[
- 227,
+ 225,
[
null
],
@@ -2102,12 +2089,12 @@
1
],
[
- 228,
+ 226,
18
]
],
[
- 227,
+ 225,
[
1
],
@@ -2115,7 +2102,7 @@
1
],
[
- 229,
+ 227,
18
]
]
@@ -2124,7 +2111,7 @@
{
"actions": [
[
- 230,
+ 228,
[
null
],
@@ -2132,12 +2119,12 @@
1
],
[
- 231,
+ 229,
18
]
],
[
- 230,
+ 228,
[
1
],
@@ -2145,7 +2132,7 @@
1
],
[
- 232,
+ 230,
18
]
]
@@ -2154,12 +2141,12 @@
{
"actions": [
[
- 233,
+ 231,
[
1,
2,
3,
- 234
+ 232
],
[
1,
@@ -2168,17 +2155,17 @@
3
],
[
- 235,
+ 233,
18
]
],
[
- 233,
+ 231,
[
4,
5,
6,
- 107,
+ 105,
7
],
[
@@ -2189,12 +2176,12 @@
1
],
[
- 236,
+ 234,
18
]
],
[
- 233,
+ 231,
[
8,
9,
@@ -2210,12 +2197,12 @@
1
],
[
- 237,
+ 235,
18
]
],
[
- 233,
+ 231,
[
12,
13,
@@ -2231,12 +2218,12 @@
1
],
[
- 238,
+ 236,
18
]
],
[
- 233,
+ 231,
[
17,
18,
@@ -2256,12 +2243,12 @@
1
],
[
- 239,
+ 237,
18
]
],
[
- 233,
+ 231,
[
24,
25,
@@ -2283,7 +2270,7 @@
1
],
[
- 240,
+ 238,
18
]
]
@@ -2292,22 +2279,22 @@
{
"actions": [
[
- 241,
+ 239,
[
- 67
+ 65
],
[
3
],
[
- 242,
+ 240,
18
]
],
[
- 241,
+ 239,
[
- 71,
+ 69,
1
],
[
@@ -2315,12 +2302,12 @@
1
],
[
- 243,
+ 241,
18
]
],
[
- 241,
+ 239,
[
2,
1
@@ -2330,12 +2317,12 @@
1
],
[
- 244,
+ 242,
18
]
],
[
- 241,
+ 239,
[
3,
4
@@ -2345,12 +2332,12 @@
1
],
[
- 245,
+ 243,
18
]
],
[
- 241,
+ 239,
[
5,
6,
@@ -2364,12 +2351,12 @@
1
],
[
- 246,
+ 244,
18
]
],
[
- 241,
+ 239,
[
9,
10,
@@ -2385,7 +2372,7 @@
1
],
[
- 247,
+ 245,
18
]
]
@@ -2394,7 +2381,7 @@
{
"actions": [
[
- 248,
+ 246,
[
1,
2,
@@ -2412,12 +2399,12 @@
1
],
[
- 249,
+ 247,
18
]
],
[
- 248,
+ 246,
[
[
1,
@@ -2432,14 +2419,14 @@
8
],
[
- 250,
+ 248,
15,
- 251,
+ 249,
18
]
],
[
- 248,
+ 246,
[
[
7,
@@ -2454,9 +2441,9 @@
8
],
[
- 252,
+ 250,
15,
- 253,
+ 251,
18
]
]
@@ -2465,16 +2452,16 @@
{
"actions": [
[
- 254,
+ 252,
[],
[],
[
- 255,
+ 253,
18
]
],
[
- 254,
+ 252,
[
1
],
@@ -2482,7 +2469,7 @@
1
],
[
- 256,
+ 254,
18
]
]
@@ -2491,24 +2478,24 @@
{
"actions": [
[
- 257,
+ 255,
[],
[],
[
- 258,
+ 256,
18
]
],
[
- 257,
+ 255,
[
- 107
+ 105
],
[
3
],
[
- 259,
+ 257,
18
]
]
@@ -2517,16 +2504,16 @@
{
"actions": [
[
- 260,
+ 258,
[],
[],
[
- 261,
+ 259,
18
]
],
[
- 260,
+ 258,
[
1
],
@@ -2534,7 +2521,7 @@
1
],
[
- 262,
+ 260,
18
]
]
@@ -2543,16 +2530,16 @@
{
"actions": [
[
- 263,
+ 261,
[],
[],
[
- 264,
+ 262,
18
]
],
[
- 263,
+ 261,
[
1
],
@@ -2560,7 +2547,7 @@
1
],
[
- 265,
+ 263,
18
]
]
@@ -2569,16 +2556,16 @@
{
"actions": [
[
- 266,
+ 264,
[],
[],
[
- 267,
+ 265,
18
]
],
[
- 266,
+ 264,
[
48
],
@@ -2586,7 +2573,7 @@
9
],
[
- 268,
+ 266,
18
]
]
@@ -2595,7 +2582,7 @@
{
"actions": [
[
- 269,
+ 267,
[
1,
2,
@@ -2609,7 +2596,7 @@
1
],
[
- 270,
+ 268,
18
]
]
@@ -2618,63 +2605,63 @@
{
"actions": [
[
- 271,
+ 269,
[],
[],
[
- 272,
+ 270,
18
]
],
[
- 271,
+ 269,
[
- 107
+ 105
],
[
3
],
[
- 273,
+ 271,
18
]
],
[
- 271,
+ 269,
[
- 125
+ 123
],
[
10
],
[
- 274,
+ 272,
18
]
],
[
- 271,
+ 269,
[
- 128
+ 126
],
[
10
],
[
- 275,
+ 273,
18
]
],
[
- 271,
+ 269,
[
- 133
+ 131
],
[
11
],
[
- 276,
+ 274,
18
]
]
@@ -2683,9 +2670,9 @@
{
"actions": [
[
- 277,
+ 275,
[
- 67,
+ 65,
1,
2
],
@@ -2695,14 +2682,14 @@
1
],
[
- 278,
+ 276,
18
]
],
[
- 277,
+ 275,
[
- 71,
+ 69,
3,
4,
5
@@ -2714,7 +2701,7 @@
1
],
[
- 279,
+ 277,
18
]
]
@@ -2723,11 +2710,11 @@
{
"actions": [
[
- 280,
+ 278,
[],
[],
[
- 281,
+ 279,
18
]
]
@@ -2736,11 +2723,11 @@
{
"actions": [
[
- 282,
+ 280,
[],
[],
[
- 283,
+ 281,
18
]
]
@@ -2749,7 +2736,7 @@
{
"actions": [
[
- 284,
+ 282,
[
1,
2,
@@ -2767,7 +2754,7 @@
1
],
[
- 285,
+ 283,
18
]
]
@@ -2776,7 +2763,7 @@
{
"actions": [
[
- 286,
+ 284,
[
1,
2
@@ -2786,7 +2773,7 @@
1
],
[
- 287,
+ 285,
18
]
]
@@ -2795,7 +2782,7 @@
{
"actions": [
[
- 288,
+ 286,
[
1,
2,
@@ -2809,9 +2796,9 @@
1
],
[
- 289,
+ 287,
15,
- 290,
+ 288,
18
]
]
@@ -2820,16 +2807,16 @@
{
"actions": [
[
- 291,
+ 289,
[],
[],
[
- 292,
+ 290,
18
]
],
[
- 291,
+ 289,
[
1
],
@@ -2837,7 +2824,7 @@
2
],
[
- 293,
+ 291,
18
]
]
@@ -2846,16 +2833,16 @@
{
"actions": [
[
- 294,
+ 292,
[],
[],
[
- 295,
+ 293,
18
]
],
[
- 294,
+ 292,
[
[
1,
@@ -2866,7 +2853,7 @@
4
],
[
- 296,
+ 294,
18
]
]
@@ -2875,16 +2862,16 @@
{
"actions": [
[
- 297,
+ 295,
[],
[],
[
- 298,
+ 296,
18
]
],
[
- 297,
+ 295,
[
1
],
@@ -2892,7 +2879,7 @@
1
],
[
- 299,
+ 297,
18
]
]
@@ -2901,9 +2888,9 @@
{
"actions": [
[
- 300,
+ 298,
[
- 57,
+ 55,
5,
6
],
@@ -2913,14 +2900,14 @@
1
],
[
- 301,
+ 299,
18
]
],
[
- 300,
+ 298,
[
- 189,
+ 187,
7,
8,
9,
@@ -2938,7 +2925,7 @@
1
],
[
- 302,
+ 300,
18
]
]
@@ -2982,7 +2969,7 @@
[
17,
12,
- 393,
+ 390,
24
],
"performActions",
@@ -2989,7 +2976,7 @@
[
19,
12,
- 397,
+ 394,
25
],
"global code",
@@ -3110,13 +3097,6 @@
102,
26
],
- "commit",
- [
- 10,
- 12,
- 105,
- 23
- ],
"createImageData",
[
[
@@ -3143,25 +3123,25 @@
[
10,
12,
- 108,
+ 105,
54
],
[
10,
12,
- 108,
+ 105,
28
],
[
10,
12,
- 109,
+ 106,
54
],
[
10,
12,
- 109,
+ 106,
28
],
"createLinearGradient",
@@ -3168,13 +3148,13 @@
[
10,
12,
- 112,
+ 109,
59
],
[
10,
12,
- 112,
+ 109,
28
],
"createPattern",
@@ -3183,13 +3163,13 @@
[
10,
12,
- 115,
+ 112,
52
],
[
10,
12,
- 115,
+ 112,
28
],
"data:,",
@@ -3197,13 +3177,13 @@
[
10,
12,
- 116,
+ 113,
52
],
[
10,
12,
- 116,
+ 113,
28
],
"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAIAAAACCAYAAABytg0kAAAAAXNSR0IArs4c6QAAAAtJREFUCB1jYEAHAAASAAGAFMrMAAAAAElFTkSuQmCC",
@@ -3211,13 +3191,13 @@
[
10,
12,
- 117,
+ 114,
52
],
[
10,
12,
- 117,
+ 114,
28
],
"createRadialGradient",
@@ -3224,13 +3204,13 @@
[
10,
12,
- 120,
+ 117,
59
],
[
10,
12,
- 120,
+ 117,
28
],
"direction",
@@ -3237,7 +3217,7 @@
[
10,
12,
- 123,
+ 120,
16
],
"drawFocusIfNeeded",
@@ -3244,13 +3224,13 @@
[
10,
12,
- 127,
+ 124,
34
],
[
10,
12,
- 128,
+ 125,
34
],
"drawImage",
@@ -3257,109 +3237,109 @@
[
10,
12,
- 131,
+ 128,
48
],
[
10,
12,
- 131,
+ 128,
28
],
[
10,
12,
- 132,
+ 129,
48
],
[
10,
12,
- 132,
+ 129,
28
],
[
10,
12,
- 133,
+ 130,
48
],
[
10,
12,
- 133,
+ 130,
28
],
[
10,
12,
- 134,
+ 131,
48
],
[
10,
12,
- 134,
+ 131,
28
],
[
10,
12,
- 135,
+ 132,
48
],
[
10,
12,
- 135,
+ 132,
28
],
[
10,
12,
- 136,
+ 133,
48
],
[
10,
12,
- 136,
+ 133,
28
],
[
10,
12,
- 137,
+ 134,
48
],
[
10,
12,
- 137,
+ 134,
28
],
[
10,
12,
- 138,
+ 135,
48
],
[
10,
12,
- 138,
+ 135,
28
],
[
10,
12,
- 139,
+ 136,
48
],
[
10,
12,
- 139,
+ 136,
28
],
"drawImageFromRect",
@@ -3366,7 +3346,7 @@
[
10,
12,
- 142,
+ 139,
34
],
"test",
@@ -3373,7 +3353,7 @@
[
10,
12,
- 143,
+ 140,
34
],
"ellipse",
@@ -3380,25 +3360,25 @@
[
10,
12,
- 146,
+ 143,
46
],
[
10,
12,
- 146,
+ 143,
28
],
[
10,
12,
- 147,
+ 144,
46
],
[
10,
12,
- 147,
+ 144,
28
],
"fill",
@@ -3405,25 +3385,25 @@
[
10,
12,
- 150,
+ 147,
21
],
[
10,
12,
- 151,
+ 148,
21
],
[
10,
12,
- 152,
+ 149,
21
],
[
10,
12,
- 153,
+ 150,
21
],
"fillRect",
@@ -3430,7 +3410,7 @@
[
10,
12,
- 156,
+ 153,
25
],
"fillStyle",
@@ -3437,18 +3417,18 @@
[
10,
12,
- 159,
+ 156,
16
],
[
10,
12,
- 160,
+ 157,
16
],
"linear-gradient",
[
- 124,
+ 122,
[
1,
2,
@@ -3460,12 +3440,12 @@
[
10,
12,
- 161,
+ 158,
16
],
"radial-gradient",
[
- 127,
+ 125,
[
1,
2,
@@ -3479,7 +3459,7 @@
[
10,
12,
- 162,
+ 159,
16
],
"pattern",
@@ -3486,14 +3466,14 @@
"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAIAAAACCAYAAABytg0kAAAAAXNSR0IArs4c6QAAABNJREFUCB1j/M/AAEQMDEwgAgQAHxcCAmtAm/sAAAAASUVORK5CYII=",
"no-repeat",
[
- 130,
- 131,
- 132
+ 128,
+ 129,
+ 130
],
[
10,
12,
- 163,
+ 160,
16
],
"fillText",
@@ -3500,13 +3480,13 @@
[
10,
12,
- 166,
+ 163,
25
],
[
10,
12,
- 167,
+ 164,
25
],
"font",
@@ -3513,13 +3493,13 @@
[
10,
12,
- 170,
+ 167,
16
],
[
10,
12,
- 171,
+ 168,
16
],
"getImageData",
@@ -3526,13 +3506,13 @@
[
10,
12,
- 174,
+ 171,
51
],
[
10,
12,
- 174,
+ 171,
28
],
"getLineDash",
@@ -3539,7 +3519,7 @@
[
10,
12,
- 177,
+ 174,
28
],
"getTransform",
@@ -3546,7 +3526,7 @@
[
10,
12,
- 180,
+ 177,
29
],
"globalAlpha",
@@ -3553,13 +3533,13 @@
[
10,
12,
- 183,
+ 180,
16
],
[
10,
12,
- 184,
+ 181,
16
],
"globalCompositeOperation",
@@ -3566,13 +3546,13 @@
[
10,
12,
- 187,
+ 184,
16
],
[
10,
12,
- 188,
+ 185,
16
],
"imageSmoothingEnabled",
@@ -3579,13 +3559,13 @@
[
10,
12,
- 191,
+ 188,
16
],
[
10,
12,
- 192,
+ 189,
16
],
"imageSmoothingQuality",
@@ -3592,13 +3572,13 @@
[
10,
12,
- 195,
+ 192,
16
],
[
10,
12,
- 196,
+ 193,
16
],
"isPointInPath",
@@ -3605,25 +3585,25 @@
[
10,
12,
- 199,
+ 196,
30
],
[
10,
12,
- 200,
+ 197,
30
],
[
10,
12,
- 201,
+ 198,
30
],
[
10,
12,
- 202,
+ 199,
30
],
"isPointInStroke",
@@ -3630,13 +3610,13 @@
[
10,
12,
- 205,
+ 202,
32
],
[
10,
12,
- 206,
+ 203,
32
],
"lineCap",
@@ -3643,7 +3623,7 @@
[
10,
12,
- 209,
+ 206,
16
],
"lineDashOffset",
@@ -3650,13 +3630,13 @@
[
10,
12,
- 213,
+ 210,
16
],
[
10,
12,
- 214,
+ 211,
16
],
"lineJoin",
@@ -3663,7 +3643,7 @@
[
10,
12,
- 217,
+ 214,
16
],
"lineTo",
@@ -3670,7 +3650,7 @@
[
10,
12,
- 221,
+ 218,
23
],
"lineWidth",
@@ -3677,13 +3657,13 @@
[
10,
12,
- 224,
+ 221,
16
],
[
10,
12,
- 225,
+ 222,
16
],
"measureText",
@@ -3690,7 +3670,7 @@
[
10,
12,
- 228,
+ 225,
28
],
"miterLimit",
@@ -3697,13 +3677,13 @@
[
10,
12,
- 231,
+ 228,
16
],
[
10,
12,
- 232,
+ 229,
16
],
"moveTo",
@@ -3710,7 +3690,7 @@
[
10,
12,
- 235,
+ 232,
23
],
"putImageData",
@@ -3717,7 +3697,7 @@
[
10,
12,
- 238,
+ 235,
29
],
[
@@ -3753,7 +3733,7 @@
[
10,
12,
- 239,
+ 236,
29
],
"quadraticCurveTo",
@@ -3760,7 +3740,7 @@
[
10,
12,
- 242,
+ 239,
33
],
"rect",
@@ -3767,7 +3747,7 @@
[
10,
12,
- 245,
+ 242,
21
],
"resetTransform",
@@ -3774,7 +3754,7 @@
[
10,
12,
- 248,
+ 245,
31
],
"restore",
@@ -3781,7 +3761,7 @@
[
10,
12,
- 251,
+ 248,
24
],
"rotate",
@@ -3788,7 +3768,7 @@
[
10,
12,
- 256,
+ 253,
23
],
"save",
@@ -3795,7 +3775,7 @@
[
10,
12,
- 259,
+ 256,
21
],
"scale",
@@ -3802,7 +3782,7 @@
[
10,
12,
- 262,
+ 259,
22
],
"setAlpha",
@@ -3809,13 +3789,13 @@
[
10,
12,
- 265,
+ 262,
25
],
[
10,
12,
- 266,
+ 263,
25
],
"setCompositeOperation",
@@ -3823,13 +3803,13 @@
[
10,
12,
- 269,
+ 266,
38
],
[
10,
12,
- 270,
+ 267,
38
],
"setFillColor",
@@ -3836,37 +3816,37 @@
[
10,
12,
- 273,
+ 270,
29
],
[
10,
12,
- 274,
+ 271,
29
],
[
10,
12,
- 275,
+ 272,
29
],
[
10,
12,
- 276,
+ 273,
29
],
[
10,
12,
- 277,
+ 274,
29
],
[
10,
12,
- 278,
+ 275,
29
],
"setLineCap",
@@ -3873,13 +3853,13 @@
[
10,
12,
- 281,
+ 278,
27
],
[
10,
12,
- 282,
+ 279,
27
],
"setLineDash",
@@ -3886,7 +3866,7 @@
[
10,
12,
- 285,
+ 282,
28
],
"setLineJoin",
@@ -3893,13 +3873,13 @@
[
10,
12,
- 288,
+ 285,
28
],
[
10,
12,
- 289,
+ 286,
28
],
"setLineWidth",
@@ -3906,13 +3886,13 @@
[
10,
12,
- 292,
+ 289,
29
],
[
10,
12,
- 293,
+ 290,
29
],
"setMiterLimit",
@@ -3919,13 +3899,13 @@
[
10,
12,
- 296,
+ 293,
30
],
[
10,
12,
- 297,
+ 294,
30
],
"setShadow",
@@ -3933,37 +3913,37 @@
[
10,
12,
- 300,
+ 297,
26
],
[
10,
12,
- 301,
+ 298,
26
],
[
10,
12,
- 302,
+ 299,
26
],
[
10,
12,
- 303,
+ 300,
26
],
[
10,
12,
- 304,
+ 301,
26
],
[
10,
12,
- 305,
+ 302,
26
],
"setStrokeColor",
@@ -3970,37 +3950,37 @@
[
10,
12,
- 308,
+ 305,
31
],
[
10,
12,
- 309,
+ 306,
31
],
[
10,
12,
- 310,
+ 307,
31
],
[
10,
12,
- 311,
+ 308,
31
],
[
10,
12,
- 312,
+ 309,
31
],
[
10,
12,
- 313,
+ 310,
31
],
"setTransform",
@@ -4007,31 +3987,31 @@
[
10,
12,
- 316,
+ 313,
29
],
[
10,
12,
- 317,
+ 314,
51
],
[
10,
12,
- 317,
+ 314,
28
],
[
10,
12,
- 318,
+ 315,
51
],
[
10,
12,
- 318,
+ 315,
28
],
"shadowBlur",
@@ -4038,13 +4018,13 @@
[
10,
12,
- 321,
+ 318,
16
],
[
10,
12,
- 322,
+ 319,
16
],
"shadowColor",
@@ -4051,13 +4031,13 @@
[
10,
12,
- 325,
+ 322,
16
],
[
10,
12,
- 326,
+ 323,
16
],
"shadowOffsetX",
@@ -4064,13 +4044,13 @@
[
10,
12,
- 329,
+ 326,
16
],
[
10,
12,
- 330,
+ 327,
16
],
"shadowOffsetY",
@@ -4077,13 +4057,13 @@
[
10,
12,
- 333,
+ 330,
16
],
[
10,
12,
- 334,
+ 331,
16
],
"stroke",
@@ -4090,13 +4070,13 @@
[
10,
12,
- 337,
+ 334,
23
],
[
10,
12,
- 338,
+ 335,
23
],
"strokeRect",
@@ -4103,7 +4083,7 @@
[
10,
12,
- 341,
+ 338,
27
],
"strokeStyle",
@@ -4110,31 +4090,31 @@
[
10,
12,
- 344,
+ 341,
16
],
[
10,
12,
- 345,
+ 342,
16
],
[
10,
12,
- 346,
+ 343,
16
],
[
10,
12,
- 347,
+ 344,
16
],
[
10,
12,
- 348,
+ 345,
16
],
"strokeText",
@@ -4141,13 +4121,13 @@
[
10,
12,
- 351,
+ 348,
27
],
[
10,
12,
- 352,
+ 349,
27
],
"textAlign",
@@ -4154,7 +4134,7 @@
[
10,
12,
- 355,
+ 352,
16
],
"textBaseline",
@@ -4161,7 +4141,7 @@
[
10,
12,
- 359,
+ 356,
16
],
"transform",
@@ -4168,7 +4148,7 @@
[
10,
12,
- 363,
+ 360,
26
],
"translate",
@@ -4175,7 +4155,7 @@
[
10,
12,
- 366,
+ 363,
26
],
"webkitGetImageDataHD",
@@ -4182,13 +4162,13 @@
[
10,
12,
- 369,
+ 366,
59
],
[
10,
12,
- 369,
+ 366,
28
],
"webkitImageSmoothingEnabled",
@@ -4195,13 +4175,13 @@
[
10,
12,
- 372,
+ 369,
16
],
[
10,
12,
- 373,
+ 370,
16
],
"webkitLineDash",
@@ -4208,13 +4188,13 @@
[
10,
12,
- 376,
+ 373,
16
],
[
10,
12,
- 377,
+ 374,
16
],
"webkitLineDashOffset",
@@ -4221,13 +4201,13 @@
[
10,
12,
- 380,
+ 377,
16
],
[
10,
12,
- 381,
+ 378,
16
],
"webkitPutImageDataHD",
@@ -4234,13 +4214,13 @@
[
10,
12,
- 384,
+ 381,
37
],
[
10,
12,
- 385,
+ 382,
37
]
]
@@ -4364,7 +4344,7 @@
[
17,
12,
- 393,
+ 390,
24
],
"performActions",
@@ -4371,7 +4351,7 @@
[
19,
12,
- 397,
+ 394,
25
],
"global code",
Modified: trunk/LayoutTests/inspector/canvas/recording-2d.html (221968 => 221969)
--- trunk/LayoutTests/inspector/canvas/recording-2d.html 2017-09-13 15:02:40 UTC (rev 221968)
+++ trunk/LayoutTests/inspector/canvas/recording-2d.html 2017-09-13 15:31:16 UTC (rev 221969)
@@ -102,9 +102,6 @@
ctx.closePath();
},
() => {
- ctx.commit();
- },
- () => {
ignoreException(() => ctx.createImageData(imageData14));
ignoreException(() => ctx.createImageData(2, 3));
},
Modified: trunk/Source/WebCore/ChangeLog (221968 => 221969)
--- trunk/Source/WebCore/ChangeLog 2017-09-13 15:02:40 UTC (rev 221968)
+++ trunk/Source/WebCore/ChangeLog 2017-09-13 15:31:16 UTC (rev 221969)
@@ -1,3 +1,16 @@
+2017-09-13 Sam Weinig <[email protected]>
+
+ Remove CanvasRenderingContext2D.commit(), it is a no-op and not part the standard
+ https://bugs.webkit.org/show_bug.cgi?id=176821
+
+ Reviewed by Darin Adler.
+
+ * html/canvas/CanvasRenderingContext2D.h:
+ * html/canvas/CanvasRenderingContext2D.idl:
+
+ Remove the commit operation. It is no longer part the standard (it was
+ moved to OffscreenCanvasRenderingContext2D) and it was a no-op.
+
2017-09-12 Matt Rajca <[email protected]>
Ensure the user interacted with the page before setting m_userHasInteractedWithMediaElement
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h (221968 => 221969)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h 2017-09-13 15:02:40 UTC (rev 221968)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h 2017-09-13 15:31:16 UTC (rev 221969)
@@ -118,9 +118,6 @@
void save() { ++m_unrealizedSaveCount; }
void restore();
- // This is a no-op in a direct-2d canvas.
- void commit() { }
-
void scale(float sx, float sy);
void rotate(float angleInRadians);
void translate(float tx, float ty);
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl (221968 => 221969)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl 2017-09-13 15:02:40 UTC (rev 221968)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl 2017-09-13 15:31:16 UTC (rev 221969)
@@ -32,10 +32,6 @@
// back-reference to the canvas
readonly attribute HTMLCanvasElement canvas;
- // FIXME: This has been moved to OffscreenCanvasRenderingContext2D in the latest standard.
- void commit();
-
-
// Non-standard legacy aliases (Compositing).
[ImplementedAs=setGlobalAlpha] void setAlpha(optional unrestricted float alpha = NaN);
[ImplementedAs=setGlobalCompositeOperation] void setCompositeOperation(optional DOMString compositeOperation = "undefined"); // FIXME: Using "undefined" as default parameter value is wrong.
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
