Title: [221975] trunk/Tools
- Revision
- 221975
- Author
- [email protected]
- Date
- 2017-09-13 10:46:02 -0700 (Wed, 13 Sep 2017)
Log Message
[Win] DRT option --gc-between-tests is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=176849
Reviewed by Brent Fulgham.
Perform GC after the test if this option is enabled. This patch also set the initial value of the flag
to true, in order to catch GC related issues in the test in which they occur.
* DumpRenderTree/win/DumpRenderTree.cpp:
(runTest):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (221974 => 221975)
--- trunk/Tools/ChangeLog 2017-09-13 17:14:54 UTC (rev 221974)
+++ trunk/Tools/ChangeLog 2017-09-13 17:46:02 UTC (rev 221975)
@@ -1,3 +1,16 @@
+2017-09-13 Per Arne Vollan <[email protected]>
+
+ [Win] DRT option --gc-between-tests is not implemented.
+ https://bugs.webkit.org/show_bug.cgi?id=176849
+
+ Reviewed by Brent Fulgham.
+
+ Perform GC after the test if this option is enabled. This patch also set the initial value of the flag
+ to true, in order to catch GC related issues in the test in which they occur.
+
+ * DumpRenderTree/win/DumpRenderTree.cpp:
+ (runTest):
+
2017-09-12 Wenson Hsieh <[email protected]>
[iOS DnD] Support DataTransfer.getData and DataTransfer.setData when dragging or dropping
Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (221974 => 221975)
--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2017-09-13 17:14:54 UTC (rev 221974)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2017-09-13 17:46:02 UTC (rev 221975)
@@ -31,6 +31,7 @@
#include "EditingDelegate.h"
#include "FrameLoadDelegate.h"
+#include "GCController.h"
#include "HistoryDelegate.h"
#include "_javascript_Threading.h"
#include "PixelDumpSupport.h"
@@ -43,6 +44,7 @@
#include "WorkQueue.h"
#include <CoreFoundation/CoreFoundation.h>
+#include <_javascript_Core/TestRunnerUtils.h>
#include <WebCore/FileSystem.h>
#include <WebKit/WebKit.h>
#include <WebKit/WebKitCOMAPI.h>
@@ -95,7 +97,9 @@
static bool forceComplexText = false;
static bool dumpAllPixels;
static bool useAcceleratedDrawing = true; // Not used
-static bool gcBetweenTests = false;
+// FIXME: gcBetweenTests should initially be false, but we currently set it to true, to make sure
+// deallocations are not performed in one of the following tests which might cause flakiness.
+static bool gcBetweenTests = true;
static bool printSeparators = false;
static bool leakChecking = false;
static bool printSupportedFeatures = false;
@@ -1275,6 +1279,12 @@
::gTestRunner->cleanup();
::gTestRunner = nullptr;
+ if (gcBetweenTests) {
+ GCController gcController;
+ gcController.collect();
+ }
+ JSC::waitForVMDestruction();
+
fputs("#EOF\n", stderr);
fflush(stderr);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
