Title: [222027] trunk/Source/WebKit
Revision
222027
Author
[email protected]
Date
2017-09-14 09:43:32 -0700 (Thu, 14 Sep 2017)

Log Message

[GTK][Wayland] Flickering when resizing the window
https://bugs.webkit.org/show_bug.cgi?id=176774

Reviewed by Michael Catanzaro.

This regressed when we switched to always start the wayland compositor. In
AcceleratedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState() we check if the nested compositor is
running, which is always true now (if EGL and the required extensions are available). We should check if we are
in AC mode instead.

* UIProcess/AcceleratedDrawingAreaProxy.cpp:
(WebKit::AcceleratedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (222026 => 222027)


--- trunk/Source/WebKit/ChangeLog	2017-09-14 16:35:02 UTC (rev 222026)
+++ trunk/Source/WebKit/ChangeLog	2017-09-14 16:43:32 UTC (rev 222027)
@@ -1,3 +1,18 @@
+2017-09-14  Carlos Garcia Campos  <[email protected]>
+
+        [GTK][Wayland] Flickering when resizing the window
+        https://bugs.webkit.org/show_bug.cgi?id=176774
+
+        Reviewed by Michael Catanzaro.
+
+        This regressed when we switched to always start the wayland compositor. In
+        AcceleratedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState() we check if the nested compositor is
+        running, which is always true now (if EGL and the required extensions are available). We should check if we are
+        in AC mode instead.
+
+        * UIProcess/AcceleratedDrawingAreaProxy.cpp:
+        (WebKit::AcceleratedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState):
+
 2017-09-14  Yusuke Suzuki  <[email protected]>
 
         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray

Modified: trunk/Source/WebKit/UIProcess/AcceleratedDrawingAreaProxy.cpp (222026 => 222027)


--- trunk/Source/WebKit/UIProcess/AcceleratedDrawingAreaProxy.cpp	2017-09-14 16:35:02 UTC (rev 222026)
+++ trunk/Source/WebKit/UIProcess/AcceleratedDrawingAreaProxy.cpp	2017-09-14 16:43:32 UTC (rev 222027)
@@ -210,11 +210,10 @@
         return;
     if (!m_webPageProxy.isViewVisible())
         return;
-
 #if PLATFORM(WAYLAND) && USE(EGL)
     // Never block the UI process in Wayland when waiting for DidUpdateBackingStoreState after a resize,
     // because the nested compositor needs to handle the web process requests that happens while resizing.
-    if (PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland && WaylandCompositor::singleton().isRunning())
+    if (PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland && isInAcceleratedCompositingMode())
         return;
 #endif
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to