Title: [222112] trunk
- Revision
- 222112
- Author
- [email protected]
- Date
- 2017-09-15 14:23:10 -0700 (Fri, 15 Sep 2017)
Log Message
Consider enabling -Wno-expansion-to-defined for gcc 7
https://bugs.webkit.org/show_bug.cgi?id=167643
Reviewed by Michael Catanzaro.
Don't disable -Wexpansion-to-defined for Clang.
As suggested by Nico Weber, this warning produces false positives with
GCC only.
* Source/cmake/WebKitCompilerFlags.cmake:
Modified Paths
Diff
Modified: trunk/ChangeLog (222111 => 222112)
--- trunk/ChangeLog 2017-09-15 21:15:04 UTC (rev 222111)
+++ trunk/ChangeLog 2017-09-15 21:23:10 UTC (rev 222112)
@@ -1,3 +1,16 @@
+2017-09-15 Konstantin Tokarev <[email protected]>
+
+ Consider enabling -Wno-expansion-to-defined for gcc 7
+ https://bugs.webkit.org/show_bug.cgi?id=167643
+
+ Reviewed by Michael Catanzaro.
+
+ Don't disable -Wexpansion-to-defined for Clang.
+ As suggested by Nico Weber, this warning produces false positives with
+ GCC only.
+
+ * Source/cmake/WebKitCompilerFlags.cmake:
+
2017-09-14 Yousuke Kimoto <[email protected]>
[WinCairo] Add an option to build WebKitLegacy or WebKit
Modified: trunk/Source/cmake/WebKitCompilerFlags.cmake (222111 => 222112)
--- trunk/Source/cmake/WebKitCompilerFlags.cmake 2017-09-15 21:15:04 UTC (rev 222111)
+++ trunk/Source/cmake/WebKitCompilerFlags.cmake 2017-09-15 21:23:10 UTC (rev 222112)
@@ -125,12 +125,16 @@
# Warnings to be disabled
# FIXME: We should probably not be disabling -Wno-maybe-uninitialized?
WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-Qunused-arguments
- -Wno-expansion-to-defined
-Wno-maybe-uninitialized
-Wno-noexcept-type
-Wno-parentheses-equality)
endif ()
+# -Wexpansion-to-defined produces false positives with GCC but not Clang
+# https://bugs.webkit.org/show_bug.cgi?id=167643#c13
+if (CMAKE_COMPILER_IS_GNUCXX)
+ WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-Wno-expansion-to-defined)
+endif ()
# Ninja tricks compilers into turning off color support.
if (CMAKE_GENERATOR STREQUAL "Ninja")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
