Title: [222154] trunk/Source/WebCore/ChangeLog
- Revision
- 222154
- Author
- [email protected]
- Date
- 2017-09-18 09:26:31 -0700 (Mon, 18 Sep 2017)
Log Message
REGRESSION(r221974): [Harfbuzz] Test fast/text/international/hebrew-selection.html is failing since r221974
https://bugs.webkit.org/show_bug.cgi?id=177036
Reviewed by Michael Catanzaro.
In r221974 I rewrote the characterIndexForXPosition implementation without taking into account that there can be
multiple glyphs for the same character, so we can't simply do index++ and index-- to get the next and previous
character index.
* platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition): Always get the character index from
m_glyphToCharacterIndexes array.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (222153 => 222154)
--- trunk/Source/WebCore/ChangeLog 2017-09-18 16:26:29 UTC (rev 222153)
+++ trunk/Source/WebCore/ChangeLog 2017-09-18 16:26:31 UTC (rev 222154)
@@ -1,3 +1,18 @@
+2017-09-17 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(r221974): [Harfbuzz] Test fast/text/international/hebrew-selection.html is failing since r221974
+ https://bugs.webkit.org/show_bug.cgi?id=177036
+
+ Reviewed by Michael Catanzaro.
+
+ In r221974 I rewrote the characterIndexForXPosition implementation without taking into account that there can be
+ multiple glyphs for the same character, so we can't simply do index++ and index-- to get the next and previous
+ character index.
+
+ * platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
+ (WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition): Always get the character index from
+ m_glyphToCharacterIndexes array.
+
2017-09-18 Jer Noble <[email protected]>
Virtualize ImageDecoder
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
