Title: [222204] trunk/Source/WebDriver
Revision
222204
Author
[email protected]
Date
2017-09-18 23:41:42 -0700 (Mon, 18 Sep 2017)

Log Message

WebDriver: wrong key name for capabilities in new session response
https://bugs.webkit.org/show_bug.cgi?id=177074

Reviewed by Brian Burg.

We are using "value", it should be "capabilities".
https://w3c.github.io/webdriver/webdriver-spec.html#new-session

* WebDriverService.cpp:
(WebDriver::WebDriverService::newSession):

Modified Paths

Diff

Modified: trunk/Source/WebDriver/ChangeLog (222203 => 222204)


--- trunk/Source/WebDriver/ChangeLog	2017-09-19 06:40:01 UTC (rev 222203)
+++ trunk/Source/WebDriver/ChangeLog	2017-09-19 06:41:42 UTC (rev 222204)
@@ -1,5 +1,18 @@
 2017-09-18  Carlos Garcia Campos  <[email protected]>
 
+        WebDriver: wrong key name for capabilities in new session response
+        https://bugs.webkit.org/show_bug.cgi?id=177074
+
+        Reviewed by Brian Burg.
+
+        We are using "value", it should be "capabilities".
+        https://w3c.github.io/webdriver/webdriver-spec.html#new-session
+
+        * WebDriverService.cpp:
+        (WebDriver::WebDriverService::newSession):
+
+2017-09-18  Carlos Garcia Campos  <[email protected]>
+
         WebDriver: HTTP responses should include Cache-Control header with no-cache value
         https://bugs.webkit.org/show_bug.cgi?id=177073
 

Modified: trunk/Source/WebDriver/WebDriverService.cpp (222203 => 222204)


--- trunk/Source/WebDriver/WebDriverService.cpp	2017-09-19 06:40:01 UTC (rev 222203)
+++ trunk/Source/WebDriver/WebDriverService.cpp	2017-09-19 06:41:42 UTC (rev 222204)
@@ -625,7 +625,7 @@
                     break;
                 }
             }
-            resultObject->setObject(ASCIILiteral("value"), WTFMove(capabilitiesObject));
+            resultObject->setObject(ASCIILiteral("capabilities"), WTFMove(capabilitiesObject));
             completionHandler(CommandResult::success(WTFMove(resultObject)));
         });
     });
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to