Title: [222209] trunk/Source/WebInspectorUI
Revision
222209
Author
[email protected]
Date
2017-09-19 09:03:09 -0700 (Tue, 19 Sep 2017)

Log Message

REGRESSION(r214494): Web Inspector: Ignore cache button does not work in Network tab
https://bugs.webkit.org/show_bug.cgi?id=177114
<rdar://problem/34505265>

Patch by Joseph Pecoraro <[email protected]> on 2017-09-19
Reviewed by Brian Burg.

* UserInterface/Base/Main.js:
(WI.loaded):
We need to register the settings change handler regardless of what the
initial value of the setting is.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (222208 => 222209)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-09-19 15:53:01 UTC (rev 222208)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-09-19 16:03:09 UTC (rev 222209)
@@ -1,3 +1,16 @@
+2017-09-19  Joseph Pecoraro  <[email protected]>
+
+        REGRESSION(r214494): Web Inspector: Ignore cache button does not work in Network tab
+        https://bugs.webkit.org/show_bug.cgi?id=177114
+        <rdar://problem/34505265>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Base/Main.js:
+        (WI.loaded):
+        We need to register the settings change handler regardless of what the
+        initial value of the setting is.
+
 2017-09-18  Matt Baker  <[email protected]>
 
         Web Inspector: RemoteObject.resolveNode should return a Promise

Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (222208 => 222209)


--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2017-09-19 15:53:01 UTC (rev 222208)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2017-09-19 16:03:09 UTC (rev 222209)
@@ -183,8 +183,9 @@
 
     // COMPATIBILITY (iOS 10.3): Network.setDisableResourceCaching did not exist.
     this.resourceCachingDisabledSetting = new WI.Setting("disable-resource-caching", false);
-    if (window.NetworkAgent && NetworkAgent.setResourceCachingDisabled && this.resourceCachingDisabledSetting.value) {
-        NetworkAgent.setResourceCachingDisabled(true);
+    if (window.NetworkAgent && NetworkAgent.setResourceCachingDisabled) {
+        if (this.resourceCachingDisabledSetting.value)
+            NetworkAgent.setResourceCachingDisabled(true);
         this.resourceCachingDisabledSetting.addEventListener(WI.Setting.Event.Changed, this._resourceCachingDisabledSettingChanged, this);
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to