Title: [222211] trunk/Source/WebKit
- Revision
- 222211
- Author
- [email protected]
- Date
- 2017-09-19 10:41:42 -0700 (Tue, 19 Sep 2017)
Log Message
Make _WKProcessPoolConfiguration.allowsCellularAccess actually work on iOS
https://bugs.webkit.org/show_bug.cgi?id=177124
Reviewed by Andy Estes.
The boolean added in r213747 was getting lost in two places:
1. The API::ProcessPoolConfiguration gets copied before it's used, so we need to set the bool on the copy.
2. The bool was not getting copied from that ProcessPoolConfiguration to the NetworkProcessCreationParameters
to be sent to the NetworkProcess to be given to the NSURLSessionConfiguration in NetworkSessionCocoa.mm.
These two problems were fixed and verified manually with a customized iOS app on my phone.
Unfortunately, this cannot be tested well with our current test infrastructure.
* UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (222210 => 222211)
--- trunk/Source/WebKit/ChangeLog 2017-09-19 16:38:37 UTC (rev 222210)
+++ trunk/Source/WebKit/ChangeLog 2017-09-19 17:41:42 UTC (rev 222211)
@@ -1,3 +1,23 @@
+2017-09-19 Alex Christensen <[email protected]>
+
+ Make _WKProcessPoolConfiguration.allowsCellularAccess actually work on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=177124
+
+ Reviewed by Andy Estes.
+
+ The boolean added in r213747 was getting lost in two places:
+ 1. The API::ProcessPoolConfiguration gets copied before it's used, so we need to set the bool on the copy.
+ 2. The bool was not getting copied from that ProcessPoolConfiguration to the NetworkProcessCreationParameters
+ to be sent to the NetworkProcess to be given to the NSURLSessionConfiguration in NetworkSessionCocoa.mm.
+
+ These two problems were fixed and verified manually with a customized iOS app on my phone.
+ Unfortunately, this cannot be tested well with our current test infrastructure.
+
+ * UIProcess/API/APIProcessPoolConfiguration.cpp:
+ (API::ProcessPoolConfiguration::copy):
+ * UIProcess/WebProcessPool.cpp:
+ (WebKit::WebProcessPool::ensureNetworkProcess):
+
2017-09-18 Michael Catanzaro <[email protected]>
[CMake] Rename WebKit target to WebKitLegacy and rename WebKit2 target to WebKit
Modified: trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp (222210 => 222211)
--- trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp 2017-09-19 16:38:37 UTC (rev 222210)
+++ trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp 2017-09-19 17:41:42 UTC (rev 222211)
@@ -126,6 +126,7 @@
copy->m_fullySynchronousModeIsAllowedForTesting = this->m_fullySynchronousModeIsAllowedForTesting;
copy->m_ignoreSynchronousMessagingTimeoutsForTesting = this->m_ignoreSynchronousMessagingTimeoutsForTesting;
copy->m_overrideLanguages = this->m_overrideLanguages;
+ copy->m_allowsCellularAccess = this->m_allowsCellularAccess;
copy->m_sourceApplicationBundleIdentifier = this->m_sourceApplicationBundleIdentifier;
copy->m_sourceApplicationSecondaryIdentifier = this->m_sourceApplicationSecondaryIdentifier;
copy->m_alwaysRunsAtBackgroundPriority = this->m_alwaysRunsAtBackgroundPriority;
Modified: trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h (222210 => 222211)
--- trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h 2017-09-19 16:38:37 UTC (rev 222210)
+++ trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h 2017-09-19 17:41:42 UTC (rev 222211)
@@ -23,8 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef APIContextConfiguration_h
-#define APIContextConfiguration_h
+#pragma once
#include "APIObject.h"
#include "CacheModel.h"
@@ -181,5 +180,3 @@
};
} // namespace API
-
-#endif // APIContextConfiguration_h
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (222210 => 222211)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2017-09-19 16:38:37 UTC (rev 222210)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2017-09-19 17:41:42 UTC (rev 222211)
@@ -457,6 +457,8 @@
String parentBundleDirectory = this->parentBundleDirectory();
if (!parentBundleDirectory.isEmpty())
SandboxExtension::createHandle(parentBundleDirectory, SandboxExtension::Type::ReadOnly, parameters.parentBundleDirectoryExtensionHandle);
+
+ parameters.allowsCellularAccess = m_configuration->allowsCellularAccess();
#endif
#if OS(LINUX)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
