Title: [222314] trunk/Source/WebCore
Revision
222314
Author
[email protected]
Date
2017-09-20 23:49:54 -0700 (Wed, 20 Sep 2017)

Log Message

inspector/dom/content-node-region-info.html and inspector/dom/content-flow tests crashing
https://bugs.webkit.org/show_bug.cgi?id=177249
<rdar://problem/34559968>

Unreviewed.


* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getNamedFlowCollection):

    Fix crashing by adding a few lines of removed code back.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (222313 => 222314)


--- trunk/Source/WebCore/ChangeLog	2017-09-21 05:45:08 UTC (rev 222313)
+++ trunk/Source/WebCore/ChangeLog	2017-09-21 06:49:54 UTC (rev 222314)
@@ -1,3 +1,16 @@
+2017-09-20  Antti Koivisto  <[email protected]>
+
+        inspector/dom/content-node-region-info.html and inspector/dom/content-flow tests crashing
+        https://bugs.webkit.org/show_bug.cgi?id=177249
+        <rdar://problem/34559968>
+
+        Unreviewed.
+
+        * inspector/InspectorCSSAgent.cpp:
+        (WebCore::InspectorCSSAgent::getNamedFlowCollection):
+
+            Fix crashing by adding a few lines of removed code back.
+
 2017-09-20  Zalan Bujtas  <[email protected]>
 
         Remove redundant SelectionSubtreeData functions.

Modified: trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp (222313 => 222314)


--- trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp	2017-09-21 05:45:08 UTC (rev 222313)
+++ trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp	2017-09-21 06:49:54 UTC (rev 222314)
@@ -777,8 +777,15 @@
     element->document().styleScope().didChangeStyleSheetEnvironment();
 }
 
-void InspectorCSSAgent::getNamedFlowCollection(ErrorString&, int, RefPtr<Inspector::Protocol::Array<Inspector::Protocol::CSS::NamedFlow>>&)
+void InspectorCSSAgent::getNamedFlowCollection(ErrorString& errorString, int documentNodeId, RefPtr<Inspector::Protocol::Array<Inspector::Protocol::CSS::NamedFlow>>& result)
 {
+    Document* document = m_domAgent->assertDocument(errorString, documentNodeId);
+    if (!document)
+        return;
+
+    auto namedFlows = Inspector::Protocol::Array<Inspector::Protocol::CSS::NamedFlow>::create();
+
+    result = WTFMove(namedFlows);
 }
 
 InspectorStyleSheetForInlineStyle& InspectorCSSAgent::asInspectorStyleSheet(StyledElement& element)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to