Title: [222325] trunk/Source/WebCore
- Revision
- 222325
- Author
- [email protected]
- Date
- 2017-09-21 10:12:24 -0700 (Thu, 21 Sep 2017)
Log Message
Fix ASAN build after r222306
https://bugs.webkit.org/show_bug.cgi?id=177255
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setCustomHeaderFields):
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::setCustomHeaderFields): Deleted.
Moving a Vector of a type requires more than just a forward declaration of the type, but only in ASAN builds. Weird.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (222324 => 222325)
--- trunk/Source/WebCore/ChangeLog 2017-09-21 16:56:22 UTC (rev 222324)
+++ trunk/Source/WebCore/ChangeLog 2017-09-21 17:12:24 UTC (rev 222325)
@@ -1,3 +1,14 @@
+2017-09-21 Alex Christensen <[email protected]>
+
+ Fix ASAN build after r222306
+ https://bugs.webkit.org/show_bug.cgi?id=177255
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::setCustomHeaderFields):
+ * loader/DocumentLoader.h:
+ (WebCore::DocumentLoader::setCustomHeaderFields): Deleted.
+ Moving a Vector of a type requires more than just a forward declaration of the type, but only in ASAN builds. Weird.
+
2017-09-21 Zhifei FANG <[email protected]>
In regular block layout, the width of a child's margin box should always be equal to that of its containing block
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (222324 => 222325)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2017-09-21 16:56:22 UTC (rev 222324)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2017-09-21 17:12:24 UTC (rev 222325)
@@ -1036,6 +1036,11 @@
checkLoadComplete();
}
+void DocumentLoader::setCustomHeaderFields(Vector<HTTPHeaderField>&& fields)
+{
+ m_customHeaderFields = WTFMove(fields);
+}
+
bool DocumentLoader::isLoadingInAPISense() const
{
// Once a frame has loaded, we no longer need to consider subresources,
Modified: trunk/Source/WebCore/loader/DocumentLoader.h (222324 => 222325)
--- trunk/Source/WebCore/loader/DocumentLoader.h 2017-09-21 16:56:22 UTC (rev 222324)
+++ trunk/Source/WebCore/loader/DocumentLoader.h 2017-09-21 17:12:24 UTC (rev 222325)
@@ -296,7 +296,7 @@
const Vector<LinkIcon>& linkIcons() const { return m_linkIcons; }
- void setCustomHeaderFields(Vector<HTTPHeaderField>&& fields) { m_customHeaderFields = WTFMove(fields); }
+ void setCustomHeaderFields(Vector<HTTPHeaderField>&& fields);
protected:
WEBCORE_EXPORT DocumentLoader(const ResourceRequest&, const SubstituteData&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
