[webkit-changes] [222361] trunk/LayoutTests

Thu, 21 Sep 2017 16:07:14 -0700

Title: [222361] trunk/LayoutTests
Revision
222361
Author
[email protected]
Date
2017-09-21 16:06:19 -0700 (Thu, 21 Sep 2017)

Log Message

LayoutTest platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=173741

Patch by Youenn Fablet <[email protected]> on 2017-09-21
Reviewed by Alex Christensen.

Making the test more robust by getting the reference canvas to compare with each time a new comparison is done.
Previously, this was done at the start of the comparison.
Also increasing the threshold since we are going from 0 to 255 or vice-versa.

* platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (222360 => 222361)


--- trunk/LayoutTests/ChangeLog	2017-09-21 23:06:07 UTC (rev 222360)
+++ trunk/LayoutTests/ChangeLog	2017-09-21 23:06:19 UTC (rev 222361)
@@ -1,3 +1,16 @@
+2017-09-21  Youenn Fablet  <[email protected]>
+
+        LayoutTest platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=173741
+
+        Reviewed by Alex Christensen.
+
+        Making the test more robust by getting the reference canvas to compare with each time a new comparison is done.
+        Previously, this was done at the start of the comparison.
+        Also increasing the threshold since we are going from 0 to 255 or vice-versa.
+
+        * platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:
+
 2017-09-21  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: Remove support for CSS Regions

Modified: trunk/LayoutTests/platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html (222360 => 222361)


--- trunk/LayoutTests/platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html	2017-09-21 23:06:07 UTC (rev 222360)
+++ trunk/LayoutTests/platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html	2017-09-21 23:06:19 UTC (rev 222361)
@@ -21,8 +21,9 @@
 if (window.internals)
     internals.setH264HardwareEncoderAllowed(false);
 
-function testCanvas(testName, array1, isSame, count)
+function testCanvas(testName, canvas, isSame, count)
 {
+    var array1 = canvas.getContext("2d").getImageData(20, 20, 60, 60).data;
     if (count === undefined)
         count = 0;
     canvas2.getContext("2d").drawImage(video, 0 ,0);
@@ -31,7 +32,7 @@
     for (var index = 0; index < array1.length; ++index) {
         // Rough comparison since we are compressing data.
         // This test still catches errors since we are going from green to blue to red.
-        if (Math.abs(array1[index] - array2[index]) > 40) {
+        if (Math.abs(array1[index] - array2[index]) > 100) {
             isEqual = false;
             continue;
         }
@@ -43,7 +44,7 @@
         return Promise.reject(testName + " failed");
 
     return waitFor(100).then(() => {
-        return testCanvas(testName, array1, isSame, ++count);
+        return testCanvas(testName, canvas, isSame, ++count);
     });
 }
 
@@ -67,7 +68,7 @@
         video.srcObject = stream;
         return video.play();
     }).then(() => {
-        return testCanvas("test1", canvas0.getContext("2d").getImageData(20 ,20, 60, 60).data, true);
+        return testCanvas("test1", canvas0, true);
     }).then(() => {
         canvas1.color = "blue";
         printRectangle(canvas1);
@@ -76,9 +77,9 @@
     }).then(() => {
         return waitFor(200);
     }).then(() => {
-        return testCanvas("test2", canvas1.getContext("2d").getImageData(20 ,20, 60, 60).data, false);
+        return testCanvas("test2", canvas1, false);
     }).then(() => {
-        return testCanvas("test3", canvas0.getContext("2d").getImageData(20 ,20, 60, 60).data, true);
+        return testCanvas("test3", canvas0, true);
     }).then(() => {
         return sender.replaceTrack(canvas0Track);
     }).then(() => {
@@ -86,7 +87,7 @@
         // Let's wait for red color to be printed on canvas0
         return waitFor(200);
     }).then(() => {
-        return testCanvas("test4", canvas0.getContext("2d").getImageData(20 ,20, 60, 60).data, true);
+        return testCanvas("test4", canvas0, true);
     }).catch((error) => {
         if (window.internals)
             internals.setH264HardwareEncoderAllowed(true);

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to