Title: [222393] trunk/Source/WebCore
- Revision
- 222393
- Author
- [email protected]
- Date
- 2017-09-22 10:45:09 -0700 (Fri, 22 Sep 2017)
Log Message
Add asserts against layout time render tree mutations
https://bugs.webkit.org/show_bug.cgi?id=177361
Reviewed by Zalan Bujtas.
We don't have any mutations left. Add asserts.
* rendering/RenderElement.cpp:
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (222392 => 222393)
--- trunk/Source/WebCore/ChangeLog 2017-09-22 17:13:06 UTC (rev 222392)
+++ trunk/Source/WebCore/ChangeLog 2017-09-22 17:45:09 UTC (rev 222393)
@@ -1,3 +1,16 @@
+2017-09-22 Antti Koivisto <[email protected]>
+
+ Add asserts against layout time render tree mutations
+ https://bugs.webkit.org/show_bug.cgi?id=177361
+
+ Reviewed by Zalan Bujtas.
+
+ We don't have any mutations left. Add asserts.
+
+ * rendering/RenderElement.cpp:
+ (WebCore::RenderElement::insertChildInternal):
+ (WebCore::RenderElement::removeChildInternal):
+
2017-09-22 Chris Dumez <[email protected]>
Use high resolution timestamp for event time
Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (222392 => 222393)
--- trunk/Source/WebCore/rendering/RenderElement.cpp 2017-09-22 17:13:06 UTC (rev 222392)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp 2017-09-22 17:45:09 UTC (rev 222393)
@@ -508,6 +508,8 @@
void RenderElement::insertChildInternal(RenderObject* newChild, RenderObject* beforeChild, NotifyChildrenType notifyChildren)
{
+ RELEASE_ASSERT_WITH_MESSAGE(!view().layoutState(), "Layout must not mutate render tree");
+
ASSERT(canHaveChildren() || canHaveGeneratedChildren());
ASSERT(!newChild->parent());
ASSERT(!isRenderBlockFlow() || (!newChild->isTableSection() && !newChild->isTableRow() && !newChild->isTableCell()));
@@ -565,6 +567,8 @@
void RenderElement::removeChildInternal(RenderObject& oldChild, NotifyChildrenType notifyChildren)
{
+ RELEASE_ASSERT_WITH_MESSAGE(!view().layoutState(), "Layout must not mutate render tree");
+
ASSERT(canHaveChildren() || canHaveGeneratedChildren());
ASSERT(oldChild.parent() == this);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
