Title: [222395] trunk/Source/WebCore
- Revision
- 222395
- Author
- [email protected]
- Date
- 2017-09-22 11:44:54 -0700 (Fri, 22 Sep 2017)
Log Message
[CMake][Win] EventTargetInterfaces.h are generated twice
https://bugs.webkit.org/show_bug.cgi?id=177286
Patch by Fujii Hironori <[email protected]> on 2017-09-22
Reviewed by Brent Fulgham.
EventTargetInterfaces.h are generated twice in both
WebCoreDerivedSources.vcxproj and WebCore.vcxproj. This causes
unnecessary recompilation in CMake VisualStudio build.
WebCore target already has a dependency to WebCoreDerivedSources
target by calling add_dependencies. WebCore target doesn't need to
generate it.
* CMakeLists.txt: Don't ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES with EventTargetInterfaces.h.
Modified Paths
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (222394 => 222395)
--- trunk/Source/WebCore/CMakeLists.txt 2017-09-22 18:11:51 UTC (rev 222394)
+++ trunk/Source/WebCore/CMakeLists.txt 2017-09-22 18:44:54 UTC (rev 222395)
@@ -4017,8 +4017,6 @@
GENERATE_EVENT_FACTORY(${WEBCORE_DIR}/dom/EventTargetFactory.in EventTargetInterfaces.h)
-ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES(${WEBCORE_DIR}/dom/EventNames.cpp EventTargetInterfaces.h)
-ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES(${WEBCORE_DIR}/dom/DOMAllInOne.cpp EventTargetInterfaces.h)
list(APPEND WebCore_DERIVED_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/EventTargetInterfaces.h)
Modified: trunk/Source/WebCore/ChangeLog (222394 => 222395)
--- trunk/Source/WebCore/ChangeLog 2017-09-22 18:11:51 UTC (rev 222394)
+++ trunk/Source/WebCore/ChangeLog 2017-09-22 18:44:54 UTC (rev 222395)
@@ -1,3 +1,20 @@
+2017-09-22 Fujii Hironori <[email protected]>
+
+ [CMake][Win] EventTargetInterfaces.h are generated twice
+ https://bugs.webkit.org/show_bug.cgi?id=177286
+
+ Reviewed by Brent Fulgham.
+
+ EventTargetInterfaces.h are generated twice in both
+ WebCoreDerivedSources.vcxproj and WebCore.vcxproj. This causes
+ unnecessary recompilation in CMake VisualStudio build.
+
+ WebCore target already has a dependency to WebCoreDerivedSources
+ target by calling add_dependencies. WebCore target doesn't need to
+ generate it.
+
+ * CMakeLists.txt: Don't ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES with EventTargetInterfaces.h.
+
2017-09-22 Antti Koivisto <[email protected]>
Add asserts against layout time render tree mutations
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
