Diff
Modified: trunk/LayoutTests/ChangeLog (100163 => 100164)
--- trunk/LayoutTests/ChangeLog 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/ChangeLog 2011-11-14 19:14:48 UTC (rev 100164)
@@ -1,5 +1,27 @@
2011-11-14 Erik Arvidsson <[email protected]>
+ Remove getParameter from HTMLAnchorElement and Location
+ https://bugs.webkit.org/show_bug.cgi?id=71966
+
+ Reviewed by Adam Barth.
+
+ * fast/dom/HTMLAnchorElement/get-parameter-expected.txt: Removed.
+ * fast/dom/HTMLAnchorElement/get-parameter.html: Removed.
+ * fast/dom/Window/window-appendages-cleared-expected.txt:
+ * fast/dom/Window/window-properties-expected.txt:
+ * fast/dom/anchor-getParameter-expected.txt: Removed.
+ * fast/dom/anchor-getParameter.html: Removed.
+ * http/tests/misc/location-getParameter-expected.txt: Removed.
+ * http/tests/misc/location-getParameter.html: Removed.
+ * platform/gtk/fast/dom/Window/window-properties-expected.txt:
+ * platform/mac/fast/dom/Window/window-properties-expected.txt:
+ * platform/qt-5.0/Skipped:
+ * platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
+ * platform/qt/fast/dom/Window/window-properties-expected.txt:
+ * platform/win/fast/dom/Window/window-properties-expected.txt:
+
+2011-11-14 Erik Arvidsson <[email protected]>
+
Remove RequiresAllArguments
https://bugs.webkit.org/show_bug.cgi?id=71503
Deleted: trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter-expected.txt (100163 => 100164)
--- trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter-expected.txt 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter-expected.txt 2011-11-14 19:14:48 UTC (rev 100164)
@@ -1,10 +0,0 @@
-Test calling getParameter without required arguments.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS a.getParameter() threw exception TypeError: Not enough arguments.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter.html (100163 => 100164)
--- trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter.html 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/fast/dom/HTMLAnchorElement/get-parameter.html 2011-11-14 19:14:48 UTC (rev 100164)
@@ -1,16 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src=""
-</head>
-<body>
-<script>
-description('Test calling getParameter without required arguments.');
-
-var a = document.createElement('a');
-
-shouldThrow("a.getParameter()");
-</script>
-<script src=""
-</body>
-</html>
Modified: trunk/LayoutTests/fast/dom/Window/window-appendages-cleared-expected.txt (100163 => 100164)
--- trunk/LayoutTests/fast/dom/Window/window-appendages-cleared-expected.txt 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/fast/dom/Window/window-appendages-cleared-expected.txt 2011-11-14 19:14:48 UTC (rev 100164)
@@ -5,7 +5,6 @@
PASS history.pushState == "LEFTOVER" is false
PASS history.replaceState == "LEFTOVER" is false
PASS location.assign == "LEFTOVER" is false
-PASS location.getParameter == "LEFTOVER" is false
PASS location.hash == "LEFTOVER" is false
PASS location.host == "LEFTOVER" is false
PASS location.hostname == "LEFTOVER" is false
Modified: trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt (100163 => 100164)
--- trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt 2011-11-14 19:14:48 UTC (rev 100164)
@@ -2335,7 +2335,6 @@
window.localStorage [printed above as window.Storage.prototype]
window.location [object Location]
window.location.assign [function]
-window.location.getParameter [function]
window.location.hash [string]
window.location.host [string]
window.location.hostname [string]
Deleted: trunk/LayoutTests/fast/dom/anchor-getParameter-expected.txt (100163 => 100164)
--- trunk/LayoutTests/fast/dom/anchor-getParameter-expected.txt 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/fast/dom/anchor-getParameter-expected.txt 2011-11-14 19:14:48 UTC (rev 100164)
@@ -1,20 +0,0 @@
-http://example.com/foo/bar?a=b (a) => b
-http://example.com/foo/bar?abc=xy (abc) => xy
-http://example.com/foo/bar?a=x&b=y (a) => x
-http://example.com/foo/bar?a=x&b=y (b) => y
-http://example.com/foo/bar?a=x&a=y (a) => y
-http://example.com/foo/bar?a=x&a=y&a=z (a) => z
-http://example.com/foo/bar?a=x&A=y&a=z (A) => y
-http://example.com/foo/bar?121= (121) =>
-http://example.com/foo/bar?a& (a) =>
-http://example.com/foo/bar?a (a) =>
-http://example.com/foo/bar?=a& (a) =>
-http://example.com/foo/bar?a=b=c (a) => b=c
-http://example.com/foo/bar?a=b=c (b) =>
-http://example.com/foo/bar?a=b=& (a) => b=
-http://example.com/foo/bar?a=b=& (b) =>
-http://example.com/foo/bar?&a=b (a) => b
-http://example.com/foo/bar?&a=b& (a) => b
-http://example.com/foo/bar?a=b#xyz (a) => b
-http://example.com/foo/bar?#a=b#xyz (a) =>
-
Deleted: trunk/LayoutTests/fast/dom/anchor-getParameter.html (100163 => 100164)
--- trunk/LayoutTests/fast/dom/anchor-getParameter.html 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/fast/dom/anchor-getParameter.html 2011-11-14 19:14:48 UTC (rev 100164)
@@ -1,40 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<script>
-if (window.layoutTestController)
- layoutTestController.dumpAsText();
-
-var cases = [
- ["http://example.com/foo/bar?a=b", 'a'],
- ["http://example.com/foo/bar?abc=xy", 'abc'],
- ["http://example.com/foo/bar?a=x&b=y", 'a'],
- ["http://example.com/foo/bar?a=x&b=y", 'b'],
- ["http://example.com/foo/bar?a=x&a=y", 'a'],
- ["http://example.com/foo/bar?a=x&a=y&a=z", 'a'],
- ["http://example.com/foo/bar?a=x&A=y&a=z", 'A'],
- ["http://example.com/foo/bar?121=", '121'],
- ["http://example.com/foo/bar?a&", 'a'],
- ["http://example.com/foo/bar?a", 'a'],
- ["http://example.com/foo/bar?=a&", 'a'],
- ["http://example.com/foo/bar?a=b=c", 'a'],
- ["http://example.com/foo/bar?a=b=c", 'b'],
- ["http://example.com/foo/bar?a=b=&", 'a'],
- ["http://example.com/foo/bar?a=b=&", 'b'],
- ["http://example.com/foo/bar?&a=b", 'a'],
- ["http://example.com/foo/bar?&a=b&", 'a'],
- ["http://example.com/foo/bar?a=b#xyz", 'a'],
- ["http://example.com/foo/bar?#a=b#xyz", 'a']
-];
-
-document.write('<div style="display:none">');
-for (var i = 0; i < cases.length; ++i)
- document.write('<a href="" + cases[i][0] + '">Link</a><br>');
-document.write('</div>');
-
-var elmts = document.getElementsByTagName('a');
-for (var i = 0; i < elmts.length; ++i)
- document.write(elmts[i].href + ' (' + cases[i][1] + ') => ' + elmts[i].getParameter(cases[i][1]) + '<br>');
-</script>
-</body>
-</html>
Deleted: trunk/LayoutTests/http/tests/misc/location-getParameter-expected.txt (100163 => 100164)
--- trunk/LayoutTests/http/tests/misc/location-getParameter-expected.txt 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/http/tests/misc/location-getParameter-expected.txt 2011-11-14 19:14:48 UTC (rev 100164)
@@ -1,4 +0,0 @@
-
-b
-d
-
Deleted: trunk/LayoutTests/http/tests/misc/location-getParameter.html (100163 => 100164)
--- trunk/LayoutTests/http/tests/misc/location-getParameter.html 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/http/tests/misc/location-getParameter.html 2011-11-14 19:14:48 UTC (rev 100164)
@@ -1,16 +0,0 @@
-<script>
-if (window.layoutTestController)
- layoutTestController.dumpAsText();
-
-if (top === self) {
- document.write('<iframe src="" location + '?a=b&c=d#ttt"></iframe>');
-
- window._onload_ = function() {
- document.getElementById('results').innerHTML =
- frames[0].location.getParameter('a') + '<br>' +
- frames[0].location.getParameter('c') + '<br>' +
- frames[0].location.getParameter('d');
- }
-}
-</script>
-<div id="results"></div>
Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt (100163 => 100164)
--- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2011-11-14 19:14:48 UTC (rev 100164)
@@ -2423,7 +2423,6 @@
window.localStorage [printed above as window.Storage.prototype]
window.location [object Location]
window.location.assign [function]
-window.location.getParameter [function]
window.location.hash [string]
window.location.host [string]
window.location.hostname [string]
Modified: trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt (100163 => 100164)
--- trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt 2011-11-14 19:14:48 UTC (rev 100164)
@@ -2472,7 +2472,6 @@
window.localStorage [printed above as window.Storage.prototype]
window.location [object Location]
window.location.assign [function]
-window.location.getParameter [function]
window.location.hash [string]
window.location.host [string]
window.location.hostname [string]
Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (100163 => 100164)
--- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-11-14 19:14:48 UTC (rev 100164)
@@ -2393,7 +2393,6 @@
window.localStorage [printed above as window.Storage.prototype]
window.location [object Location]
window.location.assign [function]
-window.location.getParameter [function]
window.location.hash [string]
window.location.host [string]
window.location.hostname [string]
Modified: trunk/LayoutTests/platform/qt-5.0/Skipped (100163 => 100164)
--- trunk/LayoutTests/platform/qt-5.0/Skipped 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/platform/qt-5.0/Skipped 2011-11-14 19:14:48 UTC (rev 100164)
@@ -2513,7 +2513,6 @@
fast/dom/Window/window-resize-contents.html
fast/dom/Window/window-xy-properties.html
fast/dom/access-key-iframe.html
-fast/dom/anchor-getParameter.html
fast/dom/anchor-text.html
fast/dom/anchor-toString.html
fast/dom/attr_dead_doc.html
Modified: trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt (100163 => 100164)
--- trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt 2011-11-14 19:14:48 UTC (rev 100164)
@@ -2304,7 +2304,6 @@
window.localStorage [printed above as window.Storage.prototype]
window.location [object Location]
window.location.assign [function]
-window.location.getParameter [function]
window.location.hash [string]
window.location.host [string]
window.location.hostname [string]
Modified: trunk/LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt (100163 => 100164)
--- trunk/LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt 2011-11-14 19:14:48 UTC (rev 100164)
@@ -2347,7 +2347,6 @@
window.localStorage [printed above as window.Storage.prototype]
window.location [object Location]
window.location.assign [function]
-window.location.getParameter [function]
window.location.hash [string]
window.location.host [string]
window.location.hostname [string]
Modified: trunk/Source/WebCore/ChangeLog (100163 => 100164)
--- trunk/Source/WebCore/ChangeLog 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/Source/WebCore/ChangeLog 2011-11-14 19:14:48 UTC (rev 100164)
@@ -1,5 +1,19 @@
2011-11-14 Erik Arvidsson <[email protected]>
+ Remove getParameter from HTMLAnchorElement and Location
+ https://bugs.webkit.org/show_bug.cgi?id=71966
+
+ Reviewed by Adam Barth.
+
+ * html/HTMLAnchorElement.cpp: Removed getParameter.
+ * html/HTMLAnchorElement.h: Ditto.
+ * html/HTMLAnchorElement.idl: Ditto.
+ * page/Location.cpp: Ditto.
+ * page/Location.h: Ditto.
+ * page/Location.idl: Ditto.
+
+2011-11-14 Erik Arvidsson <[email protected]>
+
Remove RequiresAllArguments
https://bugs.webkit.org/show_bug.cgi?id=71503
Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (100163 => 100164)
--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2011-11-14 19:14:48 UTC (rev 100164)
@@ -452,13 +452,6 @@
return origin->toString();
}
-String HTMLAnchorElement::getParameter(const String& name) const
-{
- ParsedURLParameters parameters;
- href().copyParsedQueryTo(parameters);
- return parameters.get(name);
-}
-
void HTMLAnchorElement::setSearch(const String& value)
{
KURL url = ""
Modified: trunk/Source/WebCore/html/HTMLAnchorElement.h (100163 => 100164)
--- trunk/Source/WebCore/html/HTMLAnchorElement.h 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.h 2011-11-14 19:14:48 UTC (rev 100164)
@@ -84,8 +84,6 @@
String origin() const;
- String getParameter(const String&) const;
-
String text();
String toString() const;
Modified: trunk/Source/WebCore/html/HTMLAnchorElement.idl (100163 => 100164)
--- trunk/Source/WebCore/html/HTMLAnchorElement.idl 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.idl 2011-11-14 19:14:48 UTC (rev 100164)
@@ -55,8 +55,6 @@
readonly attribute [ConvertNullToNullString] DOMString origin;
#endif
- DOMString getParameter(in DOMString name);
-
readonly attribute DOMString text;
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
Modified: trunk/Source/WebCore/page/Location.cpp (100163 => 100164)
--- trunk/Source/WebCore/page/Location.cpp 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/Source/WebCore/page/Location.cpp 2011-11-14 19:14:48 UTC (rev 100164)
@@ -138,16 +138,6 @@
return fragmentIdentifier.isEmpty() ? emptyString() : "#" + fragmentIdentifier;
}
-String Location::getParameter(const String& name) const
-{
- if (!m_frame)
- return String();
-
- ParsedURLParameters parameters;
- url().copyParsedQueryTo(parameters);
- return parameters.get(name);
-}
-
void Location::setHref(const String& urlString, DOMWindow* activeWindow, DOMWindow* firstWindow)
{
if (!m_frame)
Modified: trunk/Source/WebCore/page/Location.h (100163 => 100164)
--- trunk/Source/WebCore/page/Location.h 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/Source/WebCore/page/Location.h 2011-11-14 19:14:48 UTC (rev 100164)
@@ -73,8 +73,6 @@
String toString() const { return href(); }
- String getParameter(const String&) const;
-
private:
Location(Frame*);
Modified: trunk/Source/WebCore/page/Location.idl (100163 => 100164)
--- trunk/Source/WebCore/page/Location.idl 2011-11-14 19:11:57 UTC (rev 100163)
+++ trunk/Source/WebCore/page/Location.idl 2011-11-14 19:14:48 UTC (rev 100164)
@@ -63,8 +63,6 @@
readonly attribute DOMString origin;
#endif
- DOMString getParameter(in DOMString name);
-
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
[DontEnum, Custom, V8OnInstance, V8ReadOnly, ImplementationFunction=toStringFunction] DOMString toString();
#endif
