Title: [222414] trunk/Source/WebKit
Revision
222414
Author
[email protected]
Date
2017-09-22 16:37:23 -0700 (Fri, 22 Sep 2017)

Log Message

Re-enable configuration.HTTPCookieStorage on session without credentials
https://bugs.webkit.org/show_bug.cgi?id=177393

This patch rolls back the crucial change to the network session
without credentials that landed in r221632:
<http://trac.webkit.org/changeset/221632>

Reviewed by Brent Fulgham.

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
    Commented out the disabled cookie jar and added a FIXME
    referring to https://bugs.webkit.org/show_bug.cgi?id=177394.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (222413 => 222414)


--- trunk/Source/WebKit/ChangeLog	2017-09-22 23:27:23 UTC (rev 222413)
+++ trunk/Source/WebKit/ChangeLog	2017-09-22 23:37:23 UTC (rev 222414)
@@ -1,3 +1,19 @@
+2017-09-22  John Wilander  <[email protected]>
+
+        Re-enable configuration.HTTPCookieStorage on session without credentials
+        https://bugs.webkit.org/show_bug.cgi?id=177393
+
+        This patch rolls back the crucial change to the network session
+        without credentials that landed in r221632:
+        <http://trac.webkit.org/changeset/221632>
+
+        Reviewed by Brent Fulgham.
+
+        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+        (WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+            Commented out the disabled cookie jar and added a FIXME
+            referring to https://bugs.webkit.org/show_bug.cgi?id=177394.
+
 2017-09-22  Chris Dumez  <[email protected]>
 
         Enable File and Directory Entries API at runtime

Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (222413 => 222414)


--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2017-09-22 23:27:23 UTC (rev 222413)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2017-09-22 23:37:23 UTC (rev 222414)
@@ -601,8 +601,9 @@
 
     configuration.URLCredentialStorage = nil;
     configuration._shouldSkipPreferredClientCertificateLookup = YES;
-    configuration.HTTPCookieStorage = nil;
-    configuration.HTTPCookieAcceptPolicy = NSHTTPCookieAcceptPolicyNever;
+    // FIXME: https://bugs.webkit.org/show_bug.cgi?id=177394
+    // configuration.HTTPCookieStorage = nil;
+    // configuration.HTTPCookieAcceptPolicy = NSHTTPCookieAcceptPolicyNever;
 
     m_statelessSessionDelegate = adoptNS([[WKNetworkSessionDelegate alloc] initWithNetworkSession:*this withCredentials:false]);
     m_statelessSession = [NSURLSession sessionWithConfiguration:configuration delegate:static_cast<id>(m_statelessSessionDelegate.get()) delegateQueue:[NSOperationQueue mainQueue]];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to