Title: [222428] trunk/JSTests
Revision
222428
Author
[email protected]
Date
2017-09-23 17:46:49 -0700 (Sat, 23 Sep 2017)

Log Message

Fix infinite looping test262 test
https://bugs.webkit.org/show_bug.cgi?id=177412

Reviewed by Yusuke Suzuki.

This test was poorly designed since failing it would cause the vm
to inifinite loop. I've fixed it locally and will fix it on github pending
the results of next weeks tc39 meeting.

* test262.yaml:
* test262/test/language/statements/for-of/iterator-next-reference.js:

Modified Paths

Diff

Modified: trunk/JSTests/ChangeLog (222427 => 222428)


--- trunk/JSTests/ChangeLog	2017-09-23 21:05:52 UTC (rev 222427)
+++ trunk/JSTests/ChangeLog	2017-09-24 00:46:49 UTC (rev 222428)
@@ -1,3 +1,17 @@
+2017-09-23  Keith Miller  <[email protected]>
+
+        Fix infinite looping test262 test
+        https://bugs.webkit.org/show_bug.cgi?id=177412
+
+        Reviewed by Yusuke Suzuki.
+
+        This test was poorly designed since failing it would cause the vm
+        to inifinite loop. I've fixed it locally and will fix it on github pending
+        the results of next weeks tc39 meeting.
+
+        * test262.yaml:
+        * test262/test/language/statements/for-of/iterator-next-reference.js:
+
 2017-09-23  Joseph Pecoraro  <[email protected]>
 
         test262: $.agent became $262.agent in test262 update

Modified: trunk/JSTests/test262/test/language/statements/for-of/iterator-next-reference.js (222427 => 222428)


--- trunk/JSTests/test262/test/language/statements/for-of/iterator-next-reference.js	2017-09-23 21:05:52 UTC (rev 222427)
+++ trunk/JSTests/test262/test/language/statements/for-of/iterator-next-reference.js	2017-09-24 00:46:49 UTC (rev 222428)
@@ -23,6 +23,9 @@
 for (var x of iterable) {
   assert.sameValue(x, 45);
 
+  if (iterationCount != 0)
+    $ERROR("iterated too many times");
+
   iterator.next = function() {
     invocationCount++;
 

Modified: trunk/JSTests/test262.yaml (222427 => 222428)


--- trunk/JSTests/test262.yaml	2017-09-23 21:05:52 UTC (rev 222427)
+++ trunk/JSTests/test262.yaml	2017-09-24 00:46:49 UTC (rev 222428)
@@ -104690,9 +104690,9 @@
 - path: test262/test/language/statements/for-of/iterator-next-error.js
   cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
 - path: test262/test/language/statements/for-of/iterator-next-reference.js
-  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
+  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
 - path: test262/test/language/statements/for-of/iterator-next-reference.js
-  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
+  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
 - path: test262/test/language/statements/for-of/iterator-next-result-done-attr.js
   cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
 - path: test262/test/language/statements/for-of/iterator-next-result-done-attr.js
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to