Title: [222439] trunk/Tools
- Revision
- 222439
- Author
- [email protected]
- Date
- 2017-09-24 22:57:01 -0700 (Sun, 24 Sep 2017)
Log Message
[GTK] Incremental builds fail every time Web Inspector icons are removed
https://bugs.webkit.org/show_bug.cgi?id=177349
Patch by Fujii Hironori <[email protected]> on 2017-09-24
Reviewed by Carlos Garcia Campos.
Removing GTK WebInspector image files always breaks the GTK and
WPE ports incremental builds.
* Scripts/webkitdirs.pm:
(shouldRemoveCMakeCache): Check the timestamp of
Source/WebInspectorUI/UserInterface/Images/gtk directory if
isGtk() or isWPE().
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (222438 => 222439)
--- trunk/Tools/ChangeLog 2017-09-25 03:02:24 UTC (rev 222438)
+++ trunk/Tools/ChangeLog 2017-09-25 05:57:01 UTC (rev 222439)
@@ -1,3 +1,18 @@
+2017-09-24 Fujii Hironori <[email protected]>
+
+ [GTK] Incremental builds fail every time Web Inspector icons are removed
+ https://bugs.webkit.org/show_bug.cgi?id=177349
+
+ Reviewed by Carlos Garcia Campos.
+
+ Removing GTK WebInspector image files always breaks the GTK and
+ WPE ports incremental builds.
+
+ * Scripts/webkitdirs.pm:
+ (shouldRemoveCMakeCache): Check the timestamp of
+ Source/WebInspectorUI/UserInterface/Images/gtk directory if
+ isGtk() or isWPE().
+
2017-09-24 Joanmarie Diggs <[email protected]>
[ATK] Object attributes are missing for ARIA live region roles
Modified: trunk/Tools/Scripts/webkitdirs.pm (222438 => 222439)
--- trunk/Tools/Scripts/webkitdirs.pm 2017-09-25 03:02:24 UTC (rev 222438)
+++ trunk/Tools/Scripts/webkitdirs.pm 2017-09-25 05:57:01 UTC (rev 222439)
@@ -1969,6 +1969,13 @@
return 1;
}
+ if (isGtk() or isWPE()) {
+ my $gtkImageDircetory = File::Spec->catdir(sourceDir(), "Source", "WebInspectorUI", "UserInterface", "Images", "gtk");
+ if ($cacheFileModifiedTime < stat($gtkImageDircetory)->mtime) {
+ return 1;
+ }
+ }
+
if(isAnyWindows()) {
my $winConfiguration = File::Spec->catdir(sourceDir(), "Source", "cmake", "OptionsWin.cmake");
if ($cacheFileModifiedTime < stat($winConfiguration)->mtime) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
