Title: [222442] trunk/Tools
- Revision
- 222442
- Author
- [email protected]
- Date
- 2017-09-25 05:21:47 -0700 (Mon, 25 Sep 2017)
Log Message
REGRESSION(r222160) [GTK] [Debug] Internal compiler error on the buildbot (huge memory usage by GCC)
https://bugs.webkit.org/show_bug.cgi?id=177223
Reviewed by Carlos Garcia Campos.
When the user environment sets the variable NUMBER_OF_PROCESSORS
this should be passed down to the build system (ninja or make) always.
Playing with the number of this variable is needed when using icecc
(as you usually want to launch more parallel build process than your
number of cores), or when you want to limit the number of parallel
build process for hardware capacity reasons.
* Scripts/build-webkit:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (222441 => 222442)
--- trunk/Tools/ChangeLog 2017-09-25 08:39:48 UTC (rev 222441)
+++ trunk/Tools/ChangeLog 2017-09-25 12:21:47 UTC (rev 222442)
@@ -1,3 +1,20 @@
+2017-09-25 Carlos Alberto Lopez Perez <[email protected]>
+
+ REGRESSION(r222160) [GTK] [Debug] Internal compiler error on the buildbot (huge memory usage by GCC)
+ https://bugs.webkit.org/show_bug.cgi?id=177223
+
+ Reviewed by Carlos Garcia Campos.
+
+ When the user environment sets the variable NUMBER_OF_PROCESSORS
+ this should be passed down to the build system (ninja or make) always.
+
+ Playing with the number of this variable is needed when using icecc
+ (as you usually want to launch more parallel build process than your
+ number of cores), or when you want to limit the number of parallel
+ build process for hardware capacity reasons.
+
+ * Scripts/build-webkit:
+
2017-09-24 Fujii Hironori <[email protected]>
[GTK] Incremental builds fail every time Web Inspector icons are removed
Modified: trunk/Tools/Scripts/build-webkit (222441 => 222442)
--- trunk/Tools/Scripts/build-webkit 2017-09-25 08:39:48 UTC (rev 222441)
+++ trunk/Tools/Scripts/build-webkit 2017-09-25 12:21:47 UTC (rev 222442)
@@ -239,10 +239,10 @@
}
if (isCMakeBuild() && !isAnyWindows()) {
- if (!canUseNinja()) {
- # By default we build using all of the available CPUs.
- # Ninja will automatically determine the number of jobs to run in parallel,
- # so don't override the number of jobs if building with Ninja.
+ if (!canUseNinja() || defined($ENV{NUMBER_OF_PROCESSORS})) {
+ # If the user environment is not setting a specific number of process,
+ # then don't pass the number of jobs to Ninja. Because Ninja will
+ # automatically determine the number of jobs to run in parallel.
$makeArgs .= ($makeArgs ? " " : "") . "-j" . numberOfCPUs() if $makeArgs !~ /-j\s*\d+/;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
