[webkit-changes] [222496] trunk/Source/WebCore

Tue, 26 Sep 2017 01:13:59 -0700

Title: [222496] trunk/Source/WebCore
Revision
222496
Author
[email protected]
Date
2017-09-26 01:13:38 -0700 (Tue, 26 Sep 2017)

Log Message

Update compressedTexImage3D to match the signature in the specification.
https://bugs.webkit.org/show_bug.cgi?id=177431

Reviewed by Sam Weinig.

No new tests: not much point in adding tests now; this method doesn't
do anything anyway.

* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::compressedTexImage3D):
* html/canvas/WebGL2RenderingContext.h:
* html/canvas/WebGL2RenderingContext.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (222495 => 222496)


--- trunk/Source/WebCore/ChangeLog	2017-09-26 07:07:45 UTC (rev 222495)
+++ trunk/Source/WebCore/ChangeLog	2017-09-26 08:13:38 UTC (rev 222496)
@@ -1,3 +1,18 @@
+2017-09-26  Ms2ger  <[email protected]>
+
+        Update compressedTexImage3D to match the signature in the specification.
+        https://bugs.webkit.org/show_bug.cgi?id=177431
+
+        Reviewed by Sam Weinig.
+
+        No new tests: not much point in adding tests now; this method doesn't
+        do anything anyway.
+
+        * html/canvas/WebGL2RenderingContext.cpp:
+        (WebCore::WebGL2RenderingContext::compressedTexImage3D):
+        * html/canvas/WebGL2RenderingContext.h:
+        * html/canvas/WebGL2RenderingContext.idl:
+
 2017-09-25  Timothy Horton  <[email protected]>
 
         Fix the macOS WebCore CMake build

Modified: trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp (222495 => 222496)


--- trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp	2017-09-26 07:07:45 UTC (rev 222495)
+++ trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp	2017-09-26 08:13:38 UTC (rev 222496)
@@ -495,10 +495,14 @@
 {
 }
 
-void WebGL2RenderingContext::compressedTexImage3D(GC3Denum, GC3Dint, GC3Denum, GC3Dsizei, GC3Dsizei, GC3Dsizei, GC3Dint, GC3Dsizei, RefPtr<ArrayBufferView>&&)
+void WebGL2RenderingContext::compressedTexImage3D(GC3Denum, GC3Dint, GC3Denum, GC3Dsizei, GC3Dsizei, GC3Dsizei, GC3Dint, GC3Dsizei, GC3Dint64)
 {
 }
 
+void WebGL2RenderingContext::compressedTexImage3D(GC3Denum, GC3Dint, GC3Denum, GC3Dsizei, GC3Dsizei, GC3Dsizei, GC3Dint, ArrayBufferView&, GC3Duint, GC3Duint)
+{
+}
+
 void WebGL2RenderingContext::compressedTexSubImage3D(GC3Denum, GC3Dint, GC3Dint, GC3Dint, GC3Dint, GC3Dsizei, GC3Dsizei, GC3Dsizei, GC3Denum, GC3Dsizei, RefPtr<ArrayBufferView>&&)
 {
 }

Modified: trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h (222495 => 222496)


--- trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h	2017-09-26 07:07:45 UTC (rev 222495)
+++ trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h	2017-09-26 08:13:38 UTC (rev 222496)
@@ -72,7 +72,8 @@
     void texSubImage3D(GC3Denum target, GC3Dint level, GC3Dint xoffset, GC3Dint yoffset, GC3Dint zoffset, GC3Denum format, GC3Denum type, TexImageSource&&);
 
     void copyTexSubImage3D(GC3Denum target, GC3Dint level, GC3Dint xoffset, GC3Dint yoffset, GC3Dint zoffset, GC3Dint x, GC3Dint y, GC3Dsizei width, GC3Dsizei height);
-    void compressedTexImage3D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Dint border, GC3Dsizei imageSize, RefPtr<ArrayBufferView>&& data);
+    void compressedTexImage3D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Dint border, GC3Dsizei imageSize, GC3Dint64 offset);
+    void compressedTexImage3D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Dint border, ArrayBufferView& srcData, GC3Duint srcOffset, GC3Duint srcLengthOverride);
     void compressedTexSubImage3D(GC3Denum target, GC3Dint level, GC3Dint xoffset, GC3Dint yoffset, GC3Dint zoffset, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Denum format, GC3Dsizei imageSize, RefPtr<ArrayBufferView>&& data);
     
     // Programs and shaders

Modified: trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.idl (222495 => 222496)


--- trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.idl	2017-09-26 07:07:45 UTC (rev 222495)
+++ trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.idl	2017-09-26 08:13:38 UTC (rev 222496)
@@ -369,7 +369,9 @@
     void texSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLenum format, GLenum type, TexImageSource source);
 
     void copyTexSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLint x, GLint y, GLsizei width, GLsizei height);
-    void compressedTexImage3D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLsizei depth, GLint border, GLsizei imageSize, ArrayBufferView? data);
+
+    void compressedTexImage3D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLsizei depth, GLint border, GLsizei imageSize, GLintptr offset);
+    void compressedTexImage3D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLsizei depth, GLint border, ArrayBufferView srcData, optional GLuint srcOffset = 0, optional GLuint srcLengthOverride = 0);
     void compressedTexSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth, GLenum format, GLsizei imageSize, ArrayBufferView? data);
 
     /* Programs and shaders */

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to