Title: [222535] trunk
- Revision
- 222535
- Author
- [email protected]
- Date
- 2017-09-26 16:59:12 -0700 (Tue, 26 Sep 2017)
Log Message
Unreviewed, rolling out r222525.
This caused a consistent failure in the test
inspector/dom/getAccessibilityPropertiesForNode.html .
Reverted changeset:
"AX: Several ARIA roles with presentational children are
exposing children"
https://bugs.webkit.org/show_bug.cgi?id=177502
http://trac.webkit.org/changeset/222525
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (222534 => 222535)
--- trunk/LayoutTests/ChangeLog 2017-09-26 23:48:14 UTC (rev 222534)
+++ trunk/LayoutTests/ChangeLog 2017-09-26 23:59:12 UTC (rev 222535)
@@ -1,3 +1,17 @@
+2017-09-26 Matt Lewis <[email protected]>
+
+ Unreviewed, rolling out r222525.
+
+ This caused a consistent failure in the test
+ inspector/dom/getAccessibilityPropertiesForNode.html .
+
+ Reverted changeset:
+
+ "AX: Several ARIA roles with presentational children are
+ exposing children"
+ https://bugs.webkit.org/show_bug.cgi?id=177502
+ http://trac.webkit.org/changeset/222525
+
2017-09-26 Joanmarie Diggs <[email protected]>
AX: ARIA grids claim to be multiselectable even with aria-multiselectable is set to false
Deleted: trunk/LayoutTests/accessibility/presentational-children-expected.txt (222534 => 222535)
--- trunk/LayoutTests/accessibility/presentational-children-expected.txt 2017-09-26 23:48:14 UTC (rev 222534)
+++ trunk/LayoutTests/accessibility/presentational-children-expected.txt 2017-09-26 23:59:12 UTC (rev 222535)
@@ -1,23 +0,0 @@
-This tests that roles with children presentational true report no children.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-button childrenCount: 0
-checkbox childrenCount: 0
-img childrenCount: 0
-math childrenCount: 0
-menuitemcheckbox childrenCount: 0
-menuitemradio childrenCount: 0
-option childrenCount: 0
-progressbar childrenCount: 0
-radio childrenCount: 0
-scrollbar childrenCount: 0
-separator childrenCount: 0
-slider childrenCount: 0
-switch childrenCount: 0
-tab childrenCount: 0
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/accessibility/presentational-children.html (222534 => 222535)
--- trunk/LayoutTests/accessibility/presentational-children.html 2017-09-26 23:48:14 UTC (rev 222534)
+++ trunk/LayoutTests/accessibility/presentational-children.html 2017-09-26 23:59:12 UTC (rev 222535)
@@ -1,46 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src=""
-</head>
-<body id="body">
-<div id="content">
- <div role="button" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- <div role="checkbox" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- <div role="img" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- <div role="math" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- <div role="menu">
- <div role="menuitemcheckbox" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- <div role="menuitemradio" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- </div>
- <div role="listbox">
- <div role="option" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- </div>
- <div role="progressbar" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- <div role="radio" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- <div role="scrollbar" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- <div role="separator" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- <div role="slider" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- <div role="switch" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- <div role="tablist">
- <div role="tab" tabindex="0" class="ex"><div>a</div><div>b</div></div>
- </div>
-</div>
-<p id="description"></p>
-<div id="console"></div>
-<script>
- description("This tests that roles with children presentational true report no children.");
- if (window.accessibilityController) {
- var elements = document.querySelectorAll(".ex");
- var count = elements.length;
- for (var i = 0; i < count; i++) {
- var el = elements[i];
- el.focus();
- debug(el.getAttribute("role") + " childrenCount: " + accessibilityController.focusedElement.childrenCount);
- }
- document.getElementById("content").style.visibility = "hidden";
- }
-</script>
-<script src=""
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (222534 => 222535)
--- trunk/Source/WebCore/ChangeLog 2017-09-26 23:48:14 UTC (rev 222534)
+++ trunk/Source/WebCore/ChangeLog 2017-09-26 23:59:12 UTC (rev 222535)
@@ -1,3 +1,17 @@
+2017-09-26 Matt Lewis <[email protected]>
+
+ Unreviewed, rolling out r222525.
+
+ This caused a consistent failure in the test
+ inspector/dom/getAccessibilityPropertiesForNode.html .
+
+ Reverted changeset:
+
+ "AX: Several ARIA roles with presentational children are
+ exposing children"
+ https://bugs.webkit.org/show_bug.cgi?id=177502
+ http://trac.webkit.org/changeset/222525
+
2017-09-26 Daniel Bates <[email protected]>
Make fontToUse() a member function of InlineTextBox
Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (222534 => 222535)
--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2017-09-26 23:48:14 UTC (rev 222534)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2017-09-26 23:59:12 UTC (rev 222535)
@@ -382,15 +382,7 @@
case ScrollBarRole:
case ProgressIndicatorRole:
case SwitchRole:
- case MenuItemCheckboxRole:
- case MenuItemRadioRole:
- case SplitterRole:
return false;
- case DocumentMathRole:
-#if ENABLE(MATHML)
- return node()->isMathMLElement();
-#endif
- return false;
default:
return true;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
