Title: [100181] trunk/Source/WebCore
- Revision
- 100181
- Author
- [email protected]
- Date
- 2011-11-14 12:56:15 -0800 (Mon, 14 Nov 2011)
Log Message
SecurityContext::isSecureTransitionTo should not refer to empty security origins
https://bugs.webkit.org/show_bug.cgi?id=72277
Reviewed by Eric Seidel.
Now that we're tracking the "failed to initialized SecurityOrigin"
state explicitly, we should use that to determine whether we can make a
secure transition.
* dom/SecurityContext.cpp:
(WebCore::SecurityContext::isSecureTransitionTo):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (100180 => 100181)
--- trunk/Source/WebCore/ChangeLog 2011-11-14 20:50:14 UTC (rev 100180)
+++ trunk/Source/WebCore/ChangeLog 2011-11-14 20:56:15 UTC (rev 100181)
@@ -1,3 +1,17 @@
+2011-11-14 Adam Barth <[email protected]>
+
+ SecurityContext::isSecureTransitionTo should not refer to empty security origins
+ https://bugs.webkit.org/show_bug.cgi?id=72277
+
+ Reviewed by Eric Seidel.
+
+ Now that we're tracking the "failed to initialized SecurityOrigin"
+ state explicitly, we should use that to determine whether we can make a
+ secure transition.
+
+ * dom/SecurityContext.cpp:
+ (WebCore::SecurityContext::isSecureTransitionTo):
+
2011-11-14 Vincent Scheib <[email protected]>
Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
Modified: trunk/Source/WebCore/dom/SecurityContext.cpp (100180 => 100181)
--- trunk/Source/WebCore/dom/SecurityContext.cpp 2011-11-14 20:50:14 UTC (rev 100180)
+++ trunk/Source/WebCore/dom/SecurityContext.cpp 2011-11-14 20:56:15 UTC (rev 100181)
@@ -56,8 +56,10 @@
bool SecurityContext::isSecureTransitionTo(const KURL& url) const
{
- // This origin represents a new window created by the application.
- if (securityOrigin()->isEmpty())
+ // If we haven't initialized our security origin by now, this is probably
+ // a new window created via the API (i.e., that lacks an origin and lacks
+ // a place to inherit the origin from).
+ if (!haveInitializedSecurityOrigin())
return true;
RefPtr<SecurityOrigin> other = SecurityOrigin::create(url);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
