Title: [100184] trunk/Tools
- Revision
- 100184
- Author
- [email protected]
- Date
- 2011-11-14 13:45:52 -0800 (Mon, 14 Nov 2011)
Log Message
[Chromium] build-webkit silently drops the features flags
https://bugs.webkit.org/show_bug.cgi?id=72293
Reviewed by Tony Chang.
Chromium still ignores @features but now we give a warning!
* Scripts/build-webkit: Check if one of the features is different
from the default and print a warning in this case.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (100183 => 100184)
--- trunk/Tools/ChangeLog 2011-11-14 21:21:43 UTC (rev 100183)
+++ trunk/Tools/ChangeLog 2011-11-14 21:45:52 UTC (rev 100184)
@@ -1,3 +1,15 @@
+2011-11-14 Julien Chaffraix <[email protected]>
+
+ [Chromium] build-webkit silently drops the features flags
+ https://bugs.webkit.org/show_bug.cgi?id=72293
+
+ Reviewed by Tony Chang.
+
+ Chromium still ignores @features but now we give a warning!
+
+ * Scripts/build-webkit: Check if one of the features is different
+ from the default and print a warning in this case.
+
2011-11-14 David Kilzer <[email protected]>
run-leaks does not work on Lion?
Modified: trunk/Tools/Scripts/build-webkit (100183 => 100184)
--- trunk/Tools/Scripts/build-webkit 2011-11-14 21:21:43 UTC (rev 100183)
+++ trunk/Tools/Scripts/build-webkit 2011-11-14 21:45:52 UTC (rev 100184)
@@ -594,6 +594,21 @@
}
if (isChromium()) {
+ # Currently chromium does not honour the features passed to build-webkit.
+ # Until this is solved, we issue a warning about that.
+ foreach (@features) {
+ if (${$_->{value}} ne $_->{default}) {
+ print "\n";
+ print "===========================================================\n";
+ print " Chromium does not honor the features passed to build-webkit.\n";
+ print " The preferred way is to set up your overrides in ~/.gyp/include.gypi.\n";
+ print " See https://trac.webkit.org/wiki/Chromium#Buildingwithfeaturedefines\n";
+ print " on how to do that.\n";
+ print "===========================================================\n";
+ last;
+ }
+ }
+
@options = @ARGV;
# Chromium doesn't build by project directories.
@projects = ();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
