Title: [222616] trunk/LayoutTests
- Revision
- 222616
- Author
- [email protected]
- Date
- 2017-09-28 10:56:16 -0700 (Thu, 28 Sep 2017)
Log Message
[mac-wk1] Layout test webrtc/datachannel/bufferedAmountLowThreshold tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=177462
Patch by Youenn Fablet <[email protected]> on 2017-09-28
Reviewed by Alex Christensen.
* webrtc/datachannel/bufferedAmountLowThreshold-default.html: Filling buffer until bufferedAmount is bug enough to trigger bufferedAmountLow event.
* webrtc/datachannel/bufferedAmountLowThreshold-expected.txt:
* webrtc/datachannel/bufferedAmountLowThreshold.html: Removing test that is inherently flaky on bots that are not fast enough
to continue filling the webrtc data channel buffer.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (222615 => 222616)
--- trunk/LayoutTests/ChangeLog 2017-09-28 17:37:33 UTC (rev 222615)
+++ trunk/LayoutTests/ChangeLog 2017-09-28 17:56:16 UTC (rev 222616)
@@ -1,3 +1,15 @@
+2017-09-28 Youenn Fablet <[email protected]>
+
+ [mac-wk1] Layout test webrtc/datachannel/bufferedAmountLowThreshold tests are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=177462
+
+ Reviewed by Alex Christensen.
+
+ * webrtc/datachannel/bufferedAmountLowThreshold-default.html: Filling buffer until bufferedAmount is bug enough to trigger bufferedAmountLow event.
+ * webrtc/datachannel/bufferedAmountLowThreshold-expected.txt:
+ * webrtc/datachannel/bufferedAmountLowThreshold.html: Removing test that is inherently flaky on bots that are not fast enough
+ to continue filling the webrtc data channel buffer.
+
2017-09-28 Chris Dumez <[email protected]>
Add support for <link rel=preconnect>
Modified: trunk/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-default.html (222615 => 222616)
--- trunk/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-default.html 2017-09-28 17:37:33 UTC (rev 222615)
+++ trunk/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-default.html 2017-09-28 17:56:16 UTC (rev 222616)
@@ -28,9 +28,8 @@
function sendMessages(channel)
{
- channel.send(longString);
- channel.send(longString);
- channel.send(longString);
+ while(channel.bufferedAmount < 1000)
+ channel.send(longString);
}
function receiveMessages(event) {
Modified: trunk/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-expected.txt (222615 => 222616)
--- trunk/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-expected.txt 2017-09-28 17:37:33 UTC (rev 222615)
+++ trunk/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-expected.txt 2017-09-28 17:56:16 UTC (rev 222616)
@@ -1,4 +1,3 @@
PASS Large buffer threshold reached
-PASS Medium buffer threshold not reached
Modified: trunk/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold.html (222615 => 222616)
--- trunk/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold.html 2017-09-28 17:37:33 UTC (rev 222615)
+++ trunk/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold.html 2017-09-28 17:56:16 UTC (rev 222616)
@@ -66,29 +66,6 @@
closeDataChannels();
});
}, "Large buffer threshold reached");
-
-promise_test((test) => {
- counter = 0;
- var gotEvent = false;
- return new Promise((resolve, reject) => {
- createConnections((localConnection) => {
- localChannel = localConnection.createDataChannel('sendDataChannel');
- localChannel._onopen_ = () => {
- sendContinuouslyMessages(localChannel);
- localChannel._onbufferedamountlow_ = () => {
- reject();
- }
- };
- localChannel.bufferedAmountLowThreshold = 10;
- }, (remoteConnection) => {
- remoteConnection._ondatachannel_ = (event) => {
- remoteChannel = event.channel;
- remoteChannel._onmessage_ = receiveMessages;
- };
- });
- setTimeout(resolve, 50);
- });
-}, "Medium buffer threshold not reached");
</script>
</body>
</html>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
