Title: [222661] trunk/Source/WebInspectorUI
- Revision
- 222661
- Author
- [email protected]
- Date
- 2017-09-29 12:47:28 -0700 (Fri, 29 Sep 2017)
Log Message
Web Inspector: Uncaught exception with populate find keyboard shortcut
https://bugs.webkit.org/show_bug.cgi?id=177672
Patch by Joseph Pecoraro <[email protected]> on 2017-09-29
Reviewed by Matt Baker.
* UserInterface/Base/Main.js:
The focusedContentView can be null so bail if that is the case.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (222660 => 222661)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-09-29 19:32:49 UTC (rev 222660)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-09-29 19:47:28 UTC (rev 222661)
@@ -1,3 +1,13 @@
+2017-09-29 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Uncaught exception with populate find keyboard shortcut
+ https://bugs.webkit.org/show_bug.cgi?id=177672
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Base/Main.js:
+ The focusedContentView can be null so bail if that is the case.
+
2017-09-28 Devin Rousso <[email protected]>
WebInspector: Uncaught Exception: TypeError: this._delegate.completionControllerCSSFunctionValuesNeeded is not a function.
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (222660 => 222661)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-09-29 19:32:49 UTC (rev 222660)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-09-29 19:47:28 UTC (rev 222661)
@@ -2007,6 +2007,9 @@
WI._populateFind = function(event)
{
let focusedContentView = this._focusedContentView();
+ if (!focusedContentView)
+ return;
+
if (focusedContentView.supportsCustomFindBanner) {
focusedContentView.handlePopulateFindShortcut();
return;
@@ -2022,6 +2025,9 @@
WI._findNext = function(event)
{
let focusedContentView = this._focusedContentView();
+ if (!focusedContentView)
+ return;
+
if (focusedContentView.supportsCustomFindBanner) {
focusedContentView.handleFindNextShortcut();
return;
@@ -2037,6 +2043,9 @@
WI._findPrevious = function(event)
{
let focusedContentView = this._focusedContentView();
+ if (!focusedContentView)
+ return;
+
if (focusedContentView.supportsCustomFindBanner) {
focusedContentView.handleFindPreviousShortcut();
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
