Title: [222733] trunk/Source/WebCore
- Revision
- 222733
- Author
- [email protected]
- Date
- 2017-10-02 12:34:42 -0700 (Mon, 02 Oct 2017)
Log Message
Addressing post-review comments after r222621
https://bugs.webkit.org/show_bug.cgi?id=177610
Reviewed by Darin Adler.
* rendering/RenderMenuList.cpp:
(RenderMenuList::didUpdateActiveOption):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (222732 => 222733)
--- trunk/Source/WebCore/ChangeLog 2017-10-02 19:23:38 UTC (rev 222732)
+++ trunk/Source/WebCore/ChangeLog 2017-10-02 19:34:42 UTC (rev 222733)
@@ -1,3 +1,13 @@
+2017-10-02 Zalan Bujtas <[email protected]>
+
+ Addressing post-review comments after r222621
+ https://bugs.webkit.org/show_bug.cgi?id=177610
+
+ Reviewed by Darin Adler.
+
+ * rendering/RenderMenuList.cpp:
+ (RenderMenuList::didUpdateActiveOption):
+
2017-10-02 Daniel Bates <[email protected]>
Remove length argument from TextPainter::paint()
Modified: trunk/Source/WebCore/rendering/RenderMenuList.cpp (222732 => 222733)
--- trunk/Source/WebCore/rendering/RenderMenuList.cpp 2017-10-02 19:23:38 UTC (rev 222732)
+++ trunk/Source/WebCore/rendering/RenderMenuList.cpp 2017-10-02 19:34:42 UTC (rev 222733)
@@ -432,7 +432,7 @@
if (!axCache)
return;
- if (m_lastActiveIndex && *m_lastActiveIndex == optionIndex)
+ if (m_lastActiveIndex == optionIndex)
return;
m_lastActiveIndex = optionIndex;
@@ -440,7 +440,7 @@
if (listIndex < 0 || listIndex >= static_cast<int>(selectElement().listItems().size()))
return;
- if (AccessibilityMenuList* menuList = downcast<AccessibilityMenuList>(axCache->get(this)))
+ if (auto* menuList = downcast<AccessibilityMenuList>(axCache->get(this)))
menuList->didUpdateActiveOption(optionIndex);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
