Title: [222736] trunk/Source/WebKit
- Revision
- 222736
- Author
- [email protected]
- Date
- 2017-10-02 12:49:55 -0700 (Mon, 02 Oct 2017)
Log Message
REGRESSION: API tests WebKit.ProcessDidTerminateRequestedByClient and WebKit.ProcessDidTerminateWithReasonCrash are timing out
https://bugs.webkit.org/show_bug.cgi?id=177764
Reviewed by Chris Dumez.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageNavigationClient):
I shouldn't have reverted the A API telling the listener to continue if there's no client function.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (222735 => 222736)
--- trunk/Source/WebKit/ChangeLog 2017-10-02 19:48:37 UTC (rev 222735)
+++ trunk/Source/WebKit/ChangeLog 2017-10-02 19:49:55 UTC (rev 222736)
@@ -1,3 +1,14 @@
+2017-10-02 Alex Christensen <[email protected]>
+
+ REGRESSION: API tests WebKit.ProcessDidTerminateRequestedByClient and WebKit.ProcessDidTerminateWithReasonCrash are timing out
+ https://bugs.webkit.org/show_bug.cgi?id=177764
+
+ Reviewed by Chris Dumez.
+
+ * UIProcess/API/C/WKPage.cpp:
+ (WKPageSetPageNavigationClient):
+ I shouldn't have reverted the A API telling the listener to continue if there's no client function.
+
2017-10-02 Carlos Garcia Campos <[email protected]>
[WPE][GTK] Crash in webkit_web_resource_get_data_finish()
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp (222735 => 222736)
--- trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp 2017-10-02 19:48:37 UTC (rev 222735)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp 2017-10-02 19:49:55 UTC (rev 222736)
@@ -2142,15 +2142,19 @@
private:
void decidePolicyForNavigationAction(WebPageProxy& page, Ref<API::NavigationAction>&& navigationAction, Ref<WebKit::WebFramePolicyListenerProxy>&& listener, API::Object* userData) final
{
- if (!m_client.decidePolicyForNavigationAction)
+ if (!m_client.decidePolicyForNavigationAction) {
+ listener->use({ });
return;
+ }
m_client.decidePolicyForNavigationAction(toAPI(&page), toAPI(navigationAction.ptr()), toAPI(listener.ptr()), toAPI(userData), m_client.base.clientInfo);
}
void decidePolicyForNavigationResponse(WebPageProxy& page, API::NavigationResponse& navigationResponse, Ref<WebKit::WebFramePolicyListenerProxy>&& listener, API::Object* userData) override
{
- if (!m_client.decidePolicyForNavigationResponse)
+ if (!m_client.decidePolicyForNavigationResponse) {
+ listener->use({ });
return;
+ }
m_client.decidePolicyForNavigationResponse(toAPI(&page), toAPI(&navigationResponse), toAPI(listener.ptr()), toAPI(userData), m_client.base.clientInfo);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
