Title: [222742] trunk/Source/WebInspectorUI
- Revision
- 222742
- Author
- [email protected]
- Date
- 2017-10-02 14:31:35 -0700 (Mon, 02 Oct 2017)
Log Message
Web Inspector: Ensure popovers are not malformed on window resize.
https://bugs.webkit.org/show_bug.cgi?id=177771
Patch by Ross Kirsling <[email protected]> on 2017-10-02
Reviewed by Joseph Pecoraro.
* UserInterface/Views/Popover.js:
Ensure stale `arrow-*` CSS classes are removed on update, even if our content didn't change.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (222741 => 222742)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-10-02 21:31:16 UTC (rev 222741)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-10-02 21:31:35 UTC (rev 222742)
@@ -1,3 +1,13 @@
+2017-10-02 Ross Kirsling <[email protected]>
+
+ Web Inspector: Ensure popovers are not malformed on window resize.
+ https://bugs.webkit.org/show_bug.cgi?id=177771
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/Popover.js:
+ Ensure stale `arrow-*` CSS classes are removed on update, even if our content didn't change.
+
2017-10-02 Joseph Pecoraro <[email protected]>
Web Inspector: Include Beacon and Ping requests in Network tab
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js (222741 => 222742)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js 2017-10-02 21:31:16 UTC (rev 222741)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js 2017-10-02 21:31:35 UTC (rev 222742)
@@ -211,6 +211,9 @@
this._dismissing = false;
+ if (this._edge !== null)
+ this._element.classList.remove(this._cssClassNameForEdge());
+
if (this._contentNeedsUpdate) {
// Reset CSS properties on element so that the element may be sized to fit its content.
this._element.style.removeProperty("left");
@@ -217,8 +220,6 @@
this._element.style.removeProperty("top");
this._element.style.removeProperty("width");
this._element.style.removeProperty("height");
- if (this._edge !== null)
- this._element.classList.remove(this._cssClassNameForEdge());
// Add the content in place of the wrapper to get the raw metrics.
this._container.replaceWith(this._content);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
