Title: [222762] trunk/Source/WebInspectorUI
Revision
222762
Author
[email protected]
Date
2017-10-02 17:29:00 -0700 (Mon, 02 Oct 2017)

Log Message

Web Inspector: Escape more characters in posix string conversion
https://bugs.webkit.org/show_bug.cgi?id=177761
<rdar://problem/34506832>

Patch by Joseph Pecoraro <[email protected]> on 2017-10-02
Reviewed by Brian Burg.

* UserInterface/Models/Resource.js:
(WI.Resource.prototype.generateCURLCommand.escapeStringPosix):
Escape '!' to '\041' in posix strings ($'...') since '!' may have special behavior at times.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (222761 => 222762)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-10-03 00:22:17 UTC (rev 222761)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-10-03 00:29:00 UTC (rev 222762)
@@ -1,3 +1,15 @@
+2017-10-02  Joseph Pecoraro  <[email protected]>
+
+        Web Inspector: Escape more characters in posix string conversion
+        https://bugs.webkit.org/show_bug.cgi?id=177761
+        <rdar://problem/34506832>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Models/Resource.js:
+        (WI.Resource.prototype.generateCURLCommand.escapeStringPosix):
+        Escape '!' to '\041' in posix strings ($'...') since '!' may have special behavior at times.
+
 2017-10-02  Ross Kirsling  <[email protected]>
 
         Web Inspector: Selecting child layers with keyboard causes Compositing Reason popover to become misaligned

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js (222761 => 222762)


--- trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js	2017-10-03 00:22:17 UTC (rev 222761)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js	2017-10-03 00:29:00 UTC (rev 222762)
@@ -962,6 +962,7 @@
                                  .replace(/'/g, "\\'")
                                  .replace(/\n/g, "\\n")
                                  .replace(/\r/g, "\\r")
+                                 .replace(/!/g, "\\041")
                                  .replace(/[^\x20-\x7E]/g, escapeCharacter) + "'";
             } else {
                 // Use single quote syntax.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to