Title: [222786] trunk/Source/WebCore
Revision
222786
Author
[email protected]
Date
2017-10-03 10:29:12 -0700 (Tue, 03 Oct 2017)

Log Message

Unreviewed test fix after r222779.

* testing/cocoa/WebArchiveDumpSupport.mm:
(WebCoreTestSupport::createCFURLResponseFromResponseData): Setting NSSecureCoding in this test code should be
done based on build system, just like it is in the actual WebArchive handling code.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (222785 => 222786)


--- trunk/Source/WebCore/ChangeLog	2017-10-03 16:26:14 UTC (rev 222785)
+++ trunk/Source/WebCore/ChangeLog	2017-10-03 17:29:12 UTC (rev 222786)
@@ -1,3 +1,11 @@
+2017-10-03  Brent Fulgham  <[email protected]>
+
+        Unreviewed test fix after r222779.
+
+        * testing/cocoa/WebArchiveDumpSupport.mm:
+        (WebCoreTestSupport::createCFURLResponseFromResponseData): Setting NSSecureCoding in this test code should be
+        done based on build system, just like it is in the actual WebArchive handling code.
+
 2017-10-03  Youenn Fablet  <[email protected]>
 
         Clean-up RealtimeIncomingVideoSource

Modified: trunk/Source/WebCore/testing/cocoa/WebArchiveDumpSupport.mm (222785 => 222786)


--- trunk/Source/WebCore/testing/cocoa/WebArchiveDumpSupport.mm	2017-10-03 16:26:14 UTC (rev 222785)
+++ trunk/Source/WebCore/testing/cocoa/WebArchiveDumpSupport.mm	2017-10-03 17:29:12 UTC (rev 222786)
@@ -41,13 +41,14 @@
 static CFURLResponseRef createCFURLResponseFromResponseData(CFDataRef responseData)
 {
     RetainPtr<NSKeyedUnarchiver> unarchiver = adoptNS([[NSKeyedUnarchiver alloc] initForReadingWithData:(NSData *)responseData]);
+    NSURLResponse *response;
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || PLATFORM(IOS)
+    // Because of <rdar://problem/34063313> we can't use this for decoding in older OS's.
     [unarchiver setRequiresSecureCoding:YES];
-    NSURLResponse *response;
     @try {
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || PLATFORM(IOS)
-        // Because of <rdar://problem/34063313> we can't use this for decoding in older OS's.
         response = [unarchiver decodeObjectOfClass:[NSURLResponse class] forKey:@"WebResourceResponse"]; // WebResourceResponseKey in WebResource.m
 #else
+    @try {
         response = [unarchiver decodeObjectForKey:@"WebResourceResponse"]; // WebResourceResponseKey in WebResource.m
 #endif
         [unarchiver finishDecoding];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to