Title: [222808] trunk/LayoutTests
- Revision
- 222808
- Author
- [email protected]
- Date
- 2017-10-03 14:10:24 -0700 (Tue, 03 Oct 2017)
Log Message
Layout Test http/tests/inspector/network/beacon-type.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=177834
Unreviewed test gardening.
* http/tests/inspector/network/beacon-type.html:
* http/tests/inspector/network/ping-type.html:
Don't wait for the resource to finish loading if it has already finished loading.
Logs showed the resource had already finished loading earlier, before this
promise microtask started running.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (222807 => 222808)
--- trunk/LayoutTests/ChangeLog 2017-10-03 20:55:59 UTC (rev 222807)
+++ trunk/LayoutTests/ChangeLog 2017-10-03 21:10:24 UTC (rev 222808)
@@ -1,3 +1,16 @@
+2017-10-03 Joseph Pecoraro <[email protected]>
+
+ Layout Test http/tests/inspector/network/beacon-type.html is flaky.
+ https://bugs.webkit.org/show_bug.cgi?id=177834
+
+ Unreviewed test gardening.
+
+ * http/tests/inspector/network/beacon-type.html:
+ * http/tests/inspector/network/ping-type.html:
+ Don't wait for the resource to finish loading if it has already finished loading.
+ Logs showed the resource had already finished loading earlier, before this
+ promise microtask started running.
+
2017-10-03 Daniel Bates <[email protected]>
XMLHttpRequest.setRequestHeader() should allow Content-Transfer-Encoding header; remove
Modified: trunk/LayoutTests/http/tests/inspector/network/beacon-type.html (222807 => 222808)
--- trunk/LayoutTests/http/tests/inspector/network/beacon-type.html 2017-10-03 20:55:59 UTC (rev 222807)
+++ trunk/LayoutTests/http/tests/inspector/network/beacon-type.html 2017-10-03 21:10:24 UTC (rev 222808)
@@ -20,10 +20,6 @@
function test()
{
- // FIXME: <https://webkit.org/b/177834> Layout Test http/tests/inspector/network/beacon-type.html is flaky.
- // Adding debugging to try to determine why this test is timing out.
- InspectorTest.debug();
-
let suite = InspectorTest.createAsyncSuite("Resource.Type.Beacon");
function addTestCase({name, description, _expression_, resourceHandler}) {
@@ -36,10 +32,12 @@
.then((event) => {
resource = event.data.resource;
alwaysTest(resource);
- return Promise.race([
- resource.awaitEvent(WI.Resource.Event.LoadingDidFinish),
- resource.awaitEvent(WI.Resource.Event.LoadingDidFail),
- ]);
+ if (resource.isLoading()) {
+ return Promise.race([
+ resource.awaitEvent(WI.Resource.Event.LoadingDidFinish),
+ resource.awaitEvent(WI.Resource.Event.LoadingDidFail),
+ ]);
+ }
})
.then(() => { resourceHandler(resource); })
.then(resolve, reject);
Modified: trunk/LayoutTests/http/tests/inspector/network/ping-type.html (222807 => 222808)
--- trunk/LayoutTests/http/tests/inspector/network/ping-type.html 2017-10-03 20:55:59 UTC (rev 222807)
+++ trunk/LayoutTests/http/tests/inspector/network/ping-type.html 2017-10-03 21:10:24 UTC (rev 222808)
@@ -44,10 +44,12 @@
.then((event) => {
resource = event.data.resource;
alwaysTest(resource);
- return Promise.race([
- resource.awaitEvent(WI.Resource.Event.LoadingDidFinish),
- resource.awaitEvent(WI.Resource.Event.LoadingDidFail),
- ]);
+ if (resource.isLoading()) {
+ return Promise.race([
+ resource.awaitEvent(WI.Resource.Event.LoadingDidFinish),
+ resource.awaitEvent(WI.Resource.Event.LoadingDidFail),
+ ]);
+ }
})
.then(() => { resourceHandler(resource); })
.then(resolve, reject);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
