Title: [222860] trunk/Source/WebInspectorUI
- Revision
- 222860
- Author
- [email protected]
- Date
- 2017-10-04 11:30:38 -0700 (Wed, 04 Oct 2017)
Log Message
Web Inspector: After enabling the new Network Tab in experimental settings, the network tab disappears
https://bugs.webkit.org/show_bug.cgi?id=177774
<rdar://problem/34771647>
Patch by Joseph Pecoraro <[email protected]> on 2017-10-04
Reviewed by Devin Rousso.
* UserInterface/Views/SettingsTabContentView.js:
When enabling the new network tab, ensure it gets added to the list of open tabs.
Place it where the old network tab was so the UI is as consistent as possible.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (222859 => 222860)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-10-04 17:57:22 UTC (rev 222859)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-10-04 18:30:38 UTC (rev 222860)
@@ -1,3 +1,15 @@
+2017-10-04 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: After enabling the new Network Tab in experimental settings, the network tab disappears
+ https://bugs.webkit.org/show_bug.cgi?id=177774
+ <rdar://problem/34771647>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/SettingsTabContentView.js:
+ When enabling the new network tab, ensure it gets added to the list of open tabs.
+ Place it where the old network tab was so the UI is as consistent as possible.
+
2017-10-03 Ross Kirsling <[email protected]>
Web Inspector: Layers tab sidebar's DOM highlight should be by row hover, not row selection
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (222859 => 222860)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2017-10-04 17:57:22 UTC (rev 222859)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2017-10-04 18:30:38 UTC (rev 222860)
@@ -252,6 +252,25 @@
if (window.NetworkAgent) {
experimentalSettingsView.addSetting(WI.UIString("Network Tab:"), WI.settings.experimentalEnableNewNetworkTab, WI.UIString("New Network Tab"));
experimentalSettingsView.addSeparator();
+
+ // Ensure the toggled network tab is open after reloading the frontend.
+ // Put it in the same place as the existing network tab or just at the end.
+ WI.settings.experimentalEnableNewNetworkTab.addEventListener(WI.Setting.Event.Changed, () => {
+ let newNetworkTableEnabled = WI.settings.experimentalEnableNewNetworkTab.value;
+ let incomingTabIdentifier = newNetworkTableEnabled ? WI.NetworkTabContentView.Type : WI.LegacyNetworkTabContentView.Type;
+ let outgoingTabIdentifier = newNetworkTableEnabled ? WI.LegacyNetworkTabContentView.Type : WI.NetworkTabContentView.Type;
+
+ let tabs = WI._openTabsSetting.value.slice();
+ tabs.remove(incomingTabIdentifier);
+
+ let index = tabs.indexOf(outgoingTabIdentifier);
+ if (index !== -1)
+ tabs.insertAtIndex(incomingTabIdentifier, index);
+ else
+ tabs.push(incomingTabIdentifier);
+
+ WI._openTabsSetting.value = tabs;
+ });
}
if (window.LayerTreeAgent) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
