Title: [222863] trunk/Source/WebCore
- Revision
- 222863
- Author
- an...@apple.com
- Date
- 2017-10-04 11:52:08 -0700 (Wed, 04 Oct 2017)
Log Message
Add assert verifying all renderers get destroyed
https://bugs.webkit.org/show_bug.cgi?id=177870
Reviewed by Zalan Bujtas.
* rendering/RenderView.cpp:
(WebCore::RenderView::willBeDestroyed):
Add assert to verify all renderers for this tree have been destroyed before the RenderView is.
* rendering/RenderView.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (222862 => 222863)
--- trunk/Source/WebCore/ChangeLog 2017-10-04 18:37:47 UTC (rev 222862)
+++ trunk/Source/WebCore/ChangeLog 2017-10-04 18:52:08 UTC (rev 222863)
@@ -1,3 +1,17 @@
+2017-10-04 Antti Koivisto <an...@apple.com>
+
+ Add assert verifying all renderers get destroyed
+ https://bugs.webkit.org/show_bug.cgi?id=177870
+
+ Reviewed by Zalan Bujtas.
+
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::willBeDestroyed):
+
+ Add assert to verify all renderers for this tree have been destroyed before the RenderView is.
+
+ * rendering/RenderView.h:
+
2017-10-04 Daniel Bates <daba...@apple.com>
TextDecorationPainter::m_wavyOffset should be a float
Modified: trunk/Source/WebCore/rendering/RenderView.cpp (222862 => 222863)
--- trunk/Source/WebCore/rendering/RenderView.cpp 2017-10-04 18:37:47 UTC (rev 222862)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2017-10-04 18:52:08 UTC (rev 222863)
@@ -641,6 +641,13 @@
return frameView().isScrollable(defineScrollable);
}
+void RenderView::willBeDestroyed()
+{
+ RenderBlockFlow::willBeDestroyed();
+
+ ASSERT_WITH_MESSAGE(m_rendererCount == 1, "All other renderers in this render tree should have be destroyed");
+}
+
void RenderView::absoluteRects(Vector<IntRect>& rects, const LayoutPoint& accumulatedOffset) const
{
rects.append(snappedIntRect(accumulatedOffset, layer()->size()));
Modified: trunk/Source/WebCore/rendering/RenderView.h (222862 => 222863)
--- trunk/Source/WebCore/rendering/RenderView.h 2017-10-04 18:37:47 UTC (rev 222862)
+++ trunk/Source/WebCore/rendering/RenderView.h 2017-10-04 18:52:08 UTC (rev 222863)
@@ -286,6 +286,8 @@
bool isScrollableOrRubberbandableBox() const override;
+ void willBeDestroyed() override;
+
private:
FrameView& m_frameView;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
